Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the RubocopRailsAccessibility/LinkHasHref rule #4

Merged
merged 4 commits into from
Sep 21, 2022
Merged

Remove the RubocopRailsAccessibility/LinkHasHref rule #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c6dbd4d
Remove LinkHasHref
khiga8 Sep 2, 2022
d911c3a
Remove broken rule for now
khiga8 Sep 2, 2022
0866d5d
Merge branch 'main' into kh-remove-link-has-href-for-now
khiga8 Sep 15, 2022
689cda2
Update README.md
Sep 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,6 @@ examples/documentation.
## Rules

- [RuboCop::Cop::Accessibility::ImageHasAlt](guides/image-has-alt.md)
- [RuboCop::Cop::Accessibility::LinkHasHref](guides/link-has-href.md)
- [RuboCop::Cop::Accessibility::NoPositiveTabindex](guides/no-positive-tabindex.md)
- [RuboCop::Cop::Accessibility::NoRedundantImageAlt](guides/no-redundant-image-alt.md)

Expand Down
3 changes: 0 additions & 3 deletions config/default.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,6 @@ AllCops:
RubocopRailsAccessibility/ImageHasAlt:
Enabled: true
StyleGuide: https://github.com/github/rubocop-rails-accessibility/blob/master/guides/image-has-alt.md
RubocopRailsAccessibility/LinkHasHref:
Enabled: true
StyleGuide: https://github.com/github/rubocop-rails-accessibility/blob/master/guides/link-has-href.md
RubocopRailsAccessibility/NoPositiveTabindex:
Enabled: true
StyleGuide: https://github.com/github/rubocop-rails-accessibility/blob/master/guides/no-positive-tabindex.md
Expand Down
29 changes: 0 additions & 29 deletions guides/link-has-href.md
View file
Open in desktop

This file was deleted.

23 changes: 0 additions & 23 deletions lib/rubocop/cop/rubocop-rails-accessibility/link_has_href.rb
View file
Open in desktop

This file was deleted.

35 changes: 0 additions & 35 deletions test/test_link_has_href.rb
View file
Open in desktop

This file was deleted.