refactor!: remove gno build command (#1297)

Closes: #1242

In favor of `gno precompile -gobuild`. 

As seen in the tests written for `gno build` in this PR #1103, the
command's behavior is kinda unexpected. It actually doesn't care about
the syntax of gno files and only relies on go files found in the path
passed as an argument.

Because of that, I chose to name the flag `-gobuild` instead of `-build`
because I found that represents better what's really happening when this
flag is provided.

As mentioned in the linked issue, `gno build` will be re-implemented in
the future with an other behavior.

<!-- please provide a detailed description of the changes made in this
pull request. -->

<details><summary>Contributors' checklist...</summary>

- [ ] Added new tests, or not needed, or not feasible
- [ ] Provided an example (e.g. screenshot) to aid review or the PR is
self-explanatory
- [ ] Updated the official documentation or not needed
- [ ] No breaking changes were made, or a `BREAKING CHANGE: xxx` message
was included in the description
- [ ] Added references to related issues and PRs
- [ ] Provided any useful hints for running manual tests
- [ ] Added new benchmarks to [generated
graphs](https://gnoland.github.io/benchmarks), if any. More info
[here](https://github.com/gnolang/gno/blob/master/.benchmarks/README.md).
</details>

.github/workflows/examples.yml

@@ -32,8 +32,7 @@ jobs:
         with:
           go-version: ${{ matrix.goversion }}
       - run: go install -v ./gnovm/cmd/gno
-      - run: go run ./gnovm/cmd/gno precompile --verbose ./examples
-      - run: go run ./gnovm/cmd/gno build --verbose ./examples
+      - run: go run ./gnovm/cmd/gno precompile --verbose --gobuild ./examples
   test:
     strategy:
       fail-fast: false

gnovm/cmd/gno/main.go

@@ -33,7 +33,6 @@ func newGnocliCmd(io commands.IO) *commands.Command {
 		newTestCmd(io),
 		newLintCmd(io),
 		newRunCmd(io),
-		newBuildCmd(io),
 		newPrecompileCmd(io),
 		newCleanCmd(io),
 		newReplCmd(),

gnovm/cmd/gno/precompile.go

@@ -18,6 +18,7 @@ type precompileCfg struct {
 	verbose     bool
 	skipFmt     bool
 	skipImports bool
+	gobuild     bool
 	goBinary    string
 	gofmtBinary string
 	output      string
@@ -30,6 +31,11 @@ type precompileOptions struct {
 	precompiled map[importPath]struct{}
 }
 
+var defaultPrecompileCfg = &precompileCfg{
+	verbose:  false,
+	goBinary: "go",
+}
+
 func newPrecompileOptions(cfg *precompileCfg) *precompileOptions {
 	return &precompileOptions{cfg, map[importPath]struct{}{}}
 }
@@ -85,6 +91,13 @@ func (c *precompileCfg) RegisterFlags(fs *flag.FlagSet) {
 		"do not precompile imports recursively",
 	)
 
+	fs.BoolVar(
+		&c.gobuild,
+		"gobuild",
+		false,
+		"run go build on generated go files, ignoring test files",
+	)
+
 	fs.StringVar(
 		&c.goBinary,
 		"go-binary",
@@ -125,7 +138,6 @@ func execPrecompile(cfg *precompileCfg, args []string, io commands.IO) error {
 		if err != nil {
 			err = fmt.Errorf("%s: precompile: %w", filepath, err)
 			io.ErrPrintfln("%s", err.Error())
-
 			errCount++
 		}
 	}
@@ -134,6 +146,27 @@ func execPrecompile(cfg *precompileCfg, args []string, io commands.IO) error {
 		return fmt.Errorf("%d precompile errors", errCount)
 	}
 
+	if cfg.gobuild {
+		paths, err := gnoPackagesFromArgs(args)
+		if err != nil {
+			return fmt.Errorf("list packages: %w", err)
+		}
+
+		errCount = 0
+		for _, pkgPath := range paths {
+			_ = pkgPath
+			err = goBuildFileOrPkg(pkgPath, cfg)
+			if err != nil {
+				err = fmt.Errorf("%s: build pkg: %w", pkgPath, err)
+				io.ErrPrintfln("%s\n", err.Error())
+				errCount++
+			}
+		}
+		if errCount > 0 {
+			return fmt.Errorf("%d build errors", errCount)
+		}
+	}
+
 	return nil
 }
 
@@ -219,3 +252,14 @@ func precompileFile(srcPath string, opts *precompileOptions) error {
 
 	return nil
 }
+
+func goBuildFileOrPkg(fileOrPkg string, cfg *precompileCfg) error {
+	verbose := cfg.verbose
+	goBinary := cfg.goBinary
+
+	if verbose {
+		fmt.Fprintf(os.Stderr, "%s\n", fileOrPkg)
+	}
+
+	return gno.PrecompileBuildPackage(fileOrPkg, goBinary)
+}

gnovm/cmd/gno/precompile_test.go

@@ -1,18 +1,26 @@
 package main
 
-import "testing"
+import (
+	"testing"
 
-func TestPrecompileApp(t *testing.T) {
-	tc := []testMainCase{
-		{
-			args:        []string{"precompile"},
-			errShouldBe: "flag: help requested",
-		},
+	"github.com/rogpeppe/go-internal/testscript"
+	"github.com/stretchr/testify/require"
 
-		// {args: []string{"precompile", "..."}, stdoutShouldContain: "..."},
-		// TODO: recursive
-		// TODO: valid files
-		// TODO: invalid files
+	"github.com/gnolang/gno/gnovm/pkg/integration"
+)
+
+func Test_ScriptsPrecompile(t *testing.T) {
+	p := testscript.Params{
+		Dir: "testdata/gno_precompile",
+	}
+
+	if coverdir, ok := integration.ResolveCoverageDir(); ok {
+		err := integration.SetupTestscriptsCoverage(&p, coverdir)
+		require.NoError(t, err)
 	}
-	testMainCaseRun(t, tc)
+
+	err := integration.SetupGno(&p, t.TempDir())
+	require.NoError(t, err)
+
+	testscript.Run(t, p)
 }

gnovm/cmd/gno/test.go

@@ -231,7 +231,7 @@ func execTest(cfg *testCfg, args []string, io commands.IO) error {
 			if err != nil {
 				return errors.New("cannot resolve build dir")
 			}
-			err = goBuildFileOrPkg(tempDir, defaultBuildOptions)
+			err = goBuildFileOrPkg(tempDir, defaultPrecompileCfg)
 			if err != nil {
 				io.ErrPrintln(err)
 				io.ErrPrintln("FAIL")