refactor!: remove gno build command
#1297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1297 +/- ##
==========================================
+ Coverage 55.94% 55.98% +0.03%
==========================================
Files 420 420
Lines 65415 65443 +28
==========================================
+ Hits 36596 36637 +41
+ Misses 25961 25942 -19
- Partials 2858 2864 +6 ☔ View full report in Codecov by Sentry. |
tbruyelle
changed the title
gno build commandgno build command
tbruyelle
force-pushed
the
tbruyelle/refactor/remove-gno-build
branch
from
101d2bb to
41a602d
Compare
Closes: gnolang#1242 In favor of `gno precompile --build`
tbruyelle
force-pushed
the
tbruyelle/refactor/remove-gno-build
branch
from
41a602d to
ad1df0a
Compare
thehowl
approved these changes
Nov 16, 2023
3 tasks
7 tasks
7 tasks
thehowl
pushed a commit
that referenced
this pull request
Jan 10, 2024
- Remove `gno build` as it doesn't exist anymore (see: #1297) - s/go-binary/gofmt <details><summary>Contributors' checklist...</summary> - [x] Added new tests, or not needed, or not feasible - [x] Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory - [x] Updated the official documentation or not needed - [x] No breaking changes were made, or a `BREAKING CHANGE: xxx` message was included in the description - [x] Added references to related issues and PRs - [x] Provided any useful hints for running manual tests - [x] Added new benchmarks to [generated graphs](https://gnoland.github.io/benchmarks), if any. More info [here](https://github.com/gnolang/gno/blob/master/.benchmarks/README.md). </details>
gfanton
pushed a commit
to moul/gno
that referenced
this pull request
Jan 18, 2024
- Remove `gno build` as it doesn't exist anymore (see: gnolang#1297) - s/go-binary/gofmt <details><summary>Contributors' checklist...</summary> - [x] Added new tests, or not needed, or not feasible - [x] Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory - [x] Updated the official documentation or not needed - [x] No breaking changes were made, or a `BREAKING CHANGE: xxx` message was included in the description - [x] Added references to related issues and PRs - [x] Provided any useful hints for running manual tests - [x] Added new benchmarks to [generated graphs](https://gnoland.github.io/benchmarks), if any. More info [here](https://github.com/gnolang/gno/blob/master/.benchmarks/README.md). </details>
harry-hov
added a commit
to harry-hov/gno
that referenced
this pull request
Apr 8, 2024
As `gno build` was removed in gnolang#1297 in favor of `gno transpile -gobuild`.
harry-hov
added a commit
to harry-hov/gno
that referenced
this pull request
Apr 8, 2024
As `gno build` was removed in gnolang#1297 in favor of `gno transpile -gobuild`.
harry-hov
added a commit
that referenced
this pull request
Apr 24, 2024
`gno build` was removed in #1297 in favor of `gno transpile -gobuild`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #1242
In favor of
gno precompile -gobuild.As seen in the tests written for
gno buildin this PR #1103, the command's behavior is kinda unexpected. It actually doesn't care about the syntax of gno files and only relies on go files found in the path passed as an argument.Because of that, I chose to name the flag
-gobuildinstead of-buildbecause I found that represents better what's really happening when this flag is provided.As mentioned in the linked issue,
gno buildwill be re-implemented in the future with an other behavior.Contributors' checklist...
BREAKING CHANGE: xxxmessage was included in the description