cmd/gnoland: execBalancesExport leaks the opened file and at no point closes it

[odeke-em]

Reading through this code

gno/gno.land/cmd/gnoland/genesis_balances_export.go

Lines 29 to 78 in 2838ad1

	func execBalancesExport(cfg *balancesCfg, io commands.IO, args []string) error {
	// Load the genesis
	genesis, loadErr := types.GenesisDocFromFile(cfg.genesisPath)
	if loadErr != nil {
	return fmt.Errorf("unable to load genesis, %w", loadErr)
	}
	// Load the genesis state
	if genesis.AppState == nil {
	return errAppStateNotSet
	}
	state := genesis.AppState.(gnoland.GnoGenesisState)
	if len(state.Balances) == 0 {
	io.Println("No genesis balances to export")
	return nil
	}
	// Make sure the output file path is specified
	if len(args) == 0 {
	return errNoOutputFile
	}
	// Open output file
	outputFile, err := os.OpenFile(
	args[0],
	os.O_RDWR|os.O_CREATE|os.O_APPEND,
	0o755,
	)
	if err != nil {
	return fmt.Errorf("unable to create output file, %w", err)
	}
	// Save the balances
	for _, balance := range state.Balances {
	if _, err = outputFile.WriteString(
	fmt.Sprintf("%s\n", balance),
	); err != nil {
	return fmt.Errorf("unable to write to output, %w", err)
	}
	}
	io.Printfln(
	"Exported %d balances",
	len(state.Balances),
	)
	return nil
	}

at no point is the file that's opened per

gno/gno.land/cmd/gnoland/genesis_balances_export.go

Line 54 in 2838ad1

outputFile, err := os.OpenFile(

ever closed

[kristovatlas]

Thanks for the report, @odeke-em. We're looking into it.

[odeke-em]

I've mailed out PR #3294.