Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(contribs): close file in execBalancesExport #3294

Merged
merged 2 commits into from
Dec 7, 2024

Conversation

odeke-em
Copy link
Contributor

@odeke-em odeke-em commented Dec 7, 2024

Ensures that the opened file is not leaked and
closed after use.

Fixes #3032

Ensures that the opened file is not leaked and
closed after use.

Fixes gnolang#3032
@Gno2D2
Copy link
Collaborator

Gno2D2 commented Dec 7, 2024

I'm a bot that assists the Gno Core team in maintaining this repository. My role is to ensure that contributors understand and follow our guidelines, helping to streamline the development process.

The following requirements must be fulfilled before a pull request can be merged.
Some requirement checks are automated and can be verified by the CI, while others need manual verification by a staff member.

These requirements are defined in this configuration file.

Automated Checks

🔴 Maintainers must be able to edit this pull request (more info)
🟢 The pull request head branch must be up-to-date with its base (more info)

Manual Checks

  • The pull request description provides enough details
Debug
Automated Checks
Maintainers must be able to edit this pull request (more info)

If

🟢 Condition met
└── 🟢 On every pull request

Then

🔴 Requirement not satisfied
└── 🔴 Maintainer can modify this pull request

The pull request head branch must be up-to-date with its base (more info)

If

🟢 Condition met
└── 🟢 On every pull request

Then

🟢 Requirement satisfied
└── 🟢 Head branch (orijtech:close-execBalancesExport-file) is up to date with base (master): behind by 0 / ahead by 2

Manual Checks
The pull request description provides enough details

If

🟢 Condition met
└── 🟢 Not (🔴 Pull request author is a member of the team: core-contributors)

Can be checked by

  • team core-contributors

Copy link

codecov bot commented Dec 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

Copy link
Member

@thehowl thehowl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's not a problem in the real world, but it doesn't hurt.

@thehowl
Copy link
Member

thehowl commented Dec 7, 2024

Please open any further PRs from your personal account, not your organization's account. this allows us to modify the PR and update it with master if necessary; helps us to verify the CI would not be failing on master.

@thehowl thehowl merged commit 79c9b04 into gnolang:master Dec 7, 2024
4 of 5 checks passed
omarsy pushed a commit to TERITORI/gno that referenced this pull request Dec 7, 2024
Ensures that the opened file is not leaked and
closed after use.

Fixes gnolang#3032
Villaquiranm pushed a commit to Villaquiranm/gno that referenced this pull request Dec 9, 2024
Ensures that the opened file is not leaked and
closed after use.

Fixes gnolang#3032
r3v4s pushed a commit to gnoswap-labs/gno that referenced this pull request Dec 10, 2024
Ensures that the opened file is not leaked and
closed after use.

Fixes gnolang#3032
albttx pushed a commit that referenced this pull request Jan 10, 2025
Ensures that the opened file is not leaked and
closed after use.

Fixes #3032
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

cmd/gnoland: execBalancesExport leaks the opened file and at no point closes it
4 participants