Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Effective Gno #1000

Merged
merged 56 commits into from
Feb 8, 2024
Merged

docs: Effective Gno #1000

merged 56 commits into from
Feb 8, 2024

Conversation

moul
Copy link
Member

@moul moul commented Jul 29, 2023

I'm working towards a concise style, suggesting an initial review of Effective Go, followed by Gno-specific practices. I'm also considering making code snippets in this documentation unit-testable.

@moul moul self-assigned this Jul 29, 2023
@moul moul added this to the 🌟 main.gno.land (wanted) milestone Sep 8, 2023
@moul moul force-pushed the dev/moul/effective-gno branch from 0a9fac1 to d96c266 Compare November 14, 2023 16:43
@github-actions github-actions bot added 🧾 package/realm Tag used for new Realms or Packages. 📦 🤖 gnovm Issues or PRs gnovm related 📦 🌐 tendermint v2 Issues or PRs tm2 related 📦 ⛰️ gno.land Issues or PRs gno.land package related and removed 🧾 package/realm Tag used for new Realms or Packages. 📦 🤖 gnovm Issues or PRs gnovm related 📦 🌐 tendermint v2 Issues or PRs tm2 related 📦 ⛰️ gno.land Issues or PRs gno.land package related labels Nov 14, 2023
@moul moul force-pushed the dev/moul/effective-gno branch from 77c66c0 to cb8df8f Compare November 14, 2023 16:54
@github-actions github-actions bot added 🧾 package/realm Tag used for new Realms or Packages. 📦 🤖 gnovm Issues or PRs gnovm related 📦 🌐 tendermint v2 Issues or PRs tm2 related 📦 ⛰️ gno.land Issues or PRs gno.land package related labels Nov 14, 2023
@moul moul force-pushed the dev/moul/effective-gno branch from cb8df8f to e49b255 Compare November 14, 2023 16:57
Signed-off-by: Manfred Touron <[email protected]>
@moul moul force-pushed the dev/moul/effective-gno branch from e49b255 to a9359c0 Compare November 14, 2023 16:57
@github-actions github-actions bot removed 🧾 package/realm Tag used for new Realms or Packages. 📦 🤖 gnovm Issues or PRs gnovm related 📦 🌐 tendermint v2 Issues or PRs tm2 related 📦 ⛰️ gno.land Issues or PRs gno.land package related labels Nov 14, 2023
Copy link
Contributor

@mvertes mvertes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This guide looks good to me and is extremely useful.

To go further, it would be also useful to have pointers on grc20 or grc721 reference documents, and other important concept documents about smart contracts, if they exist. The same for relevant security practices. I'm always found of a solid bibliography which enhances the quality a lot.

docs/how-to-guides/effective-gno.md Outdated Show resolved Hide resolved
@thehowl
Copy link
Member

thehowl commented Feb 1, 2024

Pending @leohhhn review, if all's good we can merge afterwards!

Copy link
Contributor

@leohhhn leohhhn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just left a couple of suggestions, mostly related to token <> coin consistency, and typos. Looks awesome, can't wait to merge this 💯

docs/how-to-guides/effective-gno.md Show resolved Hide resolved
docs/how-to-guides/effective-gno.md Outdated Show resolved Hide resolved
docs/how-to-guides/effective-gno.md Show resolved Hide resolved
docs/how-to-guides/effective-gno.md Show resolved Hide resolved
docs/how-to-guides/effective-gno.md Show resolved Hide resolved
docs/how-to-guides/effective-gno.md Show resolved Hide resolved
docs/how-to-guides/effective-gno.md Outdated Show resolved Hide resolved
@leohhhn leohhhn mentioned this pull request Feb 2, 2024
Copy link
Contributor

@leohhhn leohhhn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Linked banker locally, take a look at suggestion :)

docs/how-to-guides/effective-gno.md Outdated Show resolved Hide resolved
@moul
Copy link
Member Author

moul commented Feb 8, 2024

MERGING!

@moul moul merged commit 769ad6e into gnolang:master Feb 8, 2024
6 checks passed
@moul moul deleted the dev/moul/effective-gno branch February 8, 2024 12:02
leohhhn added a commit to leohhhn/gno that referenced this pull request Feb 8, 2024
I'm working towards a concise style, suggesting an initial review of
[Effective Go](https://go.dev/doc/effective_go), followed by
Gno-specific practices. I'm also considering making code snippets in
this documentation unit-testable.

---------

Signed-off-by: Manfred Touron <[email protected]>
Signed-off-by: moul <[email protected]>
Co-authored-by: jon roethke <[email protected]>
Co-authored-by: Leon Hudak <[email protected]>
Co-authored-by: Morgan <[email protected]>
Co-authored-by: Marc Vertes <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Status: ✅ Done
Status: 🌟 Wanted for Launch
Archived in project
Development

Successfully merging this pull request may close these issues.

8 participants