Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Effective Gno #1000
docs: Effective Gno #1000
Changes from 18 commits
a9359c0
4ac286a
6c9c7cb
47165d3
9cdde6a
f7361de
13818a6
450d5df
9a7e0a8
e00d8cc
25e10a2
2726149
8d59747
c43218c
507fa84
10673fc
d67cf4e
e761ebc
1ce7d81
c7e305e
0d53b38
0768dce
e5d95a2
c63a170
989b299
e1715e4
b7d1d5a
fadd38c
66bf747
aef37b5
b5ff694
fe0a2df
92be992
e871e37
ea55eec
3b7fa93
c0323f0
5f0bcc3
78572df
96d9574
5ff0eb5
bc08da1
469ad48
b5572ca
1004314
c1df3f6
33d806e
71b2e76
16984a2
a1d980f
8002296
58ac245
d03b0d7
718b5fc
85e94be
594dde8
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I understand this is a simplified example, but to me this message + the corresponding code block implies that were
counter
public that one would be able to increment it even without a setter function likeIncCounter()
. And if there is a public setter function likeIncCounter
present which, as it is currently implemented, would be accessible for all to read/write provided there is no modifier present.Am I understanding this incorrectly?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this still true? I think this code path it ends up following if something like that happens. https://github.com/gnolang/gno/blob/master/gnovm/pkg/gnolang/realm.go#L148
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're likely correct.
I believe we should examine this more thoroughly, ensuring we assess not just the variable, but also aspects like whether it's a pointer.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Leftover?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The inline to-dos can be fixed now or later. Although some people may dislike them, I personally find them beneficial when merged in this way.
Regarding write permissions, I believe you have the highest level of permissions, possibly because it's my personal fork. However, you still have the following options: