Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(repl): Add support for new declarations. #1044

Merged
merged 1 commit into from
Aug 15, 2023
Merged

feat(repl): Add support for new declarations. #1044

merged 1 commit into from
Aug 15, 2023

Conversation

ajnavarro
Copy link
Contributor

@ajnavarro ajnavarro commented Aug 10, 2023 •
edited
Loading

Now the REPL is able to work with Structs, Interfaces, global and local variables, and constants.

repl-extras

How to run it manually:

  • go to gnovm folder
  • run make install
  • execute gno repl

Related issues:

  • Added new tests, or not needed, or not feasible
  • Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory
  • Updated the official documentation or not needed
  • No breaking changes were made, or a BREAKING CHANGE: xxx message was included in the description
  • Added references to related issues and PRs
  • Provided any useful hints for running manual tests
  • Added new benchmarks to generated graphs, if any. More info here.

@ajnavarro
feat(repl): Add support for new declarations.
a2f03b2 
- Adding support for Structs
- Adding support for Interfaces
- Adding support for consts
- Adding support for global variables

Signed-off-by: Antonio Navarro Perez <[email protected]>
@github-actions github-actions bot added the 📦 🤖 gnovm Issues or PRs gnovm related label Aug 10, 2023
@ajnavarro ajnavarro marked this pull request as ready for review August 10, 2023 15:02
@ajnavarro ajnavarro requested a review from a team as a code owner August 10, 2023 15:02
zivkovicmilos
zivkovicmilos approved these changes Aug 10, 2023
View reviewed changes
Copy link
Member

@zivkovicmilos zivkovicmilos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 💯

@harry-hov harry-hov requested review from harry-hov and moul August 10, 2023 16:36
@moul
Copy link
Member

moul commented Aug 10, 2023

Can you add a small example, screenshot or before/after comparison?

@moul moul mentioned this pull request Aug 10, 2023
Open
3 tasks
@ajnavarro
Copy link
Contributor Author

@moul added a gif with the example tested on unit tests.

@moul moul merged commit c6c601c into gnolang:master Aug 15, 2023
Doozers pushed a commit to Doozers/gno that referenced this pull request Aug 31, 2023
@ajnavarro @Doozers
feat(repl): Add support for new declarations. (gnolang#1044)
13cc3c8
@moul moul added this to the 🌟 main.gno.land (wanted) milestone Sep 18, 2023
@thehowl thehowl mentioned this pull request Oct 5, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zivkovicmilos zivkovicmilos zivkovicmilos approved these changes

@moul moul moul approved these changes

@harry-hov harry-hov Awaiting requested review from harry-hov

Assignees

@ajnavarro ajnavarro

Labels
📦 🤖 gnovm Issues or PRs gnovm related
Projects
🚀 The Launch [DEPRECATED]
Archived in project
🧐 Review Meeting
Archived in project
Milestone
DEPRECATED:🌟 main.gno.land (wanted)
Development

Successfully merging this pull request may close these issues.
3 participants
@ajnavarro @moul @zivkovicmilos