feat(repl): support multi-line inputs and declarations #978

ajnavarro · 2023-07-17T13:51:12Z

How to run it manually:

go to gnovm folder
run make install
execute gno repl

BREAKING CHANGE: repl inputs now are different.

Related issues:

Refactor repl to make it more useful:

Added reset command to clean the state
No need to specify if you are adding a function, import, interface, struct or an expression
Functions support
~~Constants support~~ Will be done on a following PR
~~Struct and Interfaces support~~ Will be done on a following PR
~~Variables support~~ Will be done on a following PR
Unit tests
Imports support
Repl multiline input support

Contributors Checklist

Added new tests, or not needed, or not feasible
Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory
Updated the official documentation or not needed
No breaking changes were made, or a BREAKING CHANGE: xxx message was included in the description
Added references to related issues and PRs
Provided any useful hints for running manual tests
Added new benchmarks to generated graphs, if any. More info here.

gnovm/tests/imports.go

moul · 2023-07-20T11:15:16Z

Looks promising!

Note that I intend to reuse the new Repl{} object outside of the CLI and will need to pass custom Stdin/Stdout. Specifically, I plan to experiment with ttys.

If you're confident, I recommend creating a gnovm/pkg/repl package now to make it more generic. Otherwise, we can migrate it later.

ajnavarro · 2023-07-25T08:57:56Z

If you're confident, I recommend creating a gnovm/pkg/repl package now to make it more generic. Otherwise, we can migrate it later.

@moul all the repl logic is already included into gnovm/pkg/repl with new tests.

zivkovicmilos

Looks and works great 💯

I've left some super-minor comments.

Love the gif demo, we should standardize it for PRs

gnovm/cmd/gno/repl.go

gnovm/pkg/repl/repl.go

gnovm/pkg/repl/repl_test.go

gnovm/tests/imports.go

gnovm/pkg/repl/repl.go

gnovm/cmd/gno/repl.go

gfanton

LGTM 👍 (just one minor detail, see comment)

mvertes

Mostly cosmetic suggestions. The code looks good to me otherwise.

gnovm/pkg/repl/repl_test.go

gnovm/pkg/repl/repl.go

gnovm/cmd/gno/repl.go

gnovm/pkg/repl/repl.go

harry-hov

Some minor nitpicking. Overall LGTM 💯

moul · 2023-08-10T08:08:08Z

🎉 Congratulations on having the most approved PR! 🎉

Signed-off-by: Antonio Navarro Perez <[email protected]>

This is a followup of gnolang#978. Instead of starting in multi-line mode prior to submit, the line is parsed, and new inputs are appended to it as long as the statment is not complete, as detected by the Go scanner. This is simpler and more general than previous attempt. The secondary prompt is "...", different from primary "gno>", similarly to many REPL programs (node, python, bash, ...). The "/editor" command is removed as not useful anymore. Note also that it is now possible to exit using Ctrl-D.

![demo](https://github.com/gnolang/gno/assets/5792239/308e61bc-bdf9-498b-9fa7-cd756835f774) This is a followup of #978. Instead of starting in multi-line mode prior to submit, the line is parsed, and new inputs are appended to it as long as the statment is not complete, as detected by the Go scanner. This is simpler and more general than previous attempt. The secondary prompt is "...", different from primary "gno>", similarly to many REPL programs (node, python, bash, ...). The "/editor" command is removed as not useful anymore. Note also that it is now possible to exit using Ctrl-D. Related issues: #446 #950  <details><summary>Contributors' checklist...</summary> - [x] Added new tests, or not needed, or not feasible - [x] Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory - [x] Updated the official documentation or not needed - [x] No breaking changes were made, or a `BREAKING CHANGE: xxx` message was included in the description - [x] Added references to related issues and PRs - [ ] Provided any useful hints for running manual tests - [ ] Added new benchmarks to [generated graphs](https://gnoland.github.io/benchmarks), if any. More info [here](https://github.com/gnolang/gno/blob/master/.benchmarks/README.md). </details> --------- Co-authored-by: Manfred Touron <[email protected]>

![demo](https://github.com/gnolang/gno/assets/5792239/308e61bc-bdf9-498b-9fa7-cd756835f774) This is a followup of gnolang#978. Instead of starting in multi-line mode prior to submit, the line is parsed, and new inputs are appended to it as long as the statment is not complete, as detected by the Go scanner. This is simpler and more general than previous attempt. The secondary prompt is "...", different from primary "gno>", similarly to many REPL programs (node, python, bash, ...). The "/editor" command is removed as not useful anymore. Note also that it is now possible to exit using Ctrl-D. Related issues: gnolang#446 gnolang#950  <details><summary>Contributors' checklist...</summary> - [x] Added new tests, or not needed, or not feasible - [x] Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory - [x] Updated the official documentation or not needed - [x] No breaking changes were made, or a `BREAKING CHANGE: xxx` message was included in the description - [x] Added references to related issues and PRs - [ ] Provided any useful hints for running manual tests - [ ] Added new benchmarks to [generated graphs](https://gnoland.github.io/benchmarks), if any. More info [here](https://github.com/gnolang/gno/blob/master/.benchmarks/README.md). </details> --------- Co-authored-by: Manfred Touron <[email protected]>

github-actions bot assigned ajnavarro Jul 17, 2023

github-actions bot added the 📦 🤖 gnovm Issues or PRs gnovm related label Jul 17, 2023

ajnavarro force-pushed the improvement/repl branch 3 times, most recently from 5b8e146 to 79b8800 Compare July 20, 2023 10:26

moul reviewed Jul 20, 2023

View reviewed changes

gnovm/tests/imports.go Outdated Show resolved Hide resolved

ajnavarro mentioned this pull request Jul 21, 2023

[META] Gno Wishlist / Feature Request Dump #975

Open

ajnavarro force-pushed the improvement/repl branch from ef14112 to e66ccb5 Compare July 25, 2023 09:00

ajnavarro marked this pull request as ready for review July 25, 2023 09:57

ajnavarro requested a review from a team as a code owner July 25, 2023 09:57

zivkovicmilos self-requested a review July 26, 2023 14:45

michelleellen mentioned this pull request Jul 26, 2023

Create Agenda (26.07.2023)_#10.md gnolang/meetings#20

Closed

14 tasks

zivkovicmilos approved these changes Jul 27, 2023

View reviewed changes

moul mentioned this pull request Jul 27, 2023

Minutes: GitHub Review Meetings [every Thursday] gnolang/meetings#18

Open

3 tasks

moul requested a review from mvertes July 29, 2023 12:46

moul reviewed Jul 29, 2023

View reviewed changes

gnovm/pkg/repl/repl.go Outdated Show resolved Hide resolved

moul reviewed Jul 29, 2023

View reviewed changes

gnovm/pkg/repl/repl.go Outdated Show resolved Hide resolved

moul reviewed Jul 29, 2023

View reviewed changes

gnovm/pkg/repl/repl.go Show resolved Hide resolved

zivkovicmilos requested a review from gfanton August 7, 2023 15:30

gfanton reviewed Aug 8, 2023

View reviewed changes

gnovm/cmd/gno/repl.go Show resolved Hide resolved

gfanton approved these changes Aug 8, 2023

View reviewed changes

mvertes reviewed Aug 9, 2023

View reviewed changes

moul approved these changes Aug 9, 2023

View reviewed changes

mvertes approved these changes Aug 9, 2023

View reviewed changes

harry-hov reviewed Aug 9, 2023

View reviewed changes

gnovm/cmd/gno/repl.go Outdated Show resolved Hide resolved

harry-hov reviewed Aug 9, 2023

View reviewed changes

gnovm/pkg/repl/repl.go Outdated Show resolved Hide resolved

harry-hov approved these changes Aug 9, 2023

View reviewed changes

ajnavarro added 12 commits August 10, 2023 11:48

Fix grammar

a3bbf29

Signed-off-by: Antonio Navarro Perez <[email protected]>

Fix formatting

0ca1750

Signed-off-by: Antonio Navarro Perez <[email protected]>

Add support for multiline.

5d28441

Signed-off-by: Antonio Navarro Perez <[email protected]>

format code

ab9253b

Signed-off-by: Antonio Navarro Perez <[email protected]>

Fixed parsing error on Go 1.19

f51b79a

Signed-off-by: Antonio Navarro Perez <[email protected]>

Check partial erros due to differences between go versions

7815f82

Signed-off-by: Antonio Navarro Perez <[email protected]>

Comment println instead of delete it.

666e7bf

Signed-off-by: Antonio Navarro Perez <[email protected]>

Requested changes

799d3c2

Signed-off-by: Antonio Navarro Perez <[email protected]>

Reverting parallel execution

90a0cea

Signed-off-by: Antonio Navarro Perez <[email protected]>

Requested changes.

76ba3e3

Signed-off-by: Antonio Navarro Perez <[email protected]>

Fix problem with store initialization and add more tests

b194453

Signed-off-by: Antonio Navarro Perez <[email protected]>

Requested changes.

905d33b

Signed-off-by: Antonio Navarro Perez <[email protected]>

ajnavarro requested a review from jaekwon as a code owner August 10, 2023 09:52

github-actions bot added 🧾 package/realm Tag used for new Realms or Packages. 📦 🌐 tendermint v2 Issues or PRs tm2 related labels Aug 10, 2023

ajnavarro force-pushed the improvement/repl branch from ece3a06 to 905d33b Compare August 10, 2023 09:55

github-actions bot removed 🧾 package/realm Tag used for new Realms or Packages. 📦 🌐 tendermint v2 Issues or PRs tm2 related labels Aug 10, 2023

ajnavarro merged commit 0beb958 into gnolang:master Aug 10, 2023

ajnavarro deleted the improvement/repl branch August 10, 2023 10:08

ajnavarro mentioned this pull request Aug 10, 2023

feat(repl): Add support for new declarations. #1044

Merged

7 tasks

Doozers pushed a commit to Doozers/gno that referenced this pull request Aug 31, 2023

feat(repl): support multi-line inputs and declarations (gnolang#978)

182606b

moul added this to the 🌟 main.gno.land (wanted) milestone Sep 8, 2023

mvertes mentioned this pull request Sep 15, 2023

feat(repl): improve support of multi-line statements #1129

Merged

7 tasks

ajnavarro mentioned this pull request Oct 3, 2023

fix: allow constant values of infininitesimal non-zero floating points #1185

Merged

7 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(repl): support multi-line inputs and declarations #978

feat(repl): support multi-line inputs and declarations #978

ajnavarro commented Jul 17, 2023 •

edited

Loading

moul commented Jul 20, 2023 •

edited

Loading

ajnavarro commented Jul 25, 2023

zivkovicmilos left a comment

gfanton left a comment •

edited

Loading

mvertes left a comment

harry-hov left a comment

moul commented Aug 10, 2023 •

edited

Loading

feat(repl): support multi-line inputs and declarations #978

feat(repl): support multi-line inputs and declarations #978

Conversation

ajnavarro commented Jul 17, 2023 • edited Loading

Contributors Checklist

moul commented Jul 20, 2023 • edited Loading

ajnavarro commented Jul 25, 2023

zivkovicmilos left a comment

Choose a reason for hiding this comment

gfanton left a comment • edited Loading

Choose a reason for hiding this comment

mvertes left a comment

Choose a reason for hiding this comment

harry-hov left a comment

Choose a reason for hiding this comment

moul commented Aug 10, 2023 • edited Loading

ajnavarro commented Jul 17, 2023 •

edited

Loading

moul commented Jul 20, 2023 •

edited

Loading

gfanton left a comment •

edited

Loading

moul commented Aug 10, 2023 •

edited

Loading