Skip to content
This repository has been archived by the owner on Jun 24, 2022. It is now read-only.

Disable claim review on errors #2241

Merged
merged 5 commits into from
Jan 21, 2022
Merged

Conversation

alfetopito
Copy link
Contributor

Summary

Disable claim review button on errors

Screen Shot 2022-01-20 at 16 40 47

To Test

  1. Load a claim on behalf of another account for which you have no funds to cover 100%
  2. Go to approval step
  • You should not be able to move forward

    Background

Error due to lack of approval is still not captured, it'll be handled in another PR

@alfetopito alfetopito self-assigned this Jan 21, 2022
@alfetopito alfetopito requested review from a team January 21, 2022 00:43
@github-actions
Copy link
Contributor

  • 🔭 GP Swap: CoW Protocol v2 Swap UI

@fairlighteth
Copy link
Contributor

Nice. One suggestion to make the validation error text more explicit:

Insufficient {symbol} balance to cover the full investment amount.
Note: When investing for another claim account, you can only invest the full (100%) amount and no partial amounts.

Copy link
Contributor

@fairlighteth fairlighteth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve with a text suggestion.

@elena-zh
Copy link

Hey @alfetopito , to clarify: Will we disable 'Review' button when:

  1. claim for owner's account, and claim amount = 0
  2. token is not approved

Validation for claiming on behalf + when claim amount exceeds an investment amount works fine to me.

@alfetopito alfetopito force-pushed the disable-claim-review-on-errors branch from c280566 to 5bbe2d5 Compare January 21, 2022 16:37
@alfetopito alfetopito added the Auto-merge PRs with this tag will be automatically merged when approved and CI succeeds label Jan 21, 2022
@elena-zh
Copy link

Hey @alfetopito , to clarify: Will we disable 'Review' button when:

  1. claim for owner's account, and claim amount = 0
  2. token is not approved

Validation for claiming on behalf + when claim amount exceeds an investment amount works fine to me.

Covered in #2250

@mergify mergify bot merged commit 26e7540 into develop Jan 21, 2022
@alfetopito alfetopito deleted the disable-claim-review-on-errors branch January 21, 2022 18:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Auto-merge PRs with this tag will be automatically merged when approved and CI succeeds
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants