This repository has been archived by the owner on Jun 24, 2022. It is now read-only.
Disable claim review on zero or not approved #2250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nenadV91
changed the base branch from
develop
to
disable-claim-review-on-errors
|
|
@nenadV91 , great job! |
|
@elena-zh Yep, I'm on it |
|
@nenadV91 , I'm not sure if it is related to the current PR or not, but I'm not show any validation messages until a token is approved |
alfetopito
force-pushed
the
disable-claim-review-on-errors
branch
from
c280566 to
5bbe2d5
Compare
alfetopito
reviewed
Jan 21, 2022
alfetopito
approved these changes
Jan 21, 2022
This was referenced Jan 21, 2022
|
Looks good to me 👍🏼 |
fairlighteth
approved these changes
Jan 22, 2022
anxolin
approved these changes
Jan 22, 2022
mergify bot
pushed a commit
that referenced
this pull request
Jan 22, 2022
# Summary Waterfalls onto #2250 Hide/show investment error msg when there are errors Also updated the msg to be more general.  Of course feel free to suggest something else # To Test 1. Try to claim something paid and make sure to fail the validation
|
LGTM! |
mergify bot
pushed a commit
that referenced
this pull request
Jan 24, 2022
# Summary Waterfalls into #2250 Show warning/error when using too much native currency to invest Uses current gas estimation for 1 approval. Might need to adjust that for a higher amount If it's a Smart contract wallet, show a warning and let user proceed. If it's an EOA wallet, show an error and block from moving forward until amount is corrected. ## Smart contract:  ## EOA:  # To Test 1. With and EOA, load one account that has a ETH investment option 2. Fund the account with not enough ETH to cover the full investment 3. On approvals page, select to invest max * You'll see the error as you are using everything in your wallet 4. With a Smart contract wallet, load one account that has a ETH investment option 5. Fund the account with exactly the amount needed to cover the full investment (this step is only need if claiming on behalf of an EOA. If you have a Safe with claims do the same as step `2`) * On approvals page, you should see the warning and be able to move forward # Background **Note:** Color is of course dumb and doesn't quite work on light more. Neither does the error color for that matter. Counting on @biocom to make it look good
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adding on top or @alfetopito PR #2241