This repository has been archived by the owner on Jun 24, 2022. It is now read-only.
Claim invest general error msg #2254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Looks good. Wonder if we should summarize all the errors below. But probably overkill in the end 👍🏼 |
fairlighteth
approved these changes
Jan 22, 2022
anxolin
approved these changes
Jan 22, 2022
I had the same thought. But there's also value in keeping the message short. And the other errors are self explanatory |
Base automatically changed from
disable-claim-review-on-zero-or-not-approved
to
develop
January 22, 2022 18:06
alfetopito
force-pushed
the
claim-invest-general-error-msg
branch
from
e491742 to
777afa6
Compare
alfetopito
added
the
Auto-merge
|
LGTM! |
maria-vslvn
pushed a commit
that referenced
this pull request
Jan 25, 2022
Adds a en-space to StyledPollingNumber so it is always painted. Fixes a layout shift when rendering the first block number. StyledPollingNumber is taller than its container, so waiting to paint it causes a layout shift when rendering.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Waterfalls onto #2250
Hide/show investment error msg when there are errors
Also updated the msg to be more general.
Of course feel free to suggest something else
To Test