Pr2256/follow up #2279
Pr2256/follow up #2279
Conversation
Split claimCallback in 3: - claimCallback - does the same as before - estimateGasCallback - exposed externally to estimate gas usage based on claim input - getClaimInput - internal callback to prepare claimMany call args
|
There was a problem hiding this comment.
It works great, and I will merge to consolidate and do the RC.
The UX is pretty nice! I like is a bit conservative, i manage to test it in the limit where i got the warning but did the TX anyways.
However, I think it wouldn't harm to break down a bit the claim hook into subhooks. I feel it is too big (as a good to have).
I feel there's too many not small auxiliary function defined there that can just be hooks or pure functions receiving their dependencies?
| } | ||
| if (!vCowToken) { | ||
| throw new Error('vCOW token not present') | ||
| } |
There was a problem hiding this comment.
Aren't this checks replicated in getClaimArgs?
There was a problem hiding this comment.
Yes but if not checked TS complains
|
Others, pls review post-merge |
|
Works for me! @alfetopito , @biocom , WDYT? |
|
@elena-zh Agreed. Will handle. |
@anxolin You mean the claim hooks file or the useClaimCallback hook? |
|
I was meaning Anyways, don't worry if this is not needed right now and the refactor is costly. We can always break it if we need to reuse parts of it or if we need to touch there again. |
Summary
Follow up to #2256
fastgas prices for safetyExample warning message
What you'll see if you ignore the message
To Test
Same steps as PR #2256