Show warning when invested amount is not maximum available amount #2288
Conversation
|
|
Hey @nenadV91 , great changes! Video: https://watch.screencastify.com/v/26mQjbcnGBVjHkz3raJt Also, as I mentioned in #2279 (comment) , it would be nice to change warning's color for the light mode, I think. |
|
|
||
| const ErrorMsgs = { | ||
| const Messages = { |
There was a problem hiding this comment.
why change the name here, they are more declarative as ErrorMessage no?
There was a problem hiding this comment.
Because its also warnings and not just errors at this point. What do you think?
I don't think such a tiny amount (less than 0.01%) is relevant. I vote for leaving as is.
That will come, @biocom will get there 🤞 |
There was a problem hiding this comment.
Nice! all good other than what Leandro mentioned.
make a list of warnings
I would go for that one. For the errors, with one we have enough I believe. But Warnings we should see all the warnings at the same time.
Maybe @annamsgeorge or @avsavsavs want to touch that message. It's used for warning the users when they only make use of part of their claiming opportunity.
|
@anxolin Updated to an array of warnings |
|
@nenadV91 Pushed a fix for the style.ts merge conflict, in case it helps. |
|
Hey, now I see not readable warning messages in the dark mode: |
|
@elena-zh Good catch, my mistake, fixed! Maybe later on @michelbio can also take a look at this. |
|
Can review post merge to address it then. |
| @@ -368,7 +400,15 @@ export default function InvestOption({ claim, optionIndex, openModal, closeModal | |||
| </i> | |||
| {/* Insufficient balance validation error */} | |||
| {inputError && <small>{inputError}</small>} | |||
| {inputWarning && <small className="warn">{inputWarning}</small>} | |||
| {inputWarnings.length ? ( | |||
There was a problem hiding this comment.
Is not this the same as
{ inputWarnings.length && (... ) }
Summary
If the invested amount is not equal to maximum available amount we show yellow warning text below the input field