Skip to content
This repository has been archived by the owner on Jun 24, 2022. It is now read-only.

Improve header styles. #2346

Merged
merged 3 commits into from
Jan 28, 2022
Merged

Improve header styles. #2346

merged 3 commits into from
Jan 28, 2022

Conversation

fairlighteth
Copy link
Contributor

Summary

  • Improves the header for responsive viewports. Twitter icon disabled for now.
  • Fixes a UNI inherited style issue where header elements were reordered, causing no padding between vCOW button and other items.

Example below uses the longest worded chain and a large numeric balance, to account for worse case.

Screen.Recording.2022-01-28.at.10.56.50.mov

Note:

  • Aware that for a certain viewport size the SWAP PROFILE menu items get overlapped. Leaving that for what it is now.

@fairlighteth fairlighteth requested review from a team January 28, 2022 10:45
@github-actions
Copy link
Contributor

  • 🔭 GP Swap: CoW Protocol v2 Swap UI

@elena-zh
Copy link

Hey @biocom , something weird is happening: I do not see the changes on your video on my PR. Look:

  1. 'Connect to a wallet' button is clued to the vCOW button in a tablet view
    image
    The same is when connected:
    image

image

Could you please check what is wrong here?

@fairlighteth
Copy link
Contributor Author

@elena-zh Thank you for reviewing. Looks like I forgot to add that change! Now pushed a fix for it.

Copy link
Contributor

@anxolin anxolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the breaking point be earlier?
with the vcow balance theres a bit of overlap

image

@fairlighteth
Copy link
Contributor Author

@anxolin Yes agreed. Now pushed a fix to start earlier (for medium) by just showing the CowSwap icon.
Screen Shot 2022-01-28 at 16 55 58

@elena-zh
Copy link

elena-zh commented Jan 28, 2022

hey @biocom , great!
But I still can overlap by the network switcher the 'Profile' link on a certain screen resolution [960-1030] px:
image

But it is reported in #2148, case 2, so might be addressed later

@fairlighteth
Copy link
Contributor Author

@elena-zh Yes, that's the item mentioned in "Notes" which I will not address in this PR.

@fairlighteth fairlighteth merged commit 30ea2ec into develop Jan 28, 2022
@alfetopito alfetopito deleted the header-style-improvement-2 branch January 28, 2022 17:58
@fairlighteth
Copy link
Contributor Author

Addressed the pending item in #2376

ramirotw pushed a commit that referenced this pull request Feb 18, 2022
* chore: remove @types/lodash.flatmap

* fix: shim array-flat
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants