This repository has been archived by the owner on Jun 24, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @biocom , something weird is happening: I do not see the changes on your video on my PR. Look:
Could you please check what is wrong here? |
@elena-zh Thank you for reviewing. Looks like I forgot to add that change! Now pushed a fix for it. |
anxolin
reviewed
Jan 28, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@anxolin Yes agreed. Now pushed a fix to start earlier (for medium) by just showing the CowSwap icon. |
elena-zh
approved these changes
Jan 28, 2022
@elena-zh Yes, that's the item mentioned in "Notes" which I will not address in this PR. |
Addressed the pending item in #2376 |
ramirotw
pushed a commit
that referenced
this pull request
Feb 18, 2022
* chore: remove @types/lodash.flatmap * fix: shim array-flat
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Example below uses the longest worded chain and a large numeric balance, to account for worse case.
Screen.Recording.2022-01-28.at.10.56.50.mov
Note: