Skip to content
This repository has been archived by the owner on Jun 24, 2022. It is now read-only.

Improve responsiveness of header elements. #2376

Merged
merged 3 commits into from
Feb 4, 2022

Conversation

fairlighteth
Copy link
Contributor

Summary

  • This PR tries to solve for some items in [1.10] Mobile: issues with the header buttons #2148
  • The way it does that, is to enforce a max balance size, for both the vCOW and the network token balance (ETH, xDAI, etc.). It will use text ellipsis when the element is > 100px width on tablet/medium resolutions.
  • This fix will not resolve it 100% but will do so in more scenarios. In the example below I used an extreme scenario (long network name, large vCOW balance, large xDAI balance). As you see, for a very short moment only it is still overlapping.
Screen.Recording.2022-02-02.at.14.37.00.mov

Todo

  • Ways to improve: On medium/small resolutions, we could show abbreviated / shorter network names. Specifically Gnosis Chain -> GC.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 2, 2022

  • 🔭 GP Swap: CoW Protocol v2 Swap UI

@elena-zh
Copy link

elena-zh commented Feb 2, 2022

Hey @biocom , great job!
I noticed that in a certain screen width(960-1280 px) 'Profile' and 'Swap actions disappear from the header and do not appear in the menu
image
Could you please take a look at this issue?

@elena-zh
Copy link

elena-zh commented Feb 2, 2022

Also, in this PR I see 'cropped' vCOW balance in the menu in iOS and Android devices
image

Compare it with Stage:
image

Copy link
Contributor

@alfetopito alfetopito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No comments on my side. You might want to consider Elena's

@github-actions
Copy link
Contributor

github-actions bot commented Feb 4, 2022

CLA Assistant Lite All Contributors have signed the CLA.

@fairlighteth
Copy link
Contributor Author

@elena-zh Addressed the comments:
Screen Shot 2022-02-04 at 11 29 49
Screen Shot 2022-02-04 at 11 29 32

@elena-zh
Copy link

elena-zh commented Feb 4, 2022

Hey @biocom , thank you!
The 1st issue is fixed.
regarding to the 2nd one, a full amount is visible now, but it would be great to make it center-aligned. WDYT?
image

@fairlighteth
Copy link
Contributor Author

@elena-zh I forgot to reset the 'max-width'. Which caused this issue. Should be fixed now.

Copy link

@elena-zh elena-zh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now.
Thanks!

@fairlighteth fairlighteth merged commit ee0101a into develop Feb 4, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Feb 4, 2022
@alfetopito alfetopito deleted the header-responsive-improve branch February 4, 2022 16:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants