This repository has been archived by the owner on Jun 24, 2022. It is now read-only.
[CoW Subsidy] Base PR #2549
Merged
[CoW Subsidy] Base PR #2549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems that the build has failed. |
|
alfetopito
reviewed
Mar 16, 2022
alfetopito
approved these changes
Mar 16, 2022
* revert !account test check * add cow subsidy modal type to state * add component to swapmod * use AutoRow
This was referenced Mar 17, 2022
anxolin
approved these changes
Mar 17, 2022
src/custom/constants/subsidy.ts
Outdated
| ['100000', 35], | ||
| ] | ||
|
|
||
| export const SUBSIDY_INFO_MESSAGE = 'As a (v)COW token holder you will be eligbible for a fee discount.' |
There was a problem hiding this comment.
Same as this, this is content. Shouldn't be in a constant imo. I know, u want to refactor some repetition. I don't think a bit of repetition in content is that bad, and if its in a constant should be in a constant in the component, not a global one
* create discount utl fn & tests * move constants to file closer to subsidy code * minor changes to SubsidyTable * fix broken path * PR comments - ease up logic and data * [CoW Subsidy] - Highlight current subsidy relative to CoW balance and show correct discount on SwapMod (#2558) * add selected tier styling to table * change return of util * pass tier (mock) to modal * more serious hook impl. * change type to subsidy and use hook * fix test * use atom units for better math - simpler for..of loop - format table units down * better tests and fix logic * type change and minor logic lean * fix test tier with lt change * lt inclusive in loop
W3stside
commented
Mar 18, 2022
This was referenced Mar 22, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Part of
CoW Subsidy modal!
TODO (upcoming PRs)