Skip to content
This repository has been archived by the owner on Jun 24, 2022. It is now read-only.

[CoW Subsidy] - connect real hook to other stuff #2574

Merged
merged 2 commits into from
Mar 23, 2022

Conversation

W3stside
Copy link
Contributor

@W3stside W3stside commented Mar 22, 2022

Summary

Connects @nenadV91 's work on the vCoW total balance to the subsidy stuff
Part of #2549

What's missing:

  • actually change fee discount in the fee shown

@W3stside W3stside requested review from a team March 22, 2022 18:01
@W3stside W3stside added the RELEASE Included in the release that is being closed label Mar 22, 2022
@github-actions
Copy link
Contributor

  • 🔭 GP Swap: CoW Protocol v2 Swap UI

Copy link
Contributor

@alfetopito alfetopito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to be working fine
Screen Shot 2022-03-22 at 15 46 18

Although can't really tell the discount when looking at gchain
Screen Shot 2022-03-22 at 15 53 05

@elena-zh
Copy link

Hey @W3stside , I can see that the subsidy amount is changes according to the available balance in the wallet, however, I'm concerned that it does not affect a trade: there is not discounts in the tooltips for trades. Will it be implemented?
image.png

Co-authored-by: Leandro Boscariol <[email protected]>
@W3stside
Copy link
Contributor Author

Hey @W3stside , I can see that the subsidy amount is changes according to the available balance in the wallet, however, I'm concerned that it does not affect a trade: there is not discounts in the tooltips for trades. Will it be implemented? image.png

not yet! next PR

@W3stside
Copy link
Contributor Author

actually i take this abck there's nothing for FE to do the rest is handled in the backend, they handle the fee subsidisation

@W3stside W3stside merged commit fde86c4 into release/1.12.0 Mar 23, 2022
@W3stside W3stside deleted the cow-subsidy-use-real-hook branch March 23, 2022 15:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
RELEASE Included in the release that is being closed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants