Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why GenerateCurlCommand with debug #928

Closed
eatmeatball opened this issue Dec 12, 2024 · 4 comments
Closed

Why GenerateCurlCommand with debug #928

eatmeatball opened this issue Dec 12, 2024 · 4 comments
Assignees

Comments

@eatmeatball
Copy link

I require the GenerateCurlCommand function to log information, but I do not wish to include any debug-related output. Previously, I had written a function named restyResult2curl, but in the newer version, I discovered the GenerateCurlCommand. However, recently, GenerateCurlCommand underwent changes. Specifically, the EnableTrace() method is no longer available, and setting the debug level results in excessive output.
😠😠😠😠😠😠😠😠😠😠😠😠😠😠😠😠😠😠😠😠😠😠😠😠😠

@jeevatkm
Copy link
Member

@eatmeatball Thanks for reaching out.

That change happened as part of this: #828. Typically, the trace feature is used in production to capture metrics. Plus, users enable debugging with consideration for lower environments, reducing the risk to lower environments around secret leaks.

Let me know if you have any thoughts about redesigning the options. If it's feasible, I will consider it for the upcoming release, v3.

@jeevatkm
Copy link
Member

@eatmeatball I'm awaiting your feedback.

@jeevatkm
Copy link
Member

@eatmeatball I thought about it. I already did two changes in the minor version. So I will make generate curl cmd option independent in the upcoming v3 as a behavior change.

@jeevatkm
Copy link
Member

jeevatkm commented Jan 1, 2025

Done.

@jeevatkm jeevatkm closed this as completed Jan 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants