feat(enhancement)!: seperate generate curl cmd from debug flow #928 #934
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## v3 #934 +/- ##
=======================================
Coverage 99.81% 99.81%
=======================================
Files 17 17
Lines 3781 3788 +7
=======================================
+ Hits 3774 3781 +7
Misses 5 5
Partials 2 2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| // - curl body is not generated for [io.Reader] and multipart request flow. | ||
| // | ||
| // It can be overridden at the request level; see [Request.SetGenerateCurlCmd] | ||
| func (c *Client) SetGenerateCurlCmd(b bool) *Client { |
There was a problem hiding this comment.
This one shouldn't be exported.
Otherwise, you had no reason to add Enable and Disable one,no?
Or maybe I'm missing something
There was a problem hiding this comment.
I kept two kinds of usage variation: Resty users choose one approach based on their need/preference. You may see this in nature methods for frequently used ones, e.g. Debug, Trace, curl, and retry default conditions.
fixes #928