Skip to content
This repository has been archived by the owner on Feb 24, 2024. It is now read-only.

added Godoc documentation for tokenauth middleware #1060

Merged
merged 3 commits into from
Jun 23, 2018

Conversation

Shivakishore14
Copy link
Contributor

resolves #1056

@robbyoconnor
Copy link
Contributor

I have concerns about this library. I would prefer we used either this one or this one, the latter actually implemented more than just JWT.

@robbyoconnor
Copy link
Contributor

I'm actually using the latter in my app and rolling my own middleware.

@Shivakishore14
Copy link
Contributor Author

@markbates this is a documentation only PR. can you review this and merge, I think this will be helpful for others till robbyoconnor rolls out his version of middleware.

@markbates markbates merged commit f6f761b into gobuffalo:development Jun 23, 2018
@markbates markbates added this to the v0.12.3 milestone Jun 23, 2018
@markbates
Copy link
Member

Thanks!

@Shivakishore14 Shivakishore14 deleted the development branch June 23, 2018 19:20
@Shivakishore14 Shivakishore14 restored the development branch June 23, 2018 19:20
markbates added a commit that referenced this pull request Jul 15, 2018
* Migrate server.go logger to the app one instead of logrus (#1107)

* upgraded the default node-sass to work on node 10 (#1108)

* vgo

* Add txt for templates (#1117)

Had `text` now can do the same thing for `txt`

* keep toml simple

* remove whitespace in webpack.config.js (#1120)

* removed packr files rebase

* fix contrib guide list (#1129)

* Make the --config flag of *buffalo new* command use the config file (#1119)

* Make the --config flag of *buffalo new* command use the config file

* Remove dead code

* Add --skip-config flag and error if can't use the file passed to --config

* Add example to README

* added godoc documentation for tokenauth usage (#1060)

* Adding "BUFFALO_PLUGIN_TIMEOUT" option. (#1104)

* Adding "BUFFALO_PLUGIN_TIMEOUT" option.

Doing so lets users configure how long buffalo will wait while trying to
load a plugin. In particular, this is helping on my box where security
policies are setup in a manner that frequently has plugins taking 1.5
seconds to load.

Fixes #1103

* Refactoring to be more idiomatic/testable.

Also adding a test.

* Updating documenation

* Fixing typo

* Formatting test file.

* Taking advantage of testify

* Improving error message

* fixes a regress bootstrap version (#1143)

* Replace assets map Mutex with a RWMutex (#1146)

Once the assets map is loaded, it shouldn't change often. So, soften the read
access makes sense (and won't block rendering).

* automatically respond with a 404 if error is sql.ErrNoRows
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants