This repository has been archived by the owner on Feb 24, 2024. It is now read-only.
Replace assets map Mutex with a RWMutex #1146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Once the assets map is loaded, it shouldn't change often. So, soften the read access makes sense (and won't block rendering).
Codecov Report
@@ Coverage Diff @@
## development #1146 +/- ##
===============================================
- Coverage 50.68% 50.67% -0.02%
===============================================
Files 74 74
Lines 3796 3795 -1
===============================================
- Hits 1924 1923 -1
Misses 1755 1755
Partials 117 117
Continue to review full report at Codecov.
|
markbates
approved these changes
Jun 28, 2018
markbates
pushed a commit
that referenced
this pull request
Jul 4, 2018
Once the assets map is loaded, it shouldn't change often. So, soften the read access makes sense (and won't block rendering).
markbates
added a commit
that referenced
this pull request
Jul 15, 2018
* Migrate server.go logger to the app one instead of logrus (#1107) * upgraded the default node-sass to work on node 10 (#1108) * vgo * Add txt for templates (#1117) Had `text` now can do the same thing for `txt` * keep toml simple * remove whitespace in webpack.config.js (#1120) * removed packr files rebase * fix contrib guide list (#1129) * Make the --config flag of *buffalo new* command use the config file (#1119) * Make the --config flag of *buffalo new* command use the config file * Remove dead code * Add --skip-config flag and error if can't use the file passed to --config * Add example to README * added godoc documentation for tokenauth usage (#1060) * Adding "BUFFALO_PLUGIN_TIMEOUT" option. (#1104) * Adding "BUFFALO_PLUGIN_TIMEOUT" option. Doing so lets users configure how long buffalo will wait while trying to load a plugin. In particular, this is helping on my box where security policies are setup in a manner that frequently has plugins taking 1.5 seconds to load. Fixes #1103 * Refactoring to be more idiomatic/testable. Also adding a test. * Updating documenation * Fixing typo * Formatting test file. * Taking advantage of testify * Improving error message * fixes a regress bootstrap version (#1143) * Replace assets map Mutex with a RWMutex (#1146) Once the assets map is loaded, it shouldn't change often. So, soften the read access makes sense (and won't block rendering). * automatically respond with a 404 if error is sql.ErrNoRows
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Once the assets map is loaded, it shouldn't change often. So, soften the read
access makes sense (and won't block rendering).