Skip to content
This repository has been archived by the owner on Feb 24, 2024. It is now read-only.

Move basic workflow integration test from Dockerfile to go #1247

Closed
wants to merge 13 commits into from

Conversation

stanislas-m
Copy link
Member

@stanislas-m stanislas-m commented Aug 24, 2018

Make sure we don't break anything before merging #1252

* Handle the flags for build in a way allowing the tests to work.
* Fix a typo in build cmd log output.
@stanislas-m stanislas-m force-pushed the task/integration-test-basic-workflow branch from 99c9cec to 6990813 Compare August 24, 2018 05:46
@codecov
Copy link

codecov bot commented Aug 24, 2018

Codecov Report

Merging #1247 into development will increase coverage by 0.35%.
The diff coverage is 46.96%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #1247      +/-   ##
===============================================
+ Coverage        53.91%   54.26%   +0.35%     
===============================================
  Files               75       75              
  Lines             3437     3490      +53     
===============================================
+ Hits              1853     1894      +41     
+ Misses            1486     1482       -4     
- Partials            98      114      +16
Impacted Files Coverage Δ
buffalo/cmd/build.go 55.55% <46.96%> (+18.59%) ⬆️
buffalo/cmd/root.go 56% <0%> (+12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update caeb5a5...2dc90bd. Read the comment docs.

@codecov
Copy link

codecov bot commented Aug 27, 2018

Codecov Report

Merging #1247 into development will increase coverage by 0.41%.
The diff coverage is 46.96%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #1247      +/-   ##
===============================================
+ Coverage        53.85%   54.26%   +0.41%     
===============================================
  Files               75       75              
  Lines             3452     3490      +38     
===============================================
+ Hits              1859     1894      +35     
+ Misses            1492     1482      -10     
- Partials           101      114      +13
Impacted Files Coverage Δ
buffalo/cmd/build.go 55.55% <46.96%> (+18.59%) ⬆️
generators/newapp/new.go 0% <0%> (ø) ⬆️
errors.go 76.08% <0%> (+0.01%) ⬆️
meta/app.go 48.35% <0%> (+3.19%) ⬆️
app.go 100% <0%> (+7.69%) ⬆️
buffalo/cmd/root.go 56% <0%> (+12%) ⬆️
route_info.go 79.31% <0%> (+16.81%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 65f37bc...7c1daef. Read the comment docs.

@codecov
Copy link

codecov bot commented Aug 27, 2018

Codecov Report

Merging #1247 into development will increase coverage by 0.27%.
The diff coverage is 38.75%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #1247      +/-   ##
===============================================
+ Coverage        53.83%   54.11%   +0.27%     
===============================================
  Files               75       75              
  Lines             3453     3511      +58     
===============================================
+ Hits              1859     1900      +41     
- Misses            1493     1494       +1     
- Partials           101      117      +16
Impacted Files Coverage Δ
generators/resource/resource.go 0% <0%> (ø) ⬆️
buffalo/cmd/build.go 55.55% <46.96%> (+18.59%) ⬆️
buffalo/cmd/root.go 56% <0%> (+12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 73468e3...e08dd29. Read the comment docs.

@stanislas-m stanislas-m changed the title [WIP] Move basic workflow integration test from Dockerfile to go Move basic workflow integration test from Dockerfile to go Aug 29, 2018
@stanislas-m stanislas-m requested a review from a team August 29, 2018 09:41
@stanislas-m stanislas-m deleted the task/integration-test-basic-workflow branch October 23, 2018 13:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants