Skip to content
This repository has been archived by the owner on Feb 24, 2024. It is now read-only.

this pushes the adding of pop/soda commands to buffalo to the buffalo-pop #1252

Merged
merged 28 commits into from
Sep 4, 2018

Conversation

markbates
Copy link
Member

@markbates markbates commented Aug 24, 2018

@markbates markbates requested a review from a team August 24, 2018 19:16
@markbates markbates added this to the v0.13.0 milestone Aug 24, 2018
@codecov
Copy link

codecov bot commented Aug 24, 2018

Codecov Report

❗ No coverage uploaded for pull request base (development@84e8fab). Click here to learn what that means.
The diff coverage is 7.31%.

Impacted file tree graph

@@              Coverage Diff               @@
##             development    #1252   +/-   ##
==============================================
  Coverage               ?   53.62%           
==============================================
  Files                  ?       74           
  Lines                  ?     3424           
  Branches               ?        0           
==============================================
  Hits                   ?     1836           
  Misses                 ?     1490           
  Partials               ?       98
Impacted Files Coverage Δ
generators/newapp/new.go 0% <0%> (ø)
buffalo/cmd/setup.go 4.57% <0%> (ø)
buffalo/cmd/new.go 61.87% <100%> (ø)
meta/app.go 45.16% <14.28%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 84e8fab...740af74. Read the comment docs.

@codecov
Copy link

codecov bot commented Aug 26, 2018

Codecov Report

Merging #1252 into development will decrease coverage by 0.29%.
The diff coverage is 27.58%.

Impacted file tree graph

@@              Coverage Diff               @@
##           development    #1252     +/-   ##
==============================================
- Coverage        53.87%   53.58%   -0.3%     
==============================================
  Files               75       74      -1     
  Lines             3456     3445     -11     
==============================================
- Hits              1862     1846     -16     
- Misses            1493     1499      +6     
+ Partials           101      100      -1
Impacted Files Coverage Δ
route_mappings.go 96.75% <ø> (ø)
buffalo/cmd/setup.go 4.57% <0%> (-0.13%) ⬇️
render/sse.go 0% <0%> (ø) ⬆️
generators/newapp/new.go 0% <0%> (ø) ⬆️
buffalo/cmd/new.go 61.87% <100%> (+1.58%) ⬆️
buffalo/cmd/destroy.go 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d91dd0...ded8b3a. Read the comment docs.

@markbates markbates merged commit a6f3b69 into development Sep 4, 2018
@markbates markbates deleted the move-soda-commands branch September 4, 2018 13:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants