This repository has been archived by the owner on Feb 24, 2024. It is now read-only.
Moving Plugins into Core #1670
Merged
Moving Plugins into Core #1670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
reviewed
May 20, 2019
There was a problem hiding this comment.
Found some fixes!
P.S. share your ideas, feedbacks or issues with us at https://github.com/fixmie/feedback (this message will be removed after the beta stage).
|
All tests pass locally... its not the cleanest move, but it's a start... |
ghost
reviewed
May 27, 2019
There was a problem hiding this comment.
Found some fixes!
P.S. share your ideas, feedbacks or issues with us at https://github.com/fixmie/feedback (this message will be removed after the beta stage).
Co-Authored-By: fixmie[bot] <fixmie[bot]@users.noreply.github.com>
markbates
previously approved these changes
Jun 9, 2019
Co-Authored-By: fixmie[bot] <fixmie[bot]@users.noreply.github.com>
…ffalo/buffalo into better_messaging_wo_plugins
markbates
added a commit
that referenced
this pull request
Jun 14, 2019
* Back to development * Fix FUNDING.yml syntax errors (#1688) * don't need to run go get for mods when building (#1691) * Moving Plugins into Core (#1670) * Decrease docker image size (#1694) * Decrease docker image size rm commands need to be in the same layer as that adds whatever gets cached or is unneeded. This is because docker layers are append only. Signed-off-by: Todd Brown <[email protected]> * Add mkdir back in to dockerfile Signed-off-by: Todd Brown <[email protected]> * bump mods and fixes release 1.6.2 * attrs and clara * bump
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving plugins plugin into the core.