This repository has been archived by the owner on Feb 24, 2024. It is now read-only.
Decrease docker image size #1694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rm commands need to be in the same layer as that adds whatever gets cached or is unneeded. This is because docker layers are append only. Signed-off-by: Todd Brown <[email protected]>
|
If I’m reading this correctly you’re deleting all the go source we just downloaded. We do that for a few reasons. Can you explain what this accomplishes? |
mrbrownt
commented
Jun 13, 2019
markbates
approved these changes
Jun 13, 2019
mrbrownt
commented
Jun 13, 2019
Signed-off-by: Todd Brown <[email protected]>
|
Thanks! |
markbates
added a commit
that referenced
this pull request
Jun 13, 2019
This reverts commit c74db77.
markbates
added a commit
that referenced
this pull request
Jun 13, 2019
markbates
pushed a commit
that referenced
this pull request
Jun 13, 2019
* Decrease docker image size rm commands need to be in the same layer as that adds whatever gets cached or is unneeded. This is because docker layers are append only. Signed-off-by: Todd Brown <[email protected]> * Add mkdir back in to dockerfile Signed-off-by: Todd Brown <[email protected]>
markbates
added a commit
that referenced
this pull request
Jun 14, 2019
* Back to development * Fix FUNDING.yml syntax errors (#1688) * don't need to run go get for mods when building (#1691) * Moving Plugins into Core (#1670) * Decrease docker image size (#1694) * Decrease docker image size rm commands need to be in the same layer as that adds whatever gets cached or is unneeded. This is because docker layers are append only. Signed-off-by: Todd Brown <[email protected]> * Add mkdir back in to dockerfile Signed-off-by: Todd Brown <[email protected]> * bump mods and fixes release 1.6.2 * attrs and clara * bump
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rm commands need to be in the same layer as that adds whatever gets cached or is unneeded. This is because docker layers are append only.