Skip to content
This repository has been archived by the owner on Feb 24, 2024. It is now read-only.

v0.16.0 #1924

Merged
merged 12 commits into from
Apr 2, 2020
Merged

v0.16.0 #1924

merged 12 commits into from
Apr 2, 2020

Conversation

markbates
Copy link
Member

No description provided.

markbates and others added 8 commits January 23, 2020 10:11
@markbates
merge changes from buffalo-cli into main repo
f0fdd55
@drnic
cache deps before building and copying source (#1884)
c36a985 
cache deps before building and copying source so that we don't need to re-download as much
and so that source changes don't invalidate our downloaded layer
@markbates
Generator resource action test breaks with unused imports fixes #1893 (…
64d477e 
…#1894)

* Generator resource action test breaks with unused imports fixes #1893

* break packr cache

* fix broken test
@markbates
update deps (#1896)
56a56e0 
* update deps

* update envy

* update meta
@hdm
switch to tags/v3 for consistency (#1901)
b21df66
@markbates
update helpers/tags
d0d04f8
@markbates
update validate
87c1bbb
@markbates
try to fix mismatched imports (#1921)
ef737c7
@markbates markbates requested a review from a team as a code owner March 18, 2020 16:17
@markbates markbates added this to the v0.15.6 milestone Mar 18, 2020
@paganotoni
Copy link
Member

Thanks for putting this one together Mark!. The only issue I foresee is that new app tests will not work as gobuffalo/suite still not supports pop/v5

@markbates
Copy link
Member Author

@paganotoni do you have a fix/patch or something?

@paganotoni
Copy link
Member

There is a branch that changes to use /v5 but is not blackguard compatible.

@paganotoni
Copy link
Member

@markbates https://github.com/gobuffalo/suite/tree/pop-v5

@paganotoni
Copy link
Member

@markbates gobuffalo/suite#36 gobuffalo/suite/v3 uses pop v5.

paganotoni
paganotoni reviewed Mar 21, 2020
View reviewed changes
buffalo/cmd/fix/fix.go Outdated Show resolved Hide resolved
@markbates markbates removed this from the v0.15.6 milestone Mar 24, 2020
@markbates markbates changed the title v0.15.6 v0.16.0 Mar 24, 2020
@paganotoni
Copy link
Member

@markbates it seems like we need to change

buffalo/genny/build/templates/a/aa.go.plush

Line 7 in 76d7d48

"github.com/gobuffalo/pop"
. Right ?

@paganotoni
Copy link
Member

Nevermind. It seems you updated that one already :)

@paganotoni
Copy link
Member

Only thing I noticed is that if we make fix change source to use uuid/v3, then we should update validate to use it as well.
I created this PR to update Validate to use uuid/v3 : gobuffalo/validate#20

@paganotoni paganotoni self-requested a review April 1, 2020 15:23
@paganotoni
Copy link
Member

gobuffalo/validate#20 merged @markbates @gobuffalo/all

@markbates markbates merged commit 1da9a76 into master Apr 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@paganotoni paganotoni paganotoni approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@markbates @paganotoni @drnic @hdm @stanislas-m