Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Task v3 + pop v5 + mods + github actions #36

Merged
merged 9 commits into from
Mar 23, 2020
Merged

Task v3 + pop v5 + mods + github actions #36

merged 9 commits into from
Mar 23, 2020

Conversation

paganotoni
Copy link
Member

No description provided.

@paganotoni paganotoni requested a review from markbates March 21, 2020 17:23
@paganotoni paganotoni requested a review from a team March 21, 2020 17:55
@paganotoni paganotoni mentioned this pull request Mar 21, 2020
Merged
mclark4386
mclark4386 approved these changes Mar 22, 2020
View reviewed changes
Copy link
Member

@mclark4386 mclark4386 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but would like someone with more experience in the internals to look at it before merging^^;

@paganotoni
Copy link
Member Author

Thanks @mclark4386! Maybe @stanislas-m or @markbates can take a look. I know @stanislas-m worked on the fixture implementation.

@stanislas-m
Copy link
Member

The code seems OK, but I want to test it a bit before giving the approval.
Also we need to complete the comments, // JSON ...-like comments are not OK. :)

@paganotoni
Copy link
Member Author

Great. I'll go for those comments soon. Thanks @stanislas-m

markbates
markbates reviewed Mar 23, 2020
View reviewed changes
Copy link
Member

@markbates markbates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a few packages, like plush/v4 and uuid/v3 that we should be using, but I don't know how that will impact existing apps.

go.mod Outdated Show resolved Hide resolved
go.mod Outdated Show resolved Hide resolved
@paganotoni
Copy link
Member Author

@markbates @stanislas-m added comments and updated dependencies.

@paganotoni paganotoni merged commit 6b92115 into master Mar 23, 2020
@paganotoni paganotoni deleted the task-v3-mods branch March 23, 2020 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markbates markbates markbates left review comments

@mclark4386 mclark4386 mclark4386 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@paganotoni @stanislas-m @markbates @mclark4386