Skip to content
This repository has been archived by the owner on Feb 24, 2024. It is now read-only.

v0.16.20 #2077

Merged
merged 57 commits into from
Jan 8, 2021
Merged
Changes from 1 commit
Commits
Show all changes
57 commits
Select commit Hold shift + click to select a range
834c095
adding direct version on the docker build
paganotoni Apr 21, 2020
dea73d0
merging
paganotoni Apr 21, 2020
ef66b75
fixing plugin installation
paganotoni Apr 21, 2020
f54ca9e
Merge branch 'master' of https://github.com/gobuffalo/buffalo
paganotoni May 8, 2020
1c74ae6
Merge branch 'master' of https://github.com/gobuffalo/buffalo
paganotoni May 25, 2020
7827df3
Fix npm's package.json permissions (#2005)
disconnect3d Jun 9, 2020
9da3740
Bump spf13/viper to v1.7.0 (#1999)
aeneasr Jun 9, 2020
be95bfe
Merge branch 'master' into development
paganotoni Jun 9, 2020
4aa9475
bunping version
paganotoni Jun 9, 2020
9e9d5bf
changing version on dockerfile
paganotoni Jun 9, 2020
e9d8c0a
patch to fix the keywords check on new app
paganotoni Jul 15, 2020
b6ec6e4
Merge branch 'master' of https://github.com/gobuffalo/buffalo into de…
paganotoni Jul 15, 2020
7fc13fb
removing unneeded append
paganotoni Jul 15, 2020
d86adbc
Task fixing html binder (#2016)
paganotoni Jul 16, 2020
e5ff685
adding new version number
paganotoni Jul 16, 2020
af37208
Merge branch 'master' of https://github.com/gobuffalo/buffalo
paganotoni Jul 16, 2020
947543c
Merge branch 'master' into development
paganotoni Jul 16, 2020
4362a83
pulling the buffalo binary from gobinaries.com
paganotoni Jul 18, 2020
2150f08
Merge branch 'master' of https://github.com/gobuffalo/buffalo into de…
paganotoni Jul 18, 2020
7e6b165
Merge branch 'master' of https://github.com/gobuffalo/buffalo
paganotoni Jul 29, 2020
f52bbc2
Merge branch 'master' into development
paganotoni Jul 29, 2020
b0f043a
Task updating formam (#2025)
paganotoni Jul 29, 2020
b30b49a
Merge branch 'development' of https://github.com/gobuffalo/buffalo in…
paganotoni Jul 29, 2020
2a6f20b
Fixes #1987 and #2023 (#2026)
paganotoni Aug 2, 2020
5eeaa2a
Merge branch 'development' of https://github.com/gobuffalo/buffalo in…
paganotoni Aug 2, 2020
4643bad
changing version number
paganotoni Aug 2, 2020
39711ae
moving to latest 2 go versions (#2038)
paganotoni Sep 4, 2020
e44a95d
Task binding cleanup (#2039)
paganotoni Sep 4, 2020
859e828
Task update formam (#2041)
paganotoni Sep 5, 2020
ec9ca99
updating flect versionm (#2042)
paganotoni Sep 5, 2020
0c5aed0
updating version
paganotoni Sep 5, 2020
a7388dd
Merge branch 'master' of https://github.com/gobuffalo/buffalo
paganotoni Sep 5, 2020
85b1a29
Merge branch 'master' into development
paganotoni Sep 5, 2020
9b38d89
updating some libraries to pass the github security warnings (#2044)
paganotoni Sep 7, 2020
871e148
Merge branch 'master' of https://github.com/gobuffalo/buffalo into de…
paganotoni Sep 7, 2020
c16a020
Merge branch 'development' of https://github.com/gobuffalo/buffalo in…
paganotoni Sep 7, 2020
5476b1d
Removing Grifts folder (#2050)
paganotoni Sep 18, 2020
70f4aaf
fixes the non-existing .git folder case (#2053)
paganotoni Oct 7, 2020
1a80253
calling persist explicitly (#2054)
paganotoni Oct 16, 2020
c554801
adding version number
paganotoni Oct 22, 2020
09a510d
Merge branch 'master' of https://github.com/gobuffalo/buffalo
paganotoni Oct 22, 2020
a0aeebd
Merge branch 'master' into development
paganotoni Oct 22, 2020
f88da17
Pointing README to new go docs link
paganotoni Nov 11, 2020
9cf5ca7
Merge branch 'master' into development
paganotoni Nov 11, 2020
45acf7a
running packr2
paganotoni Nov 11, 2020
4357a75
Warns if response is attempted to be written twice (#2059)
paganotoni Dec 19, 2020
122e3e3
allows to specify custom partialfeeders
paganotoni Dec 24, 2020
5791db9
Merge branch 'master' into development
paganotoni Dec 24, 2020
e34adae
cleaning up a bit for codeclimate
paganotoni Dec 24, 2020
bfd7379
changing the version
paganotoni Dec 24, 2020
ad697d0
Merge branch 'development' of https://github.com/gobuffalo/buffalo in…
paganotoni Dec 24, 2020
00f6388
Application Route Namer (#2075)
paganotoni Jan 7, 2021
0381b3a
v0.16.19
paganotoni Jan 7, 2021
99daaa5
adding correct version number
paganotoni Jan 7, 2021
cceaf61
fixing groups routenamer issue
paganotoni Jan 8, 2021
46eabb9
Merge branch 'master' of https://github.com/gobuffalo/buffalo into de…
paganotoni Jan 8, 2021
cb7e629
version change
paganotoni Jan 8, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Warns if response is attempted to be written twice (#2059)
* v0.16.16 (#2055)

* adding direct version on the docker build

* fixing plugin installation

* Fix npm's package.json permissions (#2005)

Changed created file permissions from 644 (`-w----r--`) to 0644 (`rw-r--r--`)

* Bump spf13/viper to v1.7.0 (#1999)

* bunping version

* changing version on dockerfile

* patch to fix the keywords check on new app

* removing unneeded append

* Task fixing html binder (#2016)

* binder was not wired

* packing

* adding new version number

* pulling the buffalo binary from gobinaries.com

* Task updating formam (#2025)

* v0.16.13 (#2019)

* adding direct version on the docker build

* fixing plugin installation

* Fix npm's package.json permissions (#2005)

Changed created file permissions from 644 (`-w----r--`) to 0644 (`rw-r--r--`)

* Bump spf13/viper to v1.7.0 (#1999)

* bunping version

* changing version on dockerfile

* patch to fix the keywords check on new app

* removing unneeded append

* Task fixing html binder (#2016)

* binder was not wired

* packing

* adding new version number

* pulling the buffalo binary from gobinaries.com

Co-authored-by: Disconnect3d <dominik.b.czarnota@gmail.com>
Co-authored-by: hackerman <3372410+aeneasr@users.noreply.github.com>

* updating formam

Co-authored-by: Disconnect3d <dominik.b.czarnota@gmail.com>
Co-authored-by: hackerman <3372410+aeneasr@users.noreply.github.com>

* Fixes #1987 and #2023 (#2026)

* v0.16.13 (#2019)

* adding direct version on the docker build

* fixing plugin installation

* Fix npm's package.json permissions (#2005)

Changed created file permissions from 644 (`-w----r--`) to 0644 (`rw-r--r--`)

* Bump spf13/viper to v1.7.0 (#1999)

* bunping version

* changing version on dockerfile

* patch to fix the keywords check on new app

* removing unneeded append

* Task fixing html binder (#2016)

* binder was not wired

* packing

* adding new version number

* pulling the buffalo binary from gobinaries.com

Co-authored-by: Disconnect3d <dominik.b.czarnota@gmail.com>
Co-authored-by: hackerman <3372410+aeneasr@users.noreply.github.com>

* fixing #1987 and #2023

* adding missing converstion

* removing commented code

Co-authored-by: Disconnect3d <dominik.b.czarnota@gmail.com>
Co-authored-by: hackerman <3372410+aeneasr@users.noreply.github.com>

* changing version number

* moving to latest 2 go versions (#2038)

* Task binding cleanup (#2039)

* moving to latest 2 go versions

* cleaning up the decoder on the binding package

* Task update formam (#2041)

* v0.16.14 (#2030)

* adding direct version on the docker build

* fixing plugin installation

* Fix npm's package.json permissions (#2005)

Changed created file permissions from 644 (`-w----r--`) to 0644 (`rw-r--r--`)

* Bump spf13/viper to v1.7.0 (#1999)

* bunping version

* changing version on dockerfile

* patch to fix the keywords check on new app

* removing unneeded append

* Task fixing html binder (#2016)

* binder was not wired

* packing

* adding new version number

* pulling the buffalo binary from gobinaries.com

* Task updating formam (#2025)

* v0.16.13 (#2019)

* adding direct version on the docker build

* fixing plugin installation

* Fix npm's package.json permissions (#2005)

Changed created file permissions from 644 (`-w----r--`) to 0644 (`rw-r--r--`)

* Bump spf13/viper to v1.7.0 (#1999)

* bunping version

* changing version on dockerfile

* patch to fix the keywords check on new app

* removing unneeded append

* Task fixing html binder (#2016)

* binder was not wired

* packing

* adding new version number

* pulling the buffalo binary from gobinaries.com

Co-authored-by: Disconnect3d <dominik.b.czarnota@gmail.com>
Co-authored-by: hackerman <3372410+aeneasr@users.noreply.github.com>

* updating formam

Co-authored-by: Disconnect3d <dominik.b.czarnota@gmail.com>
Co-authored-by: hackerman <3372410+aeneasr@users.noreply.github.com>

* Fixes #1987 and #2023 (#2026)

* v0.16.13 (#2019)

* adding direct version on the docker build

* fixing plugin installation

* Fix npm's package.json permissions (#2005)

Changed created file permissions from 644 (`-w----r--`) to 0644 (`rw-r--r--`)

* Bump spf13/viper to v1.7.0 (#1999)

* bunping version

* changing version on dockerfile

* patch to fix the keywords check on new app

* removing unneeded append

* Task fixing html binder (#2016)

* binder was not wired

* packing

* adding new version number

* pulling the buffalo binary from gobinaries.com

Co-authored-by: Disconnect3d <dominik.b.czarnota@gmail.com>
Co-authored-by: hackerman <3372410+aeneasr@users.noreply.github.com>

* fixing #1987 and #2023

* adding missing converstion

* removing commented code

Co-authored-by: Disconnect3d <dominik.b.czarnota@gmail.com>
Co-authored-by: hackerman <3372410+aeneasr@users.noreply.github.com>

* changing version number

Co-authored-by: Disconnect3d <dominik.b.czarnota@gmail.com>
Co-authored-by: hackerman <3372410+aeneasr@users.noreply.github.com>

* updates formam version #2040

Co-authored-by: Disconnect3d <dominik.b.czarnota@gmail.com>
Co-authored-by: hackerman <3372410+aeneasr@users.noreply.github.com>

* updating flect versionm (#2042)

* updating version

* updating some libraries to pass the github security warnings (#2044)

* Removing Grifts folder (#2050)

* removing the grifts folder

* removing grifts folder from codeclimate exceptions

* fixes the non-existing .git folder case (#2053)

* calling persist explicitly (#2054)

* adding version number

Co-authored-by: Disconnect3d <dominik.b.czarnota@gmail.com>
Co-authored-by: hackerman <3372410+aeneasr@users.noreply.github.com>

* only writing the header if it has not been written

* bumping version

* adding packr2 files

Co-authored-by: Disconnect3d <dominik.b.czarnota@gmail.com>
Co-authored-by: hackerman <3372410+aeneasr@users.noreply.github.com>
  • Loading branch information
3 people authored Dec 19, 2020
commit 4357a7569c995b2d5c01d79dfc493b37cedcdd4c
15 changes: 12 additions & 3 deletions response.go
Original file line number Diff line number Diff line change
@@ -18,9 +18,18 @@ type Response struct {
}

// WriteHeader sets the status code for a response
func (w *Response) WriteHeader(i int) {
w.Status = i
w.ResponseWriter.WriteHeader(i)
func (w *Response) WriteHeader(code int) {
if code == w.Status {
return
}

if w.Status > 0 {
fmt.Printf("[WARNING] Headers were already written. Wanted to override status code %d with %d", w.Status, code)
return
}

w.Status = code
w.ResponseWriter.WriteHeader(code)
}

// Write the body of the response
22 changes: 22 additions & 0 deletions response_test.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
package buffalo

import (
"net/http"
"net/http/httptest"
"testing"

"github.com/stretchr/testify/require"
)

func Test_Response_MultipleWrite(t *testing.T) {
r := require.New(t)
resWr := httptest.NewRecorder()
res := Response{
ResponseWriter: resWr,
}

res.WriteHeader(http.StatusOK)
res.WriteHeader(http.StatusInternalServerError)

r.Equal(res.Status, http.StatusOK)
}
2 changes: 1 addition & 1 deletion runtime/version.go
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
package runtime

// Version is the current version of the buffalo binary
var Version = "v0.16.16"
var Version = "v0.16.17"