Merge pull request #133 from Mido-sys/fix_if_condition_with_map_array…

…_index Fix if condition with map array index
gobuffalo · Apr 15, 2021 · ab79cdf · ab79cdf
2 parents e5e4fe3 + fe719ee
commit ab79cdf
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 0 deletions.
diff --git a/ast/index_expression.go b/ast/index_expression.go
@@ -11,6 +11,8 @@ type IndexExpression struct {
 	Value Expression
 }
 
+func (ie *IndexExpression) validIfCondition() bool { return true }
+
 func (ie *IndexExpression) expressionNode() {}
 
 func (ie *IndexExpression) String() string {

diff --git a/parser/parser_test.go b/parser/parser_test.go
@@ -397,6 +397,15 @@ func Test_IfExpression_PrefixExpressions_InvalidCompar(t *testing.T) {
 
 	r.Error(err, "syntax error: invalid if condition, got x = 1")
 }
+func Test_IfExpression_With_Map_Array_Index(t *testing.T) {
+	r := require.New(t)
+	input := `<% if (flash["error"] ) { x } %>`
+
+	_, err := Parse(input)
+
+	r.NoError(err)
+}
+
 func Test_IfExpression_InfixExpressions_InvalidCompare(t *testing.T) {
 	r := require.New(t)
 	input := `<% if ( y == 1 && x = 1) { x } %>`