Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

if evaluation could be improved some more to make it efficient #165

Closed
sio4 opened this issue Oct 1, 2022 · 0 comments · Fixed by #166 or #168
Closed

if evaluation could be improved some more to make it efficient #165

sio4 opened this issue Oct 1, 2022 · 0 comments · Fixed by #166 or #168
Assignees
@sio4
Labels
enhancement New feature or request s: fixed was fixed or solution offered
Milestone
v4.1.16

Comments

@sio4
Copy link
Member

sio4 commented Oct 1, 2022

Regarding #157 and #164, it seems like the if evaluation code could be improved some more to reduce unnecessary evaluations. Especially, it could be better if OR condition stops further evaluation when the left part is already true, also AND condition stops further evaluation when the left part is already false.
@sio4 sio4 added the enhancement New feature or request label Oct 1, 2022
@sio4 sio4 added this to the v4.1.16 milestone Oct 1, 2022
@sio4 sio4 self-assigned this Oct 1, 2022
@sio4 sio4 mentioned this issue Oct 1, 2022
Merged
@sio4 sio4 added bug Something isn't working and removed bug Something isn't working labels Oct 1, 2022
@sio4 sio4 closed this as completed in #166 Oct 2, 2022
@sio4 sio4 added the s: fixed was fixed or solution offered label Oct 2, 2022
@sio4 sio4 mentioned this issue Oct 4, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sio4 sio4

Labels
enhancement New feature or request s: fixed was fixed or solution offered
Projects
None yet
Milestone
v4.1.16
1 participant
@sio4