Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed #164's bug by focusing on the operator instead of the value #166

Merged
merged 2 commits into from
Oct 2, 2022

Conversation

sio4
Copy link
Member

@sio4 sio4 commented Oct 1, 2022

I found that #164's approach is problematic because the fix is focused on the value and it modifies the value itself (from nil to false when if the error is kind of "unknown identifier"). However, since the method is not only for logical operations, the fix made side effects on the evaluation of arithmetic operators and handling nil itself.

This PR has two commits:

  • added more test cases
  • fixed the method to focus on the operation

fixes #157
fixes #165

@sio4 sio4 added the bug Something isn't working label Oct 1, 2022
@sio4 sio4 added this to the v4.1.16 milestone Oct 1, 2022
@sio4 sio4 requested a review from a team October 1, 2022 14:04
@sio4 sio4 self-assigned this Oct 1, 2022
@sio4 sio4 added the enhancement New feature or request label Oct 1, 2022
@sio4 sio4 merged commit fe01052 into main Oct 2, 2022
@sio4 sio4 deleted the fix-157-164 branch October 2, 2022 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
1 participant