fixed #164's bug by focusing on the operator instead of the value #166
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found that #164's approach is problematic because the fix is focused on the value and it modifies the value itself (from
nil
tofalse
when if the error is kind of "unknown identifier"). However, since the method is not only for logical operations, the fix made side effects on the evaluation of arithmetic operators and handlingnil
itself.This PR has two commits:
fixes #157
fixes #165