Fix if condition if one of the nodes is undefined while the operator is Or and the other node is true #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…is Or and the other the node evaluates to true
|
@sio4, just a kind reminder :) |
Sorry for that. I couldn't make a time today. Will check as soon as possible! |
|
@sio4, no worries!! Thanks, the Timezone difference makes it hard :) |
sio4
added a commit
that referenced
this pull request
Oct 1, 2022
sio4
added a commit
that referenced
this pull request
Oct 1, 2022
|
Hi @Mido-sys, FYI, I found some issues (side effects) on this PR while I review the method to improve the efficiency, and filed a PR (#166) to fix the issue. The main difference between those two approaches is that yours is more focused on the value, but mine is focused on the operations. Just wanted to let you know about the change! |
sio4
added a commit
that referenced
this pull request
Oct 2, 2022
sio4
added a commit
that referenced
this pull request
Oct 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for issue #157