Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expand variadic args in contextStore #517

Merged
merged 1 commit into from
Feb 11, 2020
Merged

Expand variadic args in contextStore #517

merged 1 commit into from
Feb 11, 2020

Conversation

aeneasr
Copy link
Member

@aeneasr aeneasr commented Feb 11, 2020

See #497

@aeneasr aeneasr requested a review from a team as a code owner February 11, 2020 13:40
@aeneasr
Copy link
Member Author

aeneasr commented Feb 11, 2020

Don't really have time to add tests at the moment but I think this is an obvious oversight. IMO all test should run with and without context to ensure they're working properly.

@stanislas-m stanislas-m merged commit c7edcfb into gobuffalo:master Feb 11, 2020
@stanislas-m
Copy link
Member

Thanks!

@aeneasr
Copy link
Member Author

aeneasr commented Feb 11, 2020

Any time :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stanislas-m stanislas-m stanislas-m approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aeneasr @stanislas-m