Add context.Context #497
Merged
Add context.Context #497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Using this patch, and |
aeneasr
added a commit
to aeneasr/pop
that referenced
this pull request
Feb 11, 2020
|
Found the culprit: #497 |
stanislas-m
pushed a commit
that referenced
this pull request
Feb 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The implementation may work, but I haven't been able to test it and won't for some time. It does compile and existing tests still work (last I checked before merging development in).
If someone would like to verify this works, this could get merged in.
Additionally it would probably be beneficial to add this to the middleware in Buffalo to append the context on the tx in the context.
This PR is a rebased version of #472.