feat: expose connection transactions with context and options #719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sio4
requested changes
May 20, 2022
zepatrik
force-pushed
the
feat/expose-tx-opts
branch
from
ce05da9 to
9b946de
Compare
zepatrik
commented
May 23, 2022
| r.Equal(nctx, tx.Context()) | ||
|
|
||
| r.NoError(tx.TX.Rollback()) | ||
| }) |
There was a problem hiding this comment.
There is no test for NewTransactionContextOptions because that one is quite hard to test in general (we just pass down the options), and sqlite neither supports readOnly transactions, nor any other isolation level than serializable.
aeneasr
approved these changes
May 24, 2022
|
I think this change is well aligned with #497 and #594, and it seems like we already moved to use context for all transactions which is a good thing, even though it could be (mostly useless) I think this change is reasonable. What do you think @paganotoni ? |
sio4
approved these changes
May 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently one can only use
conn.Store.TransactionContextOptions()which means one does not get a connection that is part of the transaction.