-
Notifications
You must be signed in to change notification settings - Fork 511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
On 2022-04-05, the default branch will be renamed from "master" to "main" #539
Comments
Really slick to do this after work hours, but some of us have offshore devops engineers who are all asleep. Now we can't run builds. |
Thank you for the feedback @bc185168. We're trying to be as non-invasive as possible. If we did this during "Atlanta" time, it would be the middle of the night for Europe and Asia. There's never a convenient time 😦. |
moved main to v0 according to google-github-actions/setup-gcloud#539
While I understand the reasons behind the naming changes I don't think breaking builds is the right call. Improving GitHub Actions to get it to properly follow the redirect or making copy of the @v0 branch called "master" would have avoided builds breaking all over the world and people scrambling to fix them. Breaking changes should only be made in the event of a critical security issue as they can have severe consequences on business. |
What an unprofessional way of breaking everyone's integration. |
Our entire product codebase and build pipeline is now broken. Personally I was fine with this whole mumbles about |
* Pin github actions to v0 rather than master See issue; google-github-actions/setup-gcloud#539 * Update pr.yml Rollback pipeline runner version to master Co-authored-by: Jorge Sanchez Perez <[email protected]>
Honestly you just broke all my pipelines and i have to change them all manually now, great!
Yes because everyone read absolutely all the logs mostly of the things that works fine since the start right? For next time:
|
If a job will fail, it should fail on 2022-04-05, not 2022-03-21 |
It's hard to think of another social justice cause that had so much effort for such little impact. |
And the worst thing in this is: Black Community, which is considered 'offended' in such cases, doesn't give a single damn how github (or whatever) calls the main/master/most_important/root branch. Yet another time white people decided for Blacks what they "want". Sad. |
I wasn't aware you were a spokesperson for the entire black community. I must have missed your anointment. |
I wasn't aware |
guys this is not about |
|
@Alexandru-Dobre thank you for the suggestion. We have raised this issue with GitHub and the GitHub Actions team. They believe the current implementation is working as intended. Please keep in mind that we are not the GitHub Actions team and we have no control over how GitHub Actions behaves or resolves references. Leaving a dangling
@savvaki - Thank you for the feedback. If you have alternative ideas, we're always open to exploring other options. Our team has been debating this change for many months. Our original attempt of renaming the branch in December broke with unintuitive and confusing error messages. The goal here is to provide a helpful and actionable error message for users.
@andoshin11 - Sorry 😦. We've tried very hard to message this over the past 3 months, emitting warning messages. Please also note that it appears GitHub Actions also appears to be having issues, which is unrelated to our change. If you are seeing general build failures, it might be due to the GitHub issue.
@erwanriou - Sorry about that. We've tried very hard to message this over the past 3 months, emitting warning messages. We did check how many pipelines we would break, and I personally submitted over 100 PRs to the top repositories. However, we can only check public repositories. We have no way of emailing maintainers. Please keep in mind that we are not the GitHub Actions team - we merely publish a GitHub Action for interacting with Google Cloud. If we had the information you suggested, we definitely would have used it. As far as updating
@bc185168 - If we just renamed the branch on 2022-04-05, we would be replaying the December rename attempt.
@erwanriou - Could you please share more information? In our testing and in reviewing the code, you should only get this error if you're using Please try to keep conversation civil. Comments not in line with Google's Code of Conduct are not tolerated. |
Well, main is less "inclusive" and precise than master.
If we want to use the default, we just leave it out. Why recommend |
I wonder if I need to change my MS diploma from Master of Science to Main of Science to be more inclusive? |
With google-github-actions/setup-gcloud#539, they broke Github workflows specifying the "master" branch ahead of the rename of the branch to 'main'.
I think along the way we've forgotten that backwards support for public services is imperative. Tooling like this must follow the browser update ethics which state that all previous features must be supported indefinitely, for better or worse. This isn't some internal company tool, it's one that is integrated into many others with no proper way for you to contact them. Knowing that circumstance the master branch should have been locked at its current version and kept as archived after switching to a main branch, with warnings of depreciation left in the logs. Breaking every single integrator's CI should never have been the way to go, or even an option. |
I wonder how many of you would have actually seen this change in the date 2022-04-05 and fix before messing your CIs 😅 Of course this was not expected, and I do understand all the points of view as well the complaints. Doesn't mean that I actually agree, this issue is actually starting to being toxic and should be locked by now. (Of course I'm a nobody, so my opinions shouldn't mean a s*** for you). If you believe that this project is not any more reliable to put in your CIs, just fork it and make one that you trust :) That's the beauty of OSS. |
With google-github-actions/setup-gcloud#539, they broke Github workflows specifying the "master" branch ahead of the rename of the branch to 'main'.
deploy-to-terra action throws an [error](https://github.com/DataBiosphere/terra-example-notebooks/actions/runs/2054166993): ``` On 2022-04-05, the default branch will be renamed from "master" to "main". Your action is currently pinned to "@master". Even though GitHub creates redirects for renamed branches, testing found that this rename breaks existing GitHub Actions workflows that are pinned to the old branch name. We strongly advise updating your GitHub Action YAML from: uses: 'google-github-actions/setup-gcloud@master' to: uses: 'google-github-actions/setup-gcloud@v0' While not recommended, you can still pin to the "master" branch by setting the environment variable "SETUP_GCLOUD_I_UNDERSTAND_USING_MASTER_WILL_BREAK_MY_WORKFLOW_ON_2022_04_05=1". However, on 2022-04-05 when the branch is renamed, all your workflows will begin failing with an obtuse and difficult to diagnose error message. For more information, please see: google-github-actions/setup-gcloud#539 ``` This is tracked by a GitHub [issue](google-github-actions/setup-gcloud#539)
deploy-to-terra action throws an [error](https://github.com/DataBiosphere/terra-example-notebooks/actions/runs/2054166993): ``` On 2022-04-05, the default branch will be renamed from "master" to "main". Your action is currently pinned to "@master". Even though GitHub creates redirects for renamed branches, testing found that this rename breaks existing GitHub Actions workflows that are pinned to the old branch name. We strongly advise updating your GitHub Action YAML from: uses: 'google-github-actions/setup-gcloud@master' to: uses: 'google-github-actions/setup-gcloud@v0' While not recommended, you can still pin to the "master" branch by setting the environment variable "SETUP_GCLOUD_I_UNDERSTAND_USING_MASTER_WILL_BREAK_MY_WORKFLOW_ON_2022_04_05=1". However, on 2022-04-05 when the branch is renamed, all your workflows will begin failing with an obtuse and difficult to diagnose error message. For more information, please see: google-github-actions/setup-gcloud#539 ``` This is tracked by a GitHub [issue](google-github-actions/setup-gcloud#539)
github changed from master to main for setup-gcloud. See google-github-actions/setup-gcloud#539
github changed from master to main for setup-gcloud. See google-github-actions/setup-gcloud#539
With google-github-actions/setup-gcloud#539, they broke Github workflows specifying the "master" branch ahead of the rename of the branch to 'main'.
Adjust it because upstream made it, For more information, please see: google-github-actions/setup-gcloud#539 Signed-off-by: Yang Jiao <[email protected]>
Well for me this issue can be closed and locked, could you do this @sethvargo ? @therealbluepandabear Well, in my honest opinion, here is not the best place to discuss this. Of course, I do agree with you, if only, the virtual branch was the only action towards a more “inclusivity” of minor groups. People love to complain on changes, I know changes are hard we don't like it, still ignore that there are a lot of bias against minorities can be really harmful (just read this entire issue, it's cesspool). F*** we are humans, can't we take measures to help others? How hard can this be? The world is already so unfair, let's try to at least balance a little? Maybe this is the time to question on what do you believe, not only for your privileges, but how can you actually help with small steps. I don't like to talk about this in public, but I took, as a personal quest/mission/goal, to help women enter the “software development world” and I believe I've been successful. |
@Xunjin thank you, and done. |
This error message means your GitHub Action is currently pinned to
@master
. As noted in the error, you can update your action to pin to@v0
instead. You can also pin to a specific Git SHA or tag.On April 4th, 2022, we will rename the default branch from "master" to "main". While GitHub will properly configure redirects, our previous testing found that GitHub Actions does not respect this redirect. Instead of leaving users with a confusing error message, we've added this explicit error message.
FAQ
Why is this change necessary?
In order to be as inclusive as possible, all the default branches for our GitHub Actions repositories are named
main
. Thesetup-gcloud
action predates this change. Having some repos usemaster
and some usemain
is confusing for users, so we are standardizing onmain
moving forward.Couldn't you have issued a warning instead of throwing an error?
We have been printing a warning message since December 29.
Should I pin to
@v0
?We recommend pinning to the latest major version. This will ensure you get all new features and bug fixes while minimizing the chances of a breaking change. At this time, the latest major version is
v0
. If you are concerned about breaking changes or security, you should pin to a specific Git SHA instead.The text was updated successfully, but these errors were encountered: