-
Notifications
You must be signed in to change notification settings - Fork 511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: throw a very specific error when pinned to master #537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sethvargo
commented
Mar 20, 2022
bharathkkb
approved these changes
Mar 21, 2022
`While not recommended, you can still pin to the "master" branch ` + | ||
`by setting the environment variable "${envvar}=1". However, on ` + | ||
`2022-04-05 when the branch is renamed, all your workflows will ` + | ||
`begin failing with an obtuse and difficult to diagnose error ` + |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets also open a pinned issue before rename with the error before we rename so users know what to do.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sethvargo
force-pushed
the
sethvargo/here_we_go
branch
from
March 21, 2022 22:22
6e69183
to
144ee37
Compare
This can be overridden by setting an environment variable.
sethvargo
force-pushed
the
sethvargo/here_we_go
branch
from
March 21, 2022 22:22
144ee37
to
c4b8d4f
Compare
Merged
kodiakhq bot
referenced
this pull request
in cloudquery/cloudquery
Jan 1, 2023
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [google-github-actions/setup-gcloud](https://togithub.com/google-github-actions/setup-gcloud) | action | patch | `v0.6.0` -> `v0.6.2` | | peter-evans/create-or-update-comment | action | digest | `5adcb0b` -> `69c3c2d` | | peter-evans/find-comment | action | digest | `f4499a7` -> `81e2da3` | --- ### Release Notes <details> <summary>google-github-actions/setup-gcloud</summary> ### [`v0.6.2`](https://togithub.com/google-github-actions/setup-gcloud/releases/tag/v0.6.2) [Compare Source](https://togithub.com/google-github-actions/setup-gcloud/compare/v0.6.1...v0.6.2) #### What's Changed - chore: update dependencies (automated) by [@​verbanicm](https://togithub.com/verbanicm) in [https://github.com/google-github-actions/setup-gcloud/pull/576](https://togithub.com/google-github-actions/setup-gcloud/pull/576) - Release: v0.6.2 by [@​google-github-actions-bot](https://togithub.com/google-github-actions-bot) in [https://github.com/google-github-actions/setup-gcloud/pull/577](https://togithub.com/google-github-actions/setup-gcloud/pull/577) **Full Changelog**: google-github-actions/setup-gcloud@v0.6.1...v0.6.2 ### [`v0.6.1`](https://togithub.com/google-github-actions/setup-gcloud/releases/tag/v0.6.1) [Compare Source](https://togithub.com/google-github-actions/setup-gcloud/compare/v0.6.0...v0.6.1) #### What's Changed - chore: update dependabot settings by [@​averikitsch](https://togithub.com/averikitsch) in [https://github.com/google-github-actions/setup-gcloud/pull/522](https://togithub.com/google-github-actions/setup-gcloud/pull/522) - chore: switch to writeSecureFile from actions-utils by [@​sethvargo](https://togithub.com/sethvargo) in [https://github.com/google-github-actions/setup-gcloud/pull/535](https://togithub.com/google-github-actions/setup-gcloud/pull/535) - feat: throw a very specific error when pinned to master by [@​sethvargo](https://togithub.com/sethvargo) in [https://github.com/google-github-actions/setup-gcloud/pull/537](https://togithub.com/google-github-actions/setup-gcloud/pull/537) - chore: build dist by [@​google-github-actions-bot](https://togithub.com/google-github-actions-bot) in [https://github.com/google-github-actions/setup-gcloud/pull/536](https://togithub.com/google-github-actions/setup-gcloud/pull/536) - chore: setFailed instead of throwing by [@​sethvargo](https://togithub.com/sethvargo) in [https://github.com/google-github-actions/setup-gcloud/pull/541](https://togithub.com/google-github-actions/setup-gcloud/pull/541) - Typo fix by [@​mwarkentin](https://togithub.com/mwarkentin) in [https://github.com/google-github-actions/setup-gcloud/pull/542](https://togithub.com/google-github-actions/setup-gcloud/pull/542) - fix: update references from master -> main by [@​sethvargo](https://togithub.com/sethvargo) in [https://github.com/google-github-actions/setup-gcloud/pull/544](https://togithub.com/google-github-actions/setup-gcloud/pull/544) - chore: update deps by [@​sethvargo](https://togithub.com/sethvargo) in [https://github.com/google-github-actions/setup-gcloud/pull/551](https://togithub.com/google-github-actions/setup-gcloud/pull/551) - update release process by [@​verbanicm](https://togithub.com/verbanicm) in [https://github.com/google-github-actions/setup-gcloud/pull/562](https://togithub.com/google-github-actions/setup-gcloud/pull/562) - $'fix release workflow files' by [@​verbanicm](https://togithub.com/verbanicm) in [https://github.com/google-github-actions/setup-gcloud/pull/563](https://togithub.com/google-github-actions/setup-gcloud/pull/563) - $'fix release workflow files' by [@​verbanicm](https://togithub.com/verbanicm) in [https://github.com/google-github-actions/setup-gcloud/pull/566](https://togithub.com/google-github-actions/setup-gcloud/pull/566) - fix: update secrets according to readme by [@​greenchapter](https://togithub.com/greenchapter) in [https://github.com/google-github-actions/setup-gcloud/pull/549](https://togithub.com/google-github-actions/setup-gcloud/pull/549) - chore: update deps by [@​sethvargo](https://togithub.com/sethvargo) in [https://github.com/google-github-actions/setup-gcloud/pull/567](https://togithub.com/google-github-actions/setup-gcloud/pull/567) - chore: fix typo by [@​Eejit43](https://togithub.com/Eejit43) in [https://github.com/google-github-actions/setup-gcloud/pull/568](https://togithub.com/google-github-actions/setup-gcloud/pull/568) - Delete CONTRIBUTING.md by [@​sethvargo](https://togithub.com/sethvargo) in [https://github.com/google-github-actions/setup-gcloud/pull/569](https://togithub.com/google-github-actions/setup-gcloud/pull/569) - chore(deps): bump [@​actions/core](https://togithub.com/actions/core) from 1.9.0 to 1.9.1 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/google-github-actions/setup-gcloud/pull/570](https://togithub.com/google-github-actions/setup-gcloud/pull/570) - chore(deps): bump [@​types/mocha](https://togithub.com/types/mocha) from 9.1.1 to 10.0.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/google-github-actions/setup-gcloud/pull/572](https://togithub.com/google-github-actions/setup-gcloud/pull/572) - Update deps by [@​sethvargo](https://togithub.com/sethvargo) in [https://github.com/google-github-actions/setup-gcloud/pull/574](https://togithub.com/google-github-actions/setup-gcloud/pull/574) - Release: v0.6.1 by [@​google-github-actions-bot](https://togithub.com/google-github-actions-bot) in [https://github.com/google-github-actions/setup-gcloud/pull/575](https://togithub.com/google-github-actions/setup-gcloud/pull/575) #### New Contributors - [@​mwarkentin](https://togithub.com/mwarkentin) made their first contribution in [https://github.com/google-github-actions/setup-gcloud/pull/542](https://togithub.com/google-github-actions/setup-gcloud/pull/542) - [@​verbanicm](https://togithub.com/verbanicm) made their first contribution in [https://github.com/google-github-actions/setup-gcloud/pull/562](https://togithub.com/google-github-actions/setup-gcloud/pull/562) - [@​greenchapter](https://togithub.com/greenchapter) made their first contribution in [https://github.com/google-github-actions/setup-gcloud/pull/549](https://togithub.com/google-github-actions/setup-gcloud/pull/549) - [@​Eejit43](https://togithub.com/Eejit43) made their first contribution in [https://github.com/google-github-actions/setup-gcloud/pull/568](https://togithub.com/google-github-actions/setup-gcloud/pull/568) **Full Changelog**: google-github-actions/setup-gcloud@v0.6.0...v0.6.1 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 3am on the first day of the month" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC40Mi4wIiwidXBkYXRlZEluVmVyIjoiMzQuNDIuMCJ9-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This can be overridden by setting an environment variable.