Fix #2 upload_results_to_perf_dashboard usage

Pass output_json_file name as an argument, instead of the open file. Bug: chromium:40807291 Change-Id: Ia0f52ff3b3a3551bcdcda235ebaa90ae217cea54 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5332432 Commit-Queue: Yuly Novikov <[email protected]> Reviewed-by: Brian Sheedy <[email protected]> Commit-Queue: Brian Sheedy <[email protected]> Auto-Submit: Yuly Novikov <[email protected]>
google · Feb 28, 2024 · 434a5b0 · 434a5b0
1 parent 057db6e
commit 434a5b0
Showing 1 changed file with 6 additions and 7 deletions.
diff --git a/scripts/process_angle_perf_results.py b/scripts/process_angle_perf_results.py
@@ -464,13 +464,12 @@ def _upload_individual(benchmark_name, directories, configuration_name, build_pr
         results_size_in_mib = os.path.getsize(results_filename) / (2**20)
         logging.info('Uploading perf results from %s benchmark (size %s Mib)' %
                      (benchmark_name, results_size_in_mib))
-        with open(output_json_file, 'w') as oj:
-            upload_return_code = _upload_perf_results(results_filename, benchmark_name,
-                                                      configuration_name, build_properties, oj)
-            upload_end_time = time.time()
-            print_duration(('%s upload time' % (benchmark_name)), upload_begin_time,
-                           upload_end_time)
-            return (benchmark_name, upload_return_code == 0)
+        upload_return_code = _upload_perf_results(results_filename, benchmark_name,
+                                                  configuration_name, build_properties,
+                                                  output_json_file)
+        upload_end_time = time.time()
+        print_duration(('%s upload time' % (benchmark_name)), upload_begin_time, upload_end_time)
+        return (benchmark_name, upload_return_code == 0)
     finally:
         shutil.rmtree(tmpfile_dir)