Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README.md #2

Closed
wants to merge 1 commit into from
Closed

Update README.md #2

wants to merge 1 commit into from

Conversation

selvamohandoss
Copy link

No description provided.

@vonture vonture closed this Dec 18, 2014
vvuk pushed a commit to vvuk/angle that referenced this pull request Jan 6, 2016
@emilio
Merge pull request google#2 from connorimes/check-native-build
cea8b79 
Only set target-specific CC and AR for cross-compile
hubot pushed a commit that referenced this pull request Nov 21, 2017
@null77
Revert "Make TType store a const char * for mangled name."
c796500 
This reverts commit dc7bffd.

Reason for revert: Causes a memory leak, detected by ASAN bot:

https://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/494713

Direct leak of 24 byte(s) in 1 object(s) allocated from:
    #0 0x847aa2 in operator new(unsigned long) /b/build/slave/linux_upload_clang/build/src/third_party/llvm/compiler-rt/lib/asan/asan_new_delete.cc:92:3
    #1 0x193a833 in sh::TType::buildMangledName() const third_party/angle/src/compiler/translator/Types.cpp:545:21
    #2 0x193d2e8 in getMangledName third_party/angle/src/compiler/translator/Types.cpp:751:24
    #3 0x193d2e8 in sh::TType::realize() third_party/angle/src/compiler/translator/Types.cpp:759
    #4 0x1834474 in sh::TCache::getType(sh::TBasicType, sh::TPrecision, sh::TQualifier, unsigned char, unsigned char) third_party/angle/src/compiler/translator/Cache.cpp:89:11
    #5 0x1859ac7 in getType third_party/angle/src/compiler/translator/Cache.h:36:16
    #6 0x1859ac7 in sh::InsertBuiltInFunctions(unsigned int, ShShaderSpec, ShBuiltInResources const&, sh::TSymbolTable&) third_party/angle/src/compiler/translator/Initialize.cpp:28

Bug: angleproject:1432

Original change's description:
> Make TType store a const char * for mangled name.
> 
> We would only ever use the c_str value from the mangled name. This
> makes it easier to make constexpr TTypes.
> 
> Bug: angleproject:1432
> Change-Id: I147b3a85f9b8b2453e2d7f4a713d767b22036cc9
> Reviewed-on: https://chromium-review.googlesource.com/776277
> Commit-Queue: Jamie Madill <[email protected]>
> Reviewed-by: Kai Ninomiya <[email protected]>

[email protected],[email protected]

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: angleproject:1432
Change-Id: Ib112a2ce9871a4f4afc53101ac1a3ddd166008cf
Reviewed-on: https://chromium-review.googlesource.com/780420
Reviewed-by: Jamie Madill <[email protected]>
wang-bin pushed a commit to wang-bin/angle that referenced this pull request Dec 22, 2018
@vonture
Expose EXT_color_buffer_half_float if RGBA16F is renderable.
4f2b94c 
The EXT_color_buffer_half_float extension spec issue google#2 states that none
of the added color buffer formats are required to be renderable and the
client must check for framebuffer completeness for using them.  Chrome
exposes the extension if at least RGBA16F is renderable for WebGL.

Replicate Chrome's behaviour by loosening our requirements to only
expose this extension if an explicit check for RGBA16F renderability
succeeds.

BUG=angleproject:2984

Change-Id: Id97f3043ebf3fd11b5e9e2d505e57b76baba9716
Reviewed-on: https://chromium-review.googlesource.com/c/1351350
Commit-Queue: Geoff Lang <[email protected]>
Reviewed-by: Yuly Novikov <[email protected]>
anydream pushed a commit to anydream/angle that referenced this pull request Jun 20, 2019
@kkinnunen
D3D: Add a wrapper to Image11 that enables ASAN/MSAN to catch the err…
a4c639c 
…ors on map operations

The wrapper should be a no-op on builds with assertions disabled.
The wrapper should be useful on ASAN and MSAN builds.

gn args out/release-asan --args="is_debug=false is_asan=true"
ninja -C out/release-asan angle_end2end_tests ^
 out\release-asan\angle_end2end_tests ^
 --gtest_filter=Texture2DArrayCopy.SnormFormats* --gtest_catch_exceptions=0 ^
 --gtest_repeat=-1

Output when the fix payload of angleproject:2865 is removed:

...

Repeating all tests (iteration 1) . . .

Note: Google Test filter = Texture2DArrayCopy.SnormFormats*
[==========] Running 1 test from 1 test suite.
[----------] Global test environment set-up.
[----------] 1 test from Texture2DArrayCopy
[ RUN      ] Texture2DArrayCopy.SnormFormats/ES3_D3D11
=================================================================
==500==ERROR: AddressSanitizer: heap-buffer-overflow on address 0x12b2c4777040 at pc 0x7fff9602216b bp 0x00c0eaafd090 sp 0x00c0eaafd0d8
READ of size 1 at 0x12b2c4777040 thread T0
    #0 0x7fff9602216a in angle::R8G8B8A8::readColor c:\Users\kkinnunen\angle\src\image_util\imageformats.cpp:333
    google#1 0x7fff9618dbf0 in rx::CopyImageCHROMIUM c:\Users\kkinnunen\angle\src\libANGLE\renderer\renderer_utils.cpp:377
    google#2 0x7fff96186bb2 in rx::Image11::CopyImage c:\Users\kkinnunen\angle\src\libANGLE\renderer\d3d\d3d11\Image11.cpp:113
    google#3 0x7fff95e90410 in rx::Renderer11::copyImage c:\Users\kkinnunen\angle\src\libANGLE\renderer\d3d\d3d11\Renderer11.cpp:3009
    google#4 0x7fff9617b447 in rx::TextureD3D_2DArray::copyTexture c:\Users\kkinnunen\angle\src\libANGLE\renderer\d3d\TextureD3D.cpp:3293
    google#5 0x7fff95afd7e1 in gl::Texture::copyTexture c:\Users\kkinnunen\angle\src\libANGLE\Texture.cpp:1196
    google#6 0x7fff95977f19 in gl::Context::copyTexture3D c:\Users\kkinnunen\angle\src\libANGLE\Context.cpp:4347
    google#7 0x7fff9568b04a in gl::CopyTexture3DANGLE c:\Users\kkinnunen\angle\src\libGLESv2\entry_points_gles_ext_autogen.cpp:57
    google#8 0x7ff7d1d8fc97 in angle::CopyTexture3DTest::testCopy c:\Users\kkinnunen\angle\src\tests\gl_tests\CopyTexture3DTest.cpp:90
    google#9 0x7ff7d1dadd10 in angle::Texture2DArrayCopy_SnormFormats_Test::TestBody c:\Users\kkinnunen\angle\src\tests\gl_tests\CopyTexture3DTest.cpp:1272
    google#10 0x7ff7d2c22891 in testing::Test::Run c:\Users\kkinnunen\angle\third_party\googletest\src\googletest\src\gtest.cc:2522
    google#11 0x7ff7d2c243c0 in testing::TestInfo::Run c:\Users\kkinnunen\angle\third_party\googletest\src\googletest\src\gtest.cc:2698
    google#12 0x7ff7d2c253e8 in testing::TestSuite::Run c:\Users\kkinnunen\angle\third_party\googletest\src\googletest\src\gtest.cc:2828
    google#13 0x7ff7d2c3f33e in testing::internal::UnitTestImpl::RunAllTests c:\Users\kkinnunen\angle\third_party\googletest\src\googletest\src\gtest.cc:5285
    google#14 0x7ff7d2c3e72d in testing::UnitTest::Run c:\Users\kkinnunen\angle\third_party\googletest\src\googletest\src\gtest.cc:4873
    google#15 0x7ff7d2bf10a2 in main c:\Users\kkinnunen\angle\src\tests\angle_end2end_tests_main.cpp:15
    google#16 0x7ff7d2d27897 in __scrt_common_main_seh f:\dd\vctools\crt\vcstartup\src\startup\exe_common.inl:283
    google#17 0x7ff801ec7973 in BaseThreadInitThunk+0x13 (C:\WINDOWS\System32\KERNEL32.DLL+0x180017973)
    google#18 0x7ff804cea270 in RtlUserThreadStart+0x20 (C:\WINDOWS\SYSTEM32\ntdll.dll+0x18006a270)

0x12b2c4777040 is located 0 bytes to the right of 256-byte region [0x12b2c4776f40,0x12b2c4777040)
allocated by thread T0 here:
    #0 0x7ff7d2c6d574 in malloc C:\b\s\w\ir\k\src\third_party\llvm\projects\compiler-rt\lib\asan\asan_malloc_win.cc:68
    google#1 0x7fff95af47b2 in angle::MemoryBuffer::resize c:\Users\kkinnunen\angle\src\common\MemoryBuffer.cpp:40
    google#2 0x7fff9648c9a6 in rx::MappedSubresourceVerifier11::wrap c:\Users\kkinnunen\angle\src\libANGLE\renderer\d3d\d3d11\MappedSubresourceVerifier11.cpp:51
    google#3 0x7fff961864b5 in rx::Image11::map c:\Users\kkinnunen\angle\src\libANGLE\renderer\d3d\d3d11\Image11.cpp:648
    google#4 0x7fff9618676c in rx::Image11::CopyImage c:\Users\kkinnunen\angle\src\libANGLE\renderer\d3d\d3d11\Image11.cpp:93
    google#5 0x7fff95e90410 in rx::Renderer11::copyImage c:\Users\kkinnunen\angle\src\libANGLE\renderer\d3d\d3d11\Renderer11.cpp:3009
    google#6 0x7fff9617b447 in rx::TextureD3D_2DArray::copyTexture c:\Users\kkinnunen\angle\src\libANGLE\renderer\d3d\TextureD3D.cpp:3293
    google#7 0x7fff95afd7e1 in gl::Texture::copyTexture c:\Users\kkinnunen\angle\src\libANGLE\Texture.cpp:1196
    google#8 0x7fff95977f19 in gl::Context::copyTexture3D c:\Users\kkinnunen\angle\src\libANGLE\Context.cpp:4347
    google#9 0x7fff9568b04a in gl::CopyTexture3DANGLE c:\Users\kkinnunen\angle\src\libGLESv2\entry_points_gles_ext_autogen.cpp:57
    google#10 0x7ff7d1d8fc97 in angle::CopyTexture3DTest::testCopy c:\Users\kkinnunen\angle\src\tests\gl_tests\CopyTexture3DTest.cpp:90
    google#11 0x7ff7d1dadd10 in angle::Texture2DArrayCopy_SnormFormats_Test::TestBody c:\Users\kkinnunen\angle\src\tests\gl_tests\CopyTexture3DTest.cpp:1272
    google#12 0x7ff7d2c22891 in testing::Test::Run c:\Users\kkinnunen\angle\third_party\googletest\src\googletest\src\gtest.cc:2522
    google#13 0x7ff7d2c243c0 in testing::TestInfo::Run c:\Users\kkinnunen\angle\third_party\googletest\src\googletest\src\gtest.cc:2698
    google#14 0x7ff7d2c253e8 in testing::TestSuite::Run c:\Users\kkinnunen\angle\third_party\googletest\src\googletest\src\gtest.cc:2828
    google#15 0x7ff7d2c3f33e in testing::internal::UnitTestImpl::RunAllTests c:\Users\kkinnunen\angle\third_party\googletest\src\googletest\src\gtest.cc:5285
    google#16 0x7ff7d2c3e72d in testing::UnitTest::Run c:\Users\kkinnunen\angle\third_party\googletest\src\googletest\src\gtest.cc:4873
    google#17 0x7ff7d2bf10a2 in main c:\Users\kkinnunen\angle\src\tests\angle_end2end_tests_main.cpp:15
    google#18 0x7ff7d2d27897 in __scrt_common_main_seh f:\dd\vctools\crt\vcstartup\src\startup\exe_common.inl:283
    google#19 0x7ff801ec7973 in BaseThreadInitThunk+0x13 (C:\WINDOWS\System32\KERNEL32.DLL+0x180017973)
    google#20 0x7ff804cea270 in RtlUserThreadStart+0x20 (C:\WINDOWS\SYSTEM32\ntdll.dll+0x18006a270)

Bug: angleproject:2865
Change-Id: I6c8fc203d075014ba8ce31c728982eed73812d04
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1640212
Commit-Queue: Kimmo Kinnunen FI <[email protected]>
Reviewed-by: Geoff Lang <[email protected]>
cnorthrop pushed a commit to cnorthrop/angle that referenced this pull request Aug 19, 2019
@riannucci
Rolling 11 dependencies
da8dad1 
Roll ./build/ 680f9ea3d..5262b9094 (10 commits)

https://chromium.googlesource.com/chromium/src/build.git/+log/680f9ea3db81..5262b9094642

$ git log 680f9ea3d..5262b9094 --date=short --no-merges --format='%ad %ae %s'
2019-08-08 chromium-autoroll Roll Fuchsia SDK from 890571594499 to 890568639186
2019-08-08 chromium-autoroll Roll Fuchsia SDK from 890574089166 to 890571594499
2019-08-08 chromium-autoroll Roll Fuchsia SDK from 890577289982 to 890574089166
2019-08-07 gogerald [StartSurface] Move the tab_ui strings to the feature module
2019-08-07 tiborg [build] Remove dont_load_shared_libraries GN parameter
2019-08-07 chromium-autoroll Roll Fuchsia SDK from 890579756157 to 890577289982
2019-08-07 chromium-autoroll Roll Fuchsia SDK from 890582331998 to 890579756157
2019-08-07 chromium-autoroll Roll Fuchsia SDK from 890585497544 to 890582331998
2019-08-07 yucliu [Fuchsia][EME] Correct CDM service name
2019-08-07 hmohit Add gn arg to overwrite rpath.

Roll ./buildtools/ d5c58b84d..74cfb5700 (19 commits; 3 trivial rolls)

https://chromium.googlesource.com/chromium/src/buildtools.git/+log/d5c58b84d50d..74cfb57006f8

$ git log d5c58b84d..74cfb5700 --date=short --no-merges --format='%ad %ae %s'
2019-07-25 thomasanderson List natvis files as inputs
2019-07-23 tikuta Roll GN from 972ed755 to 152c5144
2019-07-19 tsniatowski ensure_gn_version.py: don't die if existing gn is very old
2019-07-16 bratell Before trying to overwrite the gn binary, make it writable
2019-07-12 vapier ensure_gn_version.py: reinstall if tool is missing
2019-07-11 vapier ensure_gn_version.py: fix exception printing
2019-06-24 brettw Roll GN from 8c7f4910 to 972ed755
2019-06-21 thomasanderson Reland "Roll GN from 81ee1967 to 8c7f4910"
2019-06-17 sdy Revert "Roll GN from 81ee1967 to 8c7f4910"
2019-06-16 thomasanderson Roll GN from 81ee1967 to 8c7f4910
2019-06-14 mstensho Revert "Roll src/buildtools/third_party/libc++/trunk/ 5938e0582..ad464887b (53 commits)"
2019-06-13 mstensho Revert "Roll src/buildtools/third_party/libc++/trunk/ 5938e0582..78822a685 (48 commits)"
2019-06-07 oysteine Tracing: Moved the tracing sampling profiler to the tracing service
2019-05-23 wychen Exclude AndroidStudioDefault folder in Java import checking
2019-05-19 rsesek Roll GN from 64b846c9 to 81ee1967.
2019-05-13 jbudorick checkdeps: encode input to os.walk as utf-8.

Roll ./testing/ 32e614b7e..58990c945 (420 commits)

https://chromium.googlesource.com/chromium/src/testing/+log/32e614b7ec7b..58990c945ffa

$ git log 32e614b7e..58990c945 --date=short --no-merges --format='%ad %ae %s'
2019-07-01 [email protected] Update NavigationLoaderOnUI browser_tests filter again
2019-07-01 [email protected] [EoS] Update fieldtrial testing config
2019-07-01 [email protected] [Extensions] De-flake MultiActionAPITest.DynamicSetIcon
2019-07-01 [email protected] Add the "remote" arg for chromeos-kevin-perf-fyi
2019-07-01 [email protected] [code coverage] Merge Java coverage files to avoid duplicate names
2019-07-01 [email protected] Change revision passed to V8 GPU pixel tests
2019-07-01 [email protected] Add filter file for services_unittests on android-asan.
2019-07-01 [email protected] Fix WelcomeScreenBrowserTest keyboard selection
2019-07-01 [email protected] [testing/buildbot] switch to use xenial for some test
2019-06-29 [email protected] Make metadata an optional field that does not need to be the same for all shard's JSON results
2019-06-29 [email protected] Update NavigationLoaderOnUI browser_tests filter
2019-06-29 [email protected] luci: add android-asan back to consoles.
2019-06-28 [email protected] perf: run internal resource_sizes_* targets on both android builders.
2019-06-28 [email protected] Re-enable tests on Linux Experimental NVIDIA and Intel bots.
2019-06-28 [email protected] [perf] Add performance_test_suite for chromeos-kevin-perf-fyi tester
2019-06-28 [email protected] Use targeted OS version for GPU bots.
2019-06-28 [email protected] Enable PredictivePrefetchingAllowedOnAllConnectionTypes
2019-06-28 [email protected] Add android_browsertests to the set of all builds and run it on the bots
2019-06-28 [email protected] Disable reflection-on-composited test for Vulkan FYI
2019-06-28 [email protected] Revert "Reland google#2: "Trichrome Proguard: Fix locale pak selection.""
2019-06-28 [email protected] Add security interstititial dark mode experiment to field trial testing config
2019-06-28 [email protected] Make DataReductionProxyURLLoaderThrottle work on UI thread
2019-06-28 [email protected] Reduce the shard number to 4 for android-pixel2-perf-fyi tester
2019-06-28 [email protected] Add more flaky tests to SKV content_browsertests
2019-06-28 [email protected] Convert URLLoaderRequestInterceptors to work on UI thread
2019-06-27 [email protected] Fix for the fyi bot runs of BF Cache tests.
2019-06-27 [email protected] Fix CaptivePortalBrowserTest when NavigationLoaderOnUI is enabled
2019-06-27 [email protected] Stream goldctl output on V8 builders
2019-06-27 [email protected] Disable failing AutotestPrivateWithPolicyApiTest on linux-chromeos-google-rel.
2019-06-27 [email protected] Fix CrossSiteDocumentBlockingTest when NavigationLoaderOnUI is enabled
2019-06-27 [email protected] android: move android-asan to hammerhead+kitkat.
2019-06-27 [email protected] Fix Chrome OS Account Manager Settings page UI tests
2019-06-27 [email protected] Disable failing MultiActionAPITest.DynamicSetIcon tests on linux-chromeos-google-rel.
2019-06-27 [email protected] Delete MojoChannelMac fieldtrial_testing_config.json entry.
2019-06-27 [email protected] Update NavigationLoaderOnUI test filter file
2019-06-27 [email protected] Add test runs with BackForwardCache on linux-fieldtrial-rel.
2019-06-27 [email protected] Run dawn_end2end_tests with backend validation layers
2019-06-26 [email protected] Enable Lookalike URLs interstitial by default
2019-06-26 [email protected] Duplicate all src-side configs for chromium.chrome bots as chrome.
2019-06-26 [email protected] [code coverage] Move Java coverage files from --task-output-dir to --coverage-dir
2019-06-26 [email protected] android: add test filter for breakpad_unittests on ASAN.
2019-06-26 [email protected] Reland google#2: "Trichrome Proguard: Fix locale pak selection."
2019-06-26 [email protected] Android: Remove "jni_package" from JNI templates.
2019-06-26 [email protected] Move http_structured_header and SignedExchangeRequestMatcher to blink/common
2019-06-26 [email protected] [Cros SR] Add Finch flag to the field trial testing config.
2019-06-26 [email protected] Run tests for NavigationLoaderOnUI on mojo FYI bots
2019-06-25 [email protected] Add empty json config for openscreen bots
2019-06-25 [email protected] Removing references to deleted fuzzers.
2019-06-25 [email protected] fieldtrial testing OfflineContentOnDino -> AutoFetchOnNetErrorPage
2019-06-25 [email protected] Fix AppListClientImplBrowserTest.OpenSearchResult on branded builds
2019-06-25 [email protected] [Previews] Increases default slow page trigger max threshold to 3G
(...)
2019-05-07 [email protected] Quota: Update fieldtrial testing config with new suffix.
2019-05-07 [email protected] Reland Extensions Web UI: Use HTML Imports Polyfill
2019-05-07 [email protected] [fuchsia] Re-enable disabled content unittests
2019-05-07 [email protected] [NTP Suggestions] Clean up unused feature
2019-05-07 [email protected] Add content_shell_crash_test to Android
2019-05-07 [email protected] Enable OomIntervention v2 by default
2019-05-06 [email protected] Add fieldtrial configuration entry for NewAnswersLayoutAndroidOmniboxM74
2019-05-06 [email protected] [libFuzzer] Fix condition so that seed corpus is built if specified
2019-05-06 [email protected] Set default merge for isolated scripts
2019-05-06 [email protected] Revert "Remove chrome_elf_import_unittests and add delayloads_unittests"
2019-05-06 [email protected] [libFuzzer][LPM] Refer to libprotobuf-mutator as LPM
2019-05-06 [email protected] Remove chrome_elf_import_unittests and add delayloads_unittests
2019-05-06 [email protected] macOS Signing Scripts: Configure unittests to run on CI.
2019-05-06 [email protected] Add a Finch experiment V8HugeMaxOldGenerationSizefor V8 heap size increase
2019-05-06 [email protected] Blob: Add testing config for BlobReaderEagerCompletion feature.
2019-05-06 [email protected] [feature_engagement] Make it possible to check in configurations
2019-05-06 [email protected] Add FieldTrial testing config for WebRTC-BweAllocProbingOnlyInAlr.
2019-05-04 [email protected] Revert "Extensions Web UI: Use HTML Imports Polyfill"
2019-05-04 [email protected] Replace chrome_kevin_tast_tests with chrome_all_tast_tests.
2019-05-04 [email protected] Remove BackgroundSrcVideoTrackDisable Experiment
2019-05-04 [email protected] Extensions Web UI: Use HTML Imports Polyfill
2019-05-03 [email protected] Run resource_sizes on the luci android perf bots.
2019-05-03 [email protected] Revert "Make breakpad_unittests use Chrome's test runner instead of gtest's"
2019-05-03 [email protected] Add fuzzer coverage for the feature policy values parser.
2019-05-03 [email protected] Unwind Socket::kReadIfReadyExperiment.
2019-05-03 [email protected] [fuchsia] Re-enable disabled content_unittests
2019-05-03 [email protected] Make breakpad_unittests use Chrome's test runner instead of gtest's
2019-05-02 [email protected] Added missing dependency
2019-05-02 [email protected] Cleanup Viz Test Configs
2019-05-02 [email protected] Proguard flag files cleanup
2019-05-02 [email protected] Web UI HTML Imports: Add interactive_ui_tests suite
2019-05-02 [email protected] Added the representative perf tests to the test suites
2019-05-02 [email protected] Disable webgl_conformance_vulkan_passthrough_tests on Win10 NVIDIA GTX 1660
2019-05-02 [email protected] Print Preview: Use HTML Imports Polyfill
2019-05-02 [email protected] Delete testing/scripts/gyp_flag_compare.py
2019-05-01 [email protected] Set default merge script for gtests
2019-05-01 [email protected] Docs: Mention that libprotobuf-mutator is LPM
2019-05-01 [email protected] Tear down src configs for cronet buildbots.
2019-05-01 [email protected] Regression fix: don't add virtual files for drags starting in renderer
2019-05-01 [email protected] Revert "Reland "[Perf] Update Pixel2 FYI perf bot to MonoChrome6432.aab.""
2019-05-01 [email protected] [snappy] Get rid of //base dependency in snappy_compress_fuzzer.
2019-04-30 [email protected] [Fuchsia] Build and run the gfx_unittests suite.
2019-04-30 [email protected] Remove dawn_end2end_tests from GPU FYI bots
2019-04-30 [email protected] Rename NoCreditCardAbort field trial to match the finch experiment name.
2019-04-30 [email protected] Reland "[Perf] Update Pixel2 FYI perf bot to MonoChrome6432.aab."
2019-04-30 [email protected] Logic needed for representative performance tests.
2019-04-30 [email protected] Remove legacy sync codepath prior to pseudo-USS
2019-04-30 [email protected] Disables SingleProcessMash by default
2019-04-30 [email protected] [testing] Remove --output-trace-tag arg in Telemetry args
2019-04-30 [email protected] chromeos: Run all Tast tests via the host-side tast bin.

Roll ./third_party/Python-Markdown/ b08af21eb..36657c103 (1 commit)

https://chromium.googlesource.com/chromium/src/third_party/Python-Markdown/+log/b08af21eb795..36657c103ce5

$ git log b08af21eb..36657c103 --date=short --no-merges --format='%ad %ae %s'
2019-07-24 efoo OWNERS files updated with latest COMPONENT and TEAMS.

Roll ./third_party/fuchsia-sdk/ 8e8db13b5..5fd29151c (3 commits)

https://chromium.googlesource.com/chromium/src/third_party/fuchsia-sdk.git/+log/8e8db13b538e..5fd29151cf35

$ git log 8e8db13b5..5fd29151c --date=short --no-merges --format='%ad %ae %s'
2019-06-18 sergeyu [Fuchsia] Fix gen_build_defs.py to recognize device_profile sdk parts
2019-04-17 wez [Fuchsia] Switch from 'new_parts' to 'parts' when generating GN.
2019-04-11 kmarshall [Fuchsia] Use the "new_parts" section from the SDK manifest.

Roll ./third_party/googletest/ d5024103c..c721b68dd (1 commit)

https://chromium.googlesource.com/chromium/src/third_party/googletest/+log/d5024103c8a8..c721b68ddecc

$ git log d5024103c..c721b68dd --date=short --no-merges --format='%ad %ae %s'
2019-07-31 efoo OWNERS files updated with latest COMPONENT and TEAMS.

Roll ./third_party/jsoncpp/ fd0ac8ce6..48246a099 (5 commits)

https://chromium.googlesource.com/chromium/src/third_party/jsoncpp/+log/fd0ac8ce63a4..48246a099549

$ git log fd0ac8ce6..48246a099 --date=short --no-merges --format='%ad %ae %s'
2019-07-30 efoo OWNERS files updated with latest COMPONENT and TEAMS.
2019-07-16 mbonadei Do not pass -Wno-implicit-fallthrough to MSVC.
2019-07-15 mbonadei Do not use -Wno-deprecated-declarations on MSVC.
2019-07-12 jophba Update JsonCPP dependency + owners
2019-05-09 metzman [jsoncpp] Add fuzzer.

Roll ./third_party/jsoncpp/ f572e8e42e22..645250b66907 (799 commits)

https://chromium.googlesource.com/chromium/src/third_party/jsoncpp/+log/f572e8e42e22..645250b66907

$ git log f572e8e42e22..645250b66907 --date=short --no-merges --format='%ad %ae %s'

2019-07-10 [email protected] \#979 Fix parseFromStream definition
2019-07-11 [email protected] Add new JSON_USE_NULLREF flag
2019-07-09 [email protected] \#964 Delete JSONCPP_NORETURN for [[noreturn]]
2019-07-02 [email protected] pop the root node after readValue()
2019-07-02 [email protected] adjust some codes position
2019-07-01 [email protected] Update version.h.in header comments
2019-06-28 [email protected] Fix comments on Json Reader
2019-06-28 [email protected] Update minimum CMake version requirement
2019-06-28 [email protected] Issue #633: Fix issue with maxInt
2019-06-27 [email protected] Run clang-format on the repository
2019-06-26 [email protected] Add fuzz.cpp to jsoncpp_test
2019-06-26 [email protected] Update main.cpp
2019-06-26 [email protected] added fuzz.cpp to macro in main.cpp
2019-06-24 [email protected] Update jsontest.cpp
2019-06-24 [email protected] Update jsontest.cpp
2019-06-24 [email protected] Update jsontest.cpp
2019-06-24 [email protected] Update CMakeLists.txt
2019-06-24 [email protected] Update CMakeLists.txt
2019-06-24 [email protected] Update main.cpp
2019-06-24 [email protected] Update main.cpp
2019-06-24 [email protected] Update main.cpp
2019-06-24 [email protected] Added include fuzz.cpp
2019-06-24 [email protected] added llvm
2019-06-24 [email protected] fix llvm
2019-06-24 [email protected] Update fuzz.cpp
2019-06-24 [email protected] Update fuzz.h
2019-06-24 [email protected] Update fuzz.cpp
2019-06-24 [email protected] Update fuzz.h
2019-06-24 [email protected] Update fuzz.cpp
2019-06-24 [email protected] Update fuzz.h
2019-06-24 [email protected] Update fuzz.h
2019-06-24 [email protected] Update fuzz.cpp
2019-06-24 [email protected] Updated fuzz.h
2019-06-24 [email protected] Updated header and fixed the bug
2019-06-12 [email protected] Add a simple fuzz test for jsoncpp.
2019-06-03 [email protected] version.h : wrong file was deployed, added required include path and
2019-06-25 [email protected] extract variable
2019-06-21 [email protected] fix compile problem
2019-06-21 [email protected] use fpclassify to test a float number is zero or nan
2019-05-31 [email protected] repair a typo error
2019-06-24 [email protected] Issue 920: Fix android build with casting fix
2018-05-28 [email protected] Add WideString test for Issue #756
2019-06-25 [email protected] Update appveyor to use build images
2019-06-25 [email protected] Update travis scripts
2019-06-25 [email protected] Modernize Travis and Appveyor configs
2019-06-24 [email protected] Update issue templates
2019-06-24 [email protected] Update issue templates
2019-06-24 [email protected] Run clang format
2019-06-24 [email protected] Update CONTRIBUTING.md
2019-06-24 [email protected] Update README.md
2019-06-24 [email protected] Create CONTRIBUTING.md
(...)
2014-07-01 [email protected] Gave the amalgamated source section a makeover.
2014-07-01 [email protected] Gave the documentation section a makeover.
2014-07-01 [email protected] Gave the testing section a makeover.
2014-07-01 [email protected] Gave the scons section a makeover.
2014-07-01 [email protected] Gave the cmake section a makeover.
2014-07-01 [email protected] Gave the using section a makeover.
2014-07-01 [email protected] Gave the introduction section a makeover.
2014-07-01 [email protected] Began converting the README to Markdown.
2014-07-01 [email protected] Ran clang-format again.
2014-07-01 [email protected] Fixed some clang-format weirdness.
2014-07-01 [email protected] Ran clang-format over all .h and .cpp files.
2014-07-01 [email protected] Set BinPackParameters to false.
2014-07-01 [email protected] Added a clang-format config file, in preparation for formatting jsoncpp.
2014-06-30 [email protected] Fixed some cruft in the Travis CI config file.
2014-06-30 [email protected] Updated notification settings for Travis CI.
2014-05-13 [email protected] fix stdexcept
2014-04-23 [email protected] Fixed a test that causes a crash when exceptions are disabled.
2014-04-23 [email protected] Added structured error reporting to Reader.
2014-04-23 [email protected] Added features that allow the reader to accept common non-standard JSON.
2014-04-19 [email protected] vim modeline
2014-04-19 [email protected] Comment reading/write improvements
2014-04-19 [email protected] JSON_ASSERT -> JSON_ASSERT_MESSAGE
2014-01-29 [email protected] Added missing includes for std::istream.
2013-09-23 [email protected] Fixed broken build on VS 2012
2013-08-08 [email protected] Fixed some snprintf-related build breakages in Visual Studio.
2013-08-08 [email protected] Updated two calls to sprintf that I missed in r269.
2013-08-08 [email protected] Replaced the complex implementation of valueToString(double).
2013-08-08 [email protected] Added more floating point tests.
2013-08-08 [email protected] Added further floating point tests.
2013-08-06 [email protected] Switched away from sprintf, which is prone to buffer overflows.
2013-05-09 [email protected] - CMake: added option to turn fail compilation if warning occurs, and warning level 4 with MSVC. - Fixed some warnings
2013-05-09 [email protected] - disabled warning 4786 for VS6 caused by STL (identifier was truncated to '255' characters in the debug information) - added batchbuild config for XP VM
2013-05-09 [email protected] Added simple batch build script for CMake.
2013-05-09 [email protected] Added missing source file to CMakeLists.txt.
2013-05-09 [email protected]
2013-05-08 [email protected] Fixed continuous integration matrix for debug/release build. Made static debug build verbose.
2013-05-08 [email protected] Added continuous integration matrix for debug/release build. Made static debug build verbose.
2013-05-08 [email protected] Added continuous integration matrix for shared/static library (specified through environment variables).
2013-05-08 [email protected] Added continuous integration failure e-mail notification.
2013-05-08 [email protected] Added clang compiler for continuous integration.
2013-05-08 [email protected] Added basic Travis CI integration contributed by Igor Okulist.
2013-05-08 [email protected] Fixed CMake / Unix build instructions.
2013-05-08 [email protected] - New CMake based build system. Based in part on contribution from Igor Okulist and Damien Buhl (Patch google#14). Added support for running tests and building with DLL on Windows. - added missing JSON_API - Visual Studio DLL: suppressed warning "C4251: <data member>: <type> needs to have dll-interface to be used by..." via pragma push/pop in json-cpp headers. - New header json/version.h now contains version number macros (JSONCPP_VERSION_MAJOR, JSONCPP_VERSION_MINOR, JSONCPP_VERSION_PATCH and JSONCPP_VERSION_HEXA). While this header is generated by CMake, it is committed to ease build with alternate build system (CMake only update the file when it changes avoid issues with VCS).
2013-04-12 [email protected] - Patch #3393345: BOOST_FOREACH compatibility. Made Json::iterator more standard compliant, added missing iterator_category and value_type typedefs (contribued by Robert A. Iannucci). - Patch #3474563: added missing JSON_API on some classes causing link issues when building as a dynamic library on Windows (contributed by Francis Bolduc).
2013-04-12 [email protected] Patch #3600941: Missing field copy in Json::Value::iterator causing infinite loop when using experimental internal map (#define JSON_VALUE_USE_INTERNAL_MAP) (contributed by Ming-Lin Kao).
2013-04-12 [email protected] Patch #3539678: Copy constructor does not initialize allocated_ for stringValue (contributed by rmongia).
2013-02-18 [email protected] Fix gcc -Wall warnings (patch from Matt McCormick)
2012-12-20 [email protected] Fixed warning(error?) on #if testing value of _MSC_VER without checking that it was defined.
2012-07-27 [email protected] Added missing "include/json/assertions.h" header in amalgamate.py.
2012-03-12 [email protected] Made it possible to drop null placeholders from array output.


Roll ./third_party/yasm/ 86b605814..15439370a (1 commit)

https://chromium.googlesource.com/chromium/src/third_party/yasm/+log/86b6058141a4..15439370afd9

$ git log 86b605814..15439370a --date=short --no-merges --format='%ad %ae %s'
2019-03-14 thomasanderson More fixes necessary for Windows/libc++

Roll ./third_party/zlib/ f95aeb0fa..0f820c1d7 (24 commits)

https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/f95aeb0fa7f1..0f820c1d7165

$ git log f95aeb0fa..0f820c1d7 --date=short --no-merges --format='%ad %ae %s'
2019-08-08 adenilson.cavalcanti Allow disabling Castagnoli compression optimization
2019-08-05 adenilson.cavalcanti Increasing the expected compressed output size
2019-08-01 adenilson.cavalcanti Using the same hash function in compression on both x86 and ARM
2019-07-25 thakis Make chromeconf.h use opt-out instead of opt-in.
2019-07-19 darin Avoid 'internal_state' macro pollution from zlib.h.
2019-06-24 tsniatowski zlib: fix gn error when is_clang=false target_cpu="arm"
2019-06-11 scroggo Simplify sharing third_party/zlib with AOSP
2019-06-10 jose.dapena zlib: fix ARMv8 CRC32 compilation in GCC
2019-05-14 huangs [DOM Distiller] Compress resources to save 86 kB on Android.
2019-04-18 richard.townsend Tidy and further integrate Arm feature detection for Windows
2019-04-15 richard.townsend Correct zlib build logic for Windows on Arm
2019-04-15 noel [zlib] Add OS_FUCHSIA feature detection and enable zlib NEON crc32
2019-04-08 thomasanderson Make //third_party/zlib a component
2019-03-29 drubery Pass file_length to UpdateArchiveAnalyzer
2019-03-28 dcheng Update include paths for //base/hash/md5.h
2019-03-28 wnwen Android: Remove build/secondary
2019-02-15 noel [zlib] Add Android ARM aarch64 feature detection
2019-02-14 lizeb blink/bindings: Use PartitionAlloc for zlib's temporary data.
2019-02-13 noel [zlib_bench] improve program options handling
2019-01-31 adenilson.cavalcanti Enable decode input reads in 64 bit chunks
2019-01-11 lizeb blink/bindings: Use PartitionAlloc for compressing strings.
2019-01-08 avi Use base::size rather than arraysize in third_party/zlib/.
2019-01-02 avi Use base::size rather than arraysize in third_party/zlib/.
2018-12-20 msalama Avoid uncompressing if uncompressed size is too big.

Roll ./tools/md_browser/ e94626962..0bfd826f8 (2 commits)

https://chromium.googlesource.com/chromium/src/tools/md_browser/+log/e9462696241f..0bfd826f8566

$ git log e94626962..0bfd826f8 --date=short --no-merges --format='%ad %ae %s'
2019-06-18 ntfschr Docs: correctly slugify escaped chars
2019-06-01 ntfschr Better regex for md_browser.py

Created with:
  roll-dep ./build ./buildtools ./testing ./third_party/Python-Markdown ./third_party/fuchsia-sdk ./third_party/googletest ./third_party/jsoncpp ./third_party/jsoncpp/source ./third_party/yasm ./third_party/zlib ./tools/md_browser

Change-Id: Iac134649e58cf3b1d5ed13dc26e8c2bf3ebdba7b
Bug: angleproject:3792
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1744175
Reviewed-by: Jamie Madill <[email protected]>
Commit-Queue: Jamie Madill <[email protected]>
Neusoft-Technology-Solutions pushed a commit to Neusoft-Technology-Solutions/angle that referenced this pull request Jan 17, 2020
@null77
Re-land "Add new test runner harness." (google#2)
5407aaa 
Re-land google#2 changes:

 * export labels are fixed for the CFI build
 * crash test disabled because of flakiness and issues with asan

Re-land changes:

 * Unit test is suppressed in ASAN
 * --deqp-case is fixed
 * Debug layer errors should correctly work with failure expectations

Original message:

The ANGLE test harness is a harness around GoogleTest that provides
functionality similar to the Chromium test harness. It supports:

 * splitting a test set into shards
 * catching and reporting crashes and timeouts
 * outputting to the Chromium JSON test results format
 * multi-process execution

Unit tests are added in test_utils_unittest.cpp.

Bug: angleproject:3162
Bug: chromium:1030192
Change-Id: I71d66a407ea0e53d73cbe75b5b4bfb9e73791534
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1965091
Commit-Queue: Jamie Madill <[email protected]>
Reviewed-by: Jonah Ryan-Davis <[email protected]>
alastairpatrick pushed a commit to alastairpatrick/jangle that referenced this pull request Jun 3, 2020
@tobine
Vulkan:Initial worker thread disabled by default
02fa731 
Created new CommandProcessor class that can be run as a worker thread.
Running CommandProcessor within RendererVk as a worker thread that
takes a CommmandBufferHelper (CBH) ptr as the interface and processes
that CBH into a primary command buffer.

Main thread has a queue of CBH to draw from. After submitting a CBH to
the worker, it pulls next CBH from the queue. Worker thread releases CBH
back to the main thread queue when done.

Synchronization goes two ways:
1. Work submitted to worker thread is managaed with a mutex and
condition variable based around the work queue.
2. Available CBH ptrs for the main thread have a mutex and condition
variable that manages the CBH queue.

The worker thread is disabled by default, and, when enabled, it will
currently behave and perform as the non-threaded code. This is because
the kNumCommandBuffers const in ContextVk.h is set to 2. With only 2
command buffers, they will be assigned to the inside and outside
RenderPass command buffers respectively. Then, as soon as one is
submitted, the main thread will stall waiting for it to be completed
and put back into the queue mentioned in google#2 above.

The next step is to move command submission to the worker thread and
update the number of command buffers so that processing/submission
will occur in parallel with the main thread. Right now there is a
race condition issue when attempting to run in parallel because the
main thread updates and submits the same primary command buffers
that are used in the worker thread, which is in violation of the
Vulkan spec.

The follow-on CL will fix this issue as the main thread will only
touch SecondaryCommandBuffers and the worker thread will be the
only thread touching the primary command buffers.

Bug: b/154030730
Change-Id: Ib0c518bbd7ca9a3a7e789f4e1f2f7131ddc0509e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2174719
Commit-Queue: Tobin Ehlis <[email protected]>
Reviewed-by: Jamie Madill <[email protected]>
ringoz pushed a commit to ringoz/angle that referenced this pull request Nov 13, 2021
@null77
Roll third_party/vulkan_memory_allocator/ e0216a548..5e49f57a6 (87 co…
b45719a 
…mmits)

https://chromium.googlesource.com/external/github.com/GPUOpen-LibrariesAndSDKs/VulkanMemoryAllocator/+log/e0216a5484c8..5e49f57a6

$ git log e0216a548..5e49f57a6 --date=short --no-merges --format='%ad %ae %s'
2021-11-12 jmadill Fix compiliation error on Mac/Android.
2021-11-03 jmadill Suppress semicolon warning in GN.
2021-08-30 geofflang Supress a build warning.
2021-06-10 pkasting Update Chromium-side files for upstream roll
2021-04-06 cwallez BUILD.gn: Make the vulkan-headers directory overridable.
2021-02-12 shawn.p.huang change the default gn target to include vma.cpp
2021-02-03 ehmaldonado Move metadata in OWNERS files to DIR_METADATA files
2021-01-27 shawn.p.huang Add vma.cpp contains vma's implementation.
2021-01-27 shawn.p.huang Add a new target with the VmaUsage.cpp and VmaUsage.h
2020-08-26 jmadill Suppress two override suggestion warnings.
2020-06-25 thakis mac: Only call system aligned_alloc() with the 11.0+ SDK.
2020-06-25 thakis Only use system aligned_alloc on mac/ios if the SDK has them.
2020-06-25 thakis Make vulkan_memory_allocator build with the MacOSX11.0 SDK.
2020-05-05 jmadill Restore BUILD.gn.
2020-05-04 jmadill Suppress a couple more VMA warnings and update README.
2020-05-01 jmadill Update integration for use with Chromium.
2020-04-17 jonahr Modify to not depend directly on volk.
2020-04-07 jmadill Update location modifications.
2020-04-03 jmadill Fix Clang implicit fallthrough warning.
2020-04-03 jmadill Add local modifications for Vulkan Memory Allocator.
2021-11-05 adam.sawicki Documented some members of VmaVulkanFunctions to clarify which functions to fetch
2021-11-03 adam.sawicki Fixing TravisCI (Linux) CI google#2
2021-11-03 adam.sawicki Fixing TravisCI (Linux) CI
2021-11-03 git Correct Haskell bindings author name
2021-11-03 git Add typedefs for virtual allocation structs in ordinary identifier namespace
2021-10-30 adam.sawicki Fixed icon of Travis CI Linux build in README
2021-10-30 adam.sawicki Fix for compilation on Linux
2021-10-30 adam.sawicki Added mention of virtual allocator to README
2021-10-30 adam.sawicki Made virtual allocations not applying VMA_DEBUG_MARGIN
2021-10-30 adam.sawicki Fixes to various bugs found during extensive testing
2021-10-30 adam.sawicki Optimized VmaBlockMetadata_Buddy - using VmaPoolAllocator to allocate nodes
2021-10-30 adam.sawicki Refactoring: Added function VmaAddStatInfoAllocation, VmaAddStatInfoUnusedRange
2021-10-30 adam.sawicki Improved VmaBlockMetadata_Buddy when used as a virtual allocator, to support allocation sizes down to 1
2021-10-30 adam.sawicki Removed VMA_MIN_FREE_SUBALLOCATION_SIZE_TO_REGISTER to simplify the code
2021-10-30 adam.sawicki Added support for VMA_VIRTUAL_BLOCK_CREATE_BUDDY_ALGORITHM_BIT
2021-10-30 adam.sawicki Changed behavior of buddy allocator to align allocation sizes to power of 2 instead of accounting the remaining space (internal fragmentation) as free
2021-10-30 adam.sawicki Added support for VMA_VIRTUAL_BLOCK_CREATE_LINEAR_ALGORITHM_BIT
2021-10-29 adam.sawicki Implemented VmaBlockMetadata_Linear::Clear
2021-10-28 adam.sawicki Preparations for adding support for alternative algorithms in virtual blocks and tests for them
2021-10-28 adam.sawicki Added documentation chapter "Virtual allocator"
2021-10-28 adam.sawicki Written documentation for API of the virtual allocator
2021-10-28 adam.sawicki Implemented vmaBuildVirtualBlockStatsString, vmaFreeVirtualBlockStatsString
2021-10-28 adam.sawicki Improvement in vmaCreateAllocator in case creation fails
2021-10-28 adam.sawicki Implemented vmaClearVirtualBlock
2021-10-28 adam.sawicki Implemented vmaCalculateVirtualBlockStats
2021-10-28 adam.sawicki Enabled more tests
2021-10-28 adam.sawicki More coding and more tests. Basic functionality is working now.
2021-10-28 adam.sawicki Essential refactoring that made the test not crashing.
2021-10-28 adam.sawicki More implementation and first tests.
2021-10-28 adam.sawicki Defined interface for virtual allocator:
2021-10-27 adam.sawicki Fixed TestInvalidAllocations
2021-10-27 adam.sawicki Necessary refactoring to prepare for virtual allocator
2021-10-21 adam.sawicki Fixing logic of VmaDefragmentationAlgorithm_Fast::PostprocessMetadata broken by #201
2021-10-18 GermanAizek Code refactor (lower scope, local var, default constructor and destructor)
2021-10-18 adam.sawicki Fixes in comments
2021-10-06 lukasz.izdebski doxygen directory fix
2021-10-06 lukasz.izdebski doxygen generation fix
2021-10-06 lukasz.izdebski Doxygen added to CMake, shader project dependency added to Sample Project
2021-09-30 danielkrupinski Replace tabs with spaces
2021-09-30 adam.sawicki Standardized line endings to LF
2021-09-29 danielkrupinski Use forwarding references with std::forward()
2021-09-22 rverschelde Remove trailing whitespace
2021-09-20 danielkrupinski Adjust VMA_MIN() and VMA_MAX() macros to work despite NOMINMAX being defined or not.
2021-09-20 adam.sawicki Little improvement in README
2021-09-20 sk Fixed issue #192 with hardcoded VK_USE_PLATFORM_WIN32_KHR
2021-08-09 adam.sawicki Change all usage of VK_ERROR_VALIDATION_FAILED_EXT to VK_ERROR_UNKNOWN or VK_ERROR_INITIALIZATION_FAILED
2021-07-29 adam.sawicki Fixes and improvements in documentation
2021-07-28 adam.sawicki Include block IDs in debug log messages
2021-07-28 adam.sawicki Minor fixes in the docs - language
2021-07-28 adam.sawicki Added documentation chapter about OpenGL interop
2021-07-28 adam.sawicki Moved main documentation text from the beginning to the end of file
2021-07-28 adam.sawicki Removed unused variable
2021-07-25 phil-el Do not fail travis build if the build directory already exists.
2021-07-23 Hindrik1997 Add include_directories to CMake to include the header files.
2021-07-21 Hindrik1997 Disable broken aligned_alloc on new versions of macOS and revert to old behaviour.
2021-07-07 adam.sawicki Fixed documentation of the new function vmaCreateBufferWithAlignment
2021-07-07 adam.sawicki Added VmaAllocatorCreateInfo::pTypeExternalMemoryHandleTypes
2021-06-28 adam.sawicki Added function vmaCreateBufferWithAlignment
2021-06-25 adam.sawicki Used range-based for loops wherever I could
2021-06-21 adam.sawicki Regenerated documentation
2021-06-21 adam.sawicki Fixed docs
2021-06-21 adam.sawicki Fixes. Left only new member VmaPoolCreateInfo::pMemoryAllocateNext.
2021-06-18 adam.sawicki Fix to online documentation
2021-06-18 adam.sawicki Added VmaPoolCreateInfo::minAllocationAlignment
2021-06-14 adam.sawicki Renamed macro VMA_DEBUG_ALIGNMENT to VMA_MIN_ALIGNMENT as there are valid use cases for it other than debugging purposes.
2020-10-23 adam.sawicki Added VmaAllocatorCreateInfo::pTypeExternalMemoryHandleTypes
2020-10-05 adam.sawicki Add VmaPoolCreateInfo::pMemoryAllocateNext

Created with:
  roll-dep third_party/vulkan_memory_allocator

Bug: angleproject:6640
Change-Id: I8133e3c2b3f2787783f609b468adbe90026cf50d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3276037
Commit-Queue: Jamie Madill <[email protected]>
Reviewed-by: Lingfeng Yang <[email protected]>
Reviewed-by: Charlie Lao <[email protected]>
ringoz pushed a commit to ringoz/angle that referenced this pull request May 1, 2022
@romanl-g
Android perf tests shards 20->6 (only --smoke-test-mode)
c402f00 
try 4470:
Max shard runtime (5m 14s) + overhead (19s): 5m 34s (shard google#2)
Min shard runtime (4m 41s) + overhead (10s): 4m 51s (shard google#1)
Total shard runtime (29m 21s) + overhead(1m 37s): 30m 58s

Bug: angleproject:6854
Change-Id: Ia1664bd56f502a81eaa4b2f0e35722b2ff5bea3b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3605765
Commit-Queue: Jamie Madill <[email protected]>
Reviewed-by: Jamie Madill <[email protected]>
blueboxd pushed a commit to blueboxd/angle that referenced this pull request Apr 25, 2023
@i-nazarov-samsung
Implement new "Global Mutex" functionality.
b22124b 
This CL improves performance compared to the existing code as well as
allows using non-std mutex implementations. Also acts as a base for
future changes.

CL adds new build option:
    angle_enable_global_mutex_recursion = is_android && angle_enable_vulkan

"mutex_recursion" work same way as `std::recursive_mutex` before. It
will help in situations when Vulkan API may return back to the ANGLE.
For example: RenderDoc layer EGL deadlock.
Automatic loading of "libVkLayer_GLES_RenderDoc.so" layer causes
deadlock in EGL.
Recursion stack:
    google#1 pc 000000000029ea80  /vendor/lib64/egl/libGLESv2_angle.so (egl::GlobalMutexHelper::lock(int)+596)
    google#2 pc 000000000029c59c  /vendor/lib64/egl/libGLESv2_angle.so (EGL_GetError+32)

    google#4 pc 0000000000062368  /system/lib64/libEGL.so (eglQueryString+20)
    google#5 pc 0000000000508fec  /data/local/debug/vulkan/libVkLayer_GLES_RenderDoc.so

    google#20 pc 0000000000016690  /system/lib64/libvulkan.so (vulkan::api::EnumerateInstanceLayerProperties(unsigned int*, VkLayerProperties*)+40)
    google#21 pc 00000000005aa030  /vendor/lib64/egl/libGLESv2_angle.so (rx::RendererVk::initialize(rx::DisplayVk*, egl::Display*, char const*, char const*)+292)
    google#26 pc 000000000029c7e8  /vendor/lib64/egl/libGLESv2_angle.so (EGL_Initialize+192)

Additionally, recursive mutex will partially solve Android
SurfaceTexture deadlock (angleproject:4354).

Some performance numbers for 1000'000 `eglGetError()` calls.

    Mutex                                       Time (ms.)

        Android S906B

    egl::GetGlobalMutex()(std::recursive_mutex)    41.4

    (Default)   GlobalMutex (std::recursive_mutex) 39.1

    (Recursive) GlobalMutex (std::mutex)           34.9
    (Debug)     GlobalMutex (std::mutex)           34.7
    (Default)   GlobalMutex (std::mutex)           34.4

        Windows

    egl::GetGlobalMutex()(std::recursive_mutex)    20.5

    (Default)   GlobalMutex (std::recursive_mutex) 20.0

    (Recursive) GlobalMutex (std::mutex)           21.9
    (Debug)     GlobalMutex (std::mutex)           20.5
    (Default)   GlobalMutex (std::mutex)           19.9

Note: Recursive GlobalMutex enabled only for Android Vulkan by default.
Original fix:
    https://chromium-review.googlesource.com/c/angle/angle/+/2029218

Bug: angleproject:8101
Bug: angleproject:4354
Test: angle_unittests --gtest_filter=GlobalMutexTest.*
Change-Id: I9e9d9b5c598ad1177ffa147ea690bd955946a712
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4401940
Commit-Queue: Igor Nazarov <[email protected]>
Reviewed-by: Charlie Lao <[email protected]>
Reviewed-by: Shahbaz Youssefi <[email protected]>
blueboxd pushed a commit to blueboxd/angle that referenced this pull request Aug 17, 2023
@i-nazarov-samsung
Add "angle_enable_context_mutex_recursion" build option
d61a50c 
Option is for Android Vulkan.

Fixes the recursion problem:
    #00 pc 000000000004d69c  /apex/com.android.runtime/lib64/bionic/libc.so (syscall+28) (BuildId: dda896312b8ac9c639f6aeb0175b8a0a)
    google#1 pc 0000000000051e84  /apex/com.android.runtime/lib64/bionic/libc.so (__futex_wait_ex(void volatile*, bool, int, bool, timespec const*)+144) (BuildId: dda896312b8ac9c639f6aeb0175b8a0a)
    google#2 pc 00000000000b41b4  /apex/com.android.runtime/lib64/bionic/libc.so (NonPI::MutexLockWithTimeout(pthread_mutex_internal_t*, bool, timespec const*)+236) (BuildId: dda896312b8ac9c639f6aeb0175b8a0a)
    google#3 pc 00000000003d8274  /vendor/lib64/egl/libGLESv2_angle.so (std::__Cr::mutex::lock()+12) (BuildId: 203fee8f1cfe9c18)
    google#4 pc 0000000000336494  /vendor/lib64/egl/libGLESv2_angle.so (egl::SharedContextMutex<std::__Cr::mutex>::doLock()+132) (BuildId: 203fee8f1cfe9c18)
    google#5 pc 000000000033668c  /vendor/lib64/egl/libGLESv2_angle.so (egl::SharedContextMutex<std::__Cr::mutex>::lock()+124) (BuildId: 203fee8f1cfe9c18)
    google#6 pc 00000000001d6e08  /vendor/lib64/egl/libGLESv2_angle.so (EGL_ClientWaitSyncKHR+100) (BuildId: 203fee8f1cfe9c18)
    google#7 pc 00000000000674f0  /system/lib64/libEGL.so (android::eglClientWaitSyncKHRImpl(void*, void*, int, unsigned long)+112) (BuildId: c4698b8b366f6519dbd7bd3a5f6239f2)
    google#8 pc 0000000000086648  /system/lib64/libgui.so (android::BufferQueueProducer::dequeueBuffer(int*, android::sp<android::Fence>*, unsigned int, unsigned int, int, unsigned long, unsigned long*, android::FrameEventHistoryDelta*)+3240) (BuildId: ff35b91736084ee7c49efe908fb9f8f3)
    google#9 pc 00000000000e24fc  /system/lib64/libgui.so (android::Surface::dequeueBuffer(ANativeWindowBuffer**, int*)+392) (BuildId: ff35b91736084ee7c49efe908fb9f8f3)
    google#10 pc 0000000000755770  /system/lib64/libhwui.so (android::uirenderer::renderthread::ReliableSurface::hook_dequeueBuffer(ANativeWindow*, int (*)(ANativeWindow*, ANativeWindowBuffer**, int*), void*, ANativeWindowBuffer**, int*)+80) (BuildId: 0ab7d7584ac800860c4d180557441d1b)
    google#11 pc 00000000000e0b48  /system/lib64/libgui.so (android::Surface::hook_dequeueBuffer(ANativeWindow*, ANativeWindowBuffer**, int*)+92) (BuildId: ff35b91736084ee7c49efe908fb9f8f3)
    google#12 pc 000000000002cc8c  /system/lib64/libvulkan.so (vulkan::driver::AcquireNextImageKHR(VkDevice_T*, VkSwapchainKHR_T*, unsigned long, VkSemaphore_T*, VkFence_T*, unsigned int*)+280) (BuildId: 0c72f8685858f73fbb13fd68d401bba5)
    google#13 pc 0000000000266f08  /vendor/lib64/egl/libGLESv2_angle.so (rx::(anonymous namespace)::TryAcquireNextImageUnlocked(VkDevice_T*, VkSwapchainKHR_T*, rx::impl::ImageAcquireOperation*)+128) (BuildId: 203fee8f1cfe9c18)
    google#14 pc 000000000026495c  /vendor/lib64/egl/libGLESv2_angle.so (rx::WindowSurfaceVk::acquireNextSwapchainImage(rx::vk::Context*)+140) (BuildId: 203fee8f1cfe9c18)
    google#15 pc 0000000000265800  /vendor/lib64/egl/libGLESv2_angle.so (rx::WindowSurfaceVk::doDeferredAcquireNextImageWithUsableSwapchain(gl::Context const*)+148) (BuildId: 203fee8f1cfe9c18)
    google#16 pc 0000000000267bb4  /vendor/lib64/egl/libGLESv2_angle.so (rx::WindowSurfaceVk::getBufferAge(gl::Context const*, int*)+196) (BuildId: 203fee8f1cfe9c18)
    google#17 pc 000000000034143c  /vendor/lib64/egl/libGLESv2_angle.so (egl::Surface::getBufferAge(gl::Context const*, int*)+36) (BuildId: 203fee8f1cfe9c18)
    google#18 pc 000000000036c354  /vendor/lib64/egl/libGLESv2_angle.so (egl::QuerySurfaceAttrib(egl::Display const*, gl::Context const*, egl::Surface*, int, int*)+812) (BuildId: 203fee8f1cfe9c18)
    google#19 pc 00000000001d1674  /vendor/lib64/egl/libGLESv2_angle.so (egl::QuerySurface(egl::Thread*, egl::Display*, egl::SurfaceID, int, int*)+176) (BuildId: 203fee8f1cfe9c18)
    google#20 pc 00000000001d3658  /vendor/lib64/egl/libGLESv2_angle.so (EGL_QuerySurface+200) (BuildId: 203fee8f1cfe9c18)

Happens only on platforms that use "EGL_KHR_fence_sync" instead of
"EGL_ANDROID_native_fence_sync" for synchronization. Happens only on
specific Surface types, that using `EGLConsumer`/`GLConsumer`, such as
`SurfaceTexture`.

The Android's "testDrawingHardwareBitmapNotLeaking" test may be used for
testing the issue. Note: in order to reproduce, `SingleContextMutex`
must not be used by context. The "Fix ExternalImageTarget EGLImage race"
CL will achieve that.

To check what extension is used, call:
    adb shell "dumpsys SurfaceFlinger | grep 'Sync configuration'"
Possible results:
    Sync configuration: [using: EGL_KHR_fence_sync EGL_KHR_wait_sync]
    Sync configuration: [using: EGL_ANDROID_native_fence_sync EGL_KHR_wait_sync]

Bug: angleproject:4354
Change-Id: I915a2c026b59af0a2098ae6b3300f773b29cbfbb
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4733831
Commit-Queue: Igor Nazarov <[email protected]>
Reviewed-by: Shahbaz Youssefi <[email protected]>
hubot pushed a commit that referenced this pull request Feb 28, 2024
@y-novikov
Fix #2 upload_results_to_perf_dashboard usage
434a5b0 
Pass output_json_file name as an argument, instead of the open file.

Bug: chromium:40807291
Change-Id: Ia0f52ff3b3a3551bcdcda235ebaa90ae217cea54
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5332432
Commit-Queue: Yuly Novikov <[email protected]>
Reviewed-by: Brian Sheedy <[email protected]>
Commit-Queue: Brian Sheedy <[email protected]>
Auto-Submit: Yuly Novikov <[email protected]>
hubot pushed a commit that referenced this pull request Jan 6, 2025
@mdenton8
WGSL: support small stride arrays in uniforms
53ec86a 
WGSL requires arrays in the uniform address space to have a stride
a multiple of 16.

This CL makes WGSL translator emit wrapper structs for array element
types used in the uniform address space, when the array stride is
not a multiple of 16. The exception is for structs that aren't
an aligned size of 16n, and for any types matCx2, since they are
(or will be) handled in different ways that ensure alignment to 16.
This should leave only f32, i32, u32, and vec2.
See https://www.w3.org/TR/WGSL/#example-67da5de6 for an example
of using a wrapper struct.

This requires converting arrays with a wrapper struct element type
to arrays with an unwrapped element type when they are first used;
this can be "optimized" later for the common case of accessing a
single array element, which can then be unwrapped immediately. This
CL generates WGSL conversion functions when necessary.

After this, the only types that can't yet be used in a uniform
are matCx2 and bools.

This is #2 in
https://docs.google.com/document/d/17Qku1QEbLDhvJS-JJ9lPQAbnuZtLxWhG-ha5eCUhtEY/edit?tab=t.0#bookmark=id.rt3slgehd4te

Bug: angleproject:376553328
Change-Id: I1edfa7f481a6cbf5b595643aae8728e67bc4b770
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6092038
Reviewed-by: Shahbaz Youssefi <[email protected]>
Reviewed-by: Liza Burakova <[email protected]>
Reviewed-by: Matt Denton <[email protected]>
Commit-Queue: Matt Denton <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@selvamohandoss @vonture @smohandoss0611