Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Link fix #14

Closed
wants to merge 1 commit into from
Closed

Link fix #14

wants to merge 1 commit into from

Conversation

kant
Copy link

@kant kant commented Oct 15, 2017

No description provided.

@vonture vonture closed this Nov 13, 2017
anydream pushed a commit to anydream/angle that referenced this pull request Jun 20, 2019
@kkinnunen
D3D: Add a wrapper to Image11 that enables ASAN/MSAN to catch the err…
a4c639c 
…ors on map operations

The wrapper should be a no-op on builds with assertions disabled.
The wrapper should be useful on ASAN and MSAN builds.

gn args out/release-asan --args="is_debug=false is_asan=true"
ninja -C out/release-asan angle_end2end_tests ^
 out\release-asan\angle_end2end_tests ^
 --gtest_filter=Texture2DArrayCopy.SnormFormats* --gtest_catch_exceptions=0 ^
 --gtest_repeat=-1

Output when the fix payload of angleproject:2865 is removed:

...

Repeating all tests (iteration 1) . . .

Note: Google Test filter = Texture2DArrayCopy.SnormFormats*
[==========] Running 1 test from 1 test suite.
[----------] Global test environment set-up.
[----------] 1 test from Texture2DArrayCopy
[ RUN      ] Texture2DArrayCopy.SnormFormats/ES3_D3D11
=================================================================
==500==ERROR: AddressSanitizer: heap-buffer-overflow on address 0x12b2c4777040 at pc 0x7fff9602216b bp 0x00c0eaafd090 sp 0x00c0eaafd0d8
READ of size 1 at 0x12b2c4777040 thread T0
    #0 0x7fff9602216a in angle::R8G8B8A8::readColor c:\Users\kkinnunen\angle\src\image_util\imageformats.cpp:333
    google#1 0x7fff9618dbf0 in rx::CopyImageCHROMIUM c:\Users\kkinnunen\angle\src\libANGLE\renderer\renderer_utils.cpp:377
    google#2 0x7fff96186bb2 in rx::Image11::CopyImage c:\Users\kkinnunen\angle\src\libANGLE\renderer\d3d\d3d11\Image11.cpp:113
    google#3 0x7fff95e90410 in rx::Renderer11::copyImage c:\Users\kkinnunen\angle\src\libANGLE\renderer\d3d\d3d11\Renderer11.cpp:3009
    google#4 0x7fff9617b447 in rx::TextureD3D_2DArray::copyTexture c:\Users\kkinnunen\angle\src\libANGLE\renderer\d3d\TextureD3D.cpp:3293
    google#5 0x7fff95afd7e1 in gl::Texture::copyTexture c:\Users\kkinnunen\angle\src\libANGLE\Texture.cpp:1196
    google#6 0x7fff95977f19 in gl::Context::copyTexture3D c:\Users\kkinnunen\angle\src\libANGLE\Context.cpp:4347
    google#7 0x7fff9568b04a in gl::CopyTexture3DANGLE c:\Users\kkinnunen\angle\src\libGLESv2\entry_points_gles_ext_autogen.cpp:57
    google#8 0x7ff7d1d8fc97 in angle::CopyTexture3DTest::testCopy c:\Users\kkinnunen\angle\src\tests\gl_tests\CopyTexture3DTest.cpp:90
    google#9 0x7ff7d1dadd10 in angle::Texture2DArrayCopy_SnormFormats_Test::TestBody c:\Users\kkinnunen\angle\src\tests\gl_tests\CopyTexture3DTest.cpp:1272
    google#10 0x7ff7d2c22891 in testing::Test::Run c:\Users\kkinnunen\angle\third_party\googletest\src\googletest\src\gtest.cc:2522
    google#11 0x7ff7d2c243c0 in testing::TestInfo::Run c:\Users\kkinnunen\angle\third_party\googletest\src\googletest\src\gtest.cc:2698
    google#12 0x7ff7d2c253e8 in testing::TestSuite::Run c:\Users\kkinnunen\angle\third_party\googletest\src\googletest\src\gtest.cc:2828
    google#13 0x7ff7d2c3f33e in testing::internal::UnitTestImpl::RunAllTests c:\Users\kkinnunen\angle\third_party\googletest\src\googletest\src\gtest.cc:5285
    google#14 0x7ff7d2c3e72d in testing::UnitTest::Run c:\Users\kkinnunen\angle\third_party\googletest\src\googletest\src\gtest.cc:4873
    google#15 0x7ff7d2bf10a2 in main c:\Users\kkinnunen\angle\src\tests\angle_end2end_tests_main.cpp:15
    google#16 0x7ff7d2d27897 in __scrt_common_main_seh f:\dd\vctools\crt\vcstartup\src\startup\exe_common.inl:283
    google#17 0x7ff801ec7973 in BaseThreadInitThunk+0x13 (C:\WINDOWS\System32\KERNEL32.DLL+0x180017973)
    google#18 0x7ff804cea270 in RtlUserThreadStart+0x20 (C:\WINDOWS\SYSTEM32\ntdll.dll+0x18006a270)

0x12b2c4777040 is located 0 bytes to the right of 256-byte region [0x12b2c4776f40,0x12b2c4777040)
allocated by thread T0 here:
    #0 0x7ff7d2c6d574 in malloc C:\b\s\w\ir\k\src\third_party\llvm\projects\compiler-rt\lib\asan\asan_malloc_win.cc:68
    google#1 0x7fff95af47b2 in angle::MemoryBuffer::resize c:\Users\kkinnunen\angle\src\common\MemoryBuffer.cpp:40
    google#2 0x7fff9648c9a6 in rx::MappedSubresourceVerifier11::wrap c:\Users\kkinnunen\angle\src\libANGLE\renderer\d3d\d3d11\MappedSubresourceVerifier11.cpp:51
    google#3 0x7fff961864b5 in rx::Image11::map c:\Users\kkinnunen\angle\src\libANGLE\renderer\d3d\d3d11\Image11.cpp:648
    google#4 0x7fff9618676c in rx::Image11::CopyImage c:\Users\kkinnunen\angle\src\libANGLE\renderer\d3d\d3d11\Image11.cpp:93
    google#5 0x7fff95e90410 in rx::Renderer11::copyImage c:\Users\kkinnunen\angle\src\libANGLE\renderer\d3d\d3d11\Renderer11.cpp:3009
    google#6 0x7fff9617b447 in rx::TextureD3D_2DArray::copyTexture c:\Users\kkinnunen\angle\src\libANGLE\renderer\d3d\TextureD3D.cpp:3293
    google#7 0x7fff95afd7e1 in gl::Texture::copyTexture c:\Users\kkinnunen\angle\src\libANGLE\Texture.cpp:1196
    google#8 0x7fff95977f19 in gl::Context::copyTexture3D c:\Users\kkinnunen\angle\src\libANGLE\Context.cpp:4347
    google#9 0x7fff9568b04a in gl::CopyTexture3DANGLE c:\Users\kkinnunen\angle\src\libGLESv2\entry_points_gles_ext_autogen.cpp:57
    google#10 0x7ff7d1d8fc97 in angle::CopyTexture3DTest::testCopy c:\Users\kkinnunen\angle\src\tests\gl_tests\CopyTexture3DTest.cpp:90
    google#11 0x7ff7d1dadd10 in angle::Texture2DArrayCopy_SnormFormats_Test::TestBody c:\Users\kkinnunen\angle\src\tests\gl_tests\CopyTexture3DTest.cpp:1272
    google#12 0x7ff7d2c22891 in testing::Test::Run c:\Users\kkinnunen\angle\third_party\googletest\src\googletest\src\gtest.cc:2522
    google#13 0x7ff7d2c243c0 in testing::TestInfo::Run c:\Users\kkinnunen\angle\third_party\googletest\src\googletest\src\gtest.cc:2698
    google#14 0x7ff7d2c253e8 in testing::TestSuite::Run c:\Users\kkinnunen\angle\third_party\googletest\src\googletest\src\gtest.cc:2828
    google#15 0x7ff7d2c3f33e in testing::internal::UnitTestImpl::RunAllTests c:\Users\kkinnunen\angle\third_party\googletest\src\googletest\src\gtest.cc:5285
    google#16 0x7ff7d2c3e72d in testing::UnitTest::Run c:\Users\kkinnunen\angle\third_party\googletest\src\googletest\src\gtest.cc:4873
    google#17 0x7ff7d2bf10a2 in main c:\Users\kkinnunen\angle\src\tests\angle_end2end_tests_main.cpp:15
    google#18 0x7ff7d2d27897 in __scrt_common_main_seh f:\dd\vctools\crt\vcstartup\src\startup\exe_common.inl:283
    google#19 0x7ff801ec7973 in BaseThreadInitThunk+0x13 (C:\WINDOWS\System32\KERNEL32.DLL+0x180017973)
    google#20 0x7ff804cea270 in RtlUserThreadStart+0x20 (C:\WINDOWS\SYSTEM32\ntdll.dll+0x18006a270)

Bug: angleproject:2865
Change-Id: I6c8fc203d075014ba8ce31c728982eed73812d04
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1640212
Commit-Queue: Kimmo Kinnunen FI <[email protected]>
Reviewed-by: Geoff Lang <[email protected]>
cnorthrop pushed a commit to cnorthrop/angle that referenced this pull request Aug 19, 2019
@riannucci
Rolling 11 dependencies
da8dad1 
Roll ./build/ 680f9ea3d..5262b9094 (10 commits)

https://chromium.googlesource.com/chromium/src/build.git/+log/680f9ea3db81..5262b9094642

$ git log 680f9ea3d..5262b9094 --date=short --no-merges --format='%ad %ae %s'
2019-08-08 chromium-autoroll Roll Fuchsia SDK from 890571594499 to 890568639186
2019-08-08 chromium-autoroll Roll Fuchsia SDK from 890574089166 to 890571594499
2019-08-08 chromium-autoroll Roll Fuchsia SDK from 890577289982 to 890574089166
2019-08-07 gogerald [StartSurface] Move the tab_ui strings to the feature module
2019-08-07 tiborg [build] Remove dont_load_shared_libraries GN parameter
2019-08-07 chromium-autoroll Roll Fuchsia SDK from 890579756157 to 890577289982
2019-08-07 chromium-autoroll Roll Fuchsia SDK from 890582331998 to 890579756157
2019-08-07 chromium-autoroll Roll Fuchsia SDK from 890585497544 to 890582331998
2019-08-07 yucliu [Fuchsia][EME] Correct CDM service name
2019-08-07 hmohit Add gn arg to overwrite rpath.

Roll ./buildtools/ d5c58b84d..74cfb5700 (19 commits; 3 trivial rolls)

https://chromium.googlesource.com/chromium/src/buildtools.git/+log/d5c58b84d50d..74cfb57006f8

$ git log d5c58b84d..74cfb5700 --date=short --no-merges --format='%ad %ae %s'
2019-07-25 thomasanderson List natvis files as inputs
2019-07-23 tikuta Roll GN from 972ed755 to 152c5144
2019-07-19 tsniatowski ensure_gn_version.py: don't die if existing gn is very old
2019-07-16 bratell Before trying to overwrite the gn binary, make it writable
2019-07-12 vapier ensure_gn_version.py: reinstall if tool is missing
2019-07-11 vapier ensure_gn_version.py: fix exception printing
2019-06-24 brettw Roll GN from 8c7f4910 to 972ed755
2019-06-21 thomasanderson Reland "Roll GN from 81ee1967 to 8c7f4910"
2019-06-17 sdy Revert "Roll GN from 81ee1967 to 8c7f4910"
2019-06-16 thomasanderson Roll GN from 81ee1967 to 8c7f4910
2019-06-14 mstensho Revert "Roll src/buildtools/third_party/libc++/trunk/ 5938e0582..ad464887b (53 commits)"
2019-06-13 mstensho Revert "Roll src/buildtools/third_party/libc++/trunk/ 5938e0582..78822a685 (48 commits)"
2019-06-07 oysteine Tracing: Moved the tracing sampling profiler to the tracing service
2019-05-23 wychen Exclude AndroidStudioDefault folder in Java import checking
2019-05-19 rsesek Roll GN from 64b846c9 to 81ee1967.
2019-05-13 jbudorick checkdeps: encode input to os.walk as utf-8.

Roll ./testing/ 32e614b7e..58990c945 (420 commits)

https://chromium.googlesource.com/chromium/src/testing/+log/32e614b7ec7b..58990c945ffa

$ git log 32e614b7e..58990c945 --date=short --no-merges --format='%ad %ae %s'
2019-07-01 [email protected] Update NavigationLoaderOnUI browser_tests filter again
2019-07-01 [email protected] [EoS] Update fieldtrial testing config
2019-07-01 [email protected] [Extensions] De-flake MultiActionAPITest.DynamicSetIcon
2019-07-01 [email protected] Add the "remote" arg for chromeos-kevin-perf-fyi
2019-07-01 [email protected] [code coverage] Merge Java coverage files to avoid duplicate names
2019-07-01 [email protected] Change revision passed to V8 GPU pixel tests
2019-07-01 [email protected] Add filter file for services_unittests on android-asan.
2019-07-01 [email protected] Fix WelcomeScreenBrowserTest keyboard selection
2019-07-01 [email protected] [testing/buildbot] switch to use xenial for some test
2019-06-29 [email protected] Make metadata an optional field that does not need to be the same for all shard's JSON results
2019-06-29 [email protected] Update NavigationLoaderOnUI browser_tests filter
2019-06-29 [email protected] luci: add android-asan back to consoles.
2019-06-28 [email protected] perf: run internal resource_sizes_* targets on both android builders.
2019-06-28 [email protected] Re-enable tests on Linux Experimental NVIDIA and Intel bots.
2019-06-28 [email protected] [perf] Add performance_test_suite for chromeos-kevin-perf-fyi tester
2019-06-28 [email protected] Use targeted OS version for GPU bots.
2019-06-28 [email protected] Enable PredictivePrefetchingAllowedOnAllConnectionTypes
2019-06-28 [email protected] Add android_browsertests to the set of all builds and run it on the bots
2019-06-28 [email protected] Disable reflection-on-composited test for Vulkan FYI
2019-06-28 [email protected] Revert "Reland google#2: "Trichrome Proguard: Fix locale pak selection.""
2019-06-28 [email protected] Add security interstititial dark mode experiment to field trial testing config
2019-06-28 [email protected] Make DataReductionProxyURLLoaderThrottle work on UI thread
2019-06-28 [email protected] Reduce the shard number to 4 for android-pixel2-perf-fyi tester
2019-06-28 [email protected] Add more flaky tests to SKV content_browsertests
2019-06-28 [email protected] Convert URLLoaderRequestInterceptors to work on UI thread
2019-06-27 [email protected] Fix for the fyi bot runs of BF Cache tests.
2019-06-27 [email protected] Fix CaptivePortalBrowserTest when NavigationLoaderOnUI is enabled
2019-06-27 [email protected] Stream goldctl output on V8 builders
2019-06-27 [email protected] Disable failing AutotestPrivateWithPolicyApiTest on linux-chromeos-google-rel.
2019-06-27 [email protected] Fix CrossSiteDocumentBlockingTest when NavigationLoaderOnUI is enabled
2019-06-27 [email protected] android: move android-asan to hammerhead+kitkat.
2019-06-27 [email protected] Fix Chrome OS Account Manager Settings page UI tests
2019-06-27 [email protected] Disable failing MultiActionAPITest.DynamicSetIcon tests on linux-chromeos-google-rel.
2019-06-27 [email protected] Delete MojoChannelMac fieldtrial_testing_config.json entry.
2019-06-27 [email protected] Update NavigationLoaderOnUI test filter file
2019-06-27 [email protected] Add test runs with BackForwardCache on linux-fieldtrial-rel.
2019-06-27 [email protected] Run dawn_end2end_tests with backend validation layers
2019-06-26 [email protected] Enable Lookalike URLs interstitial by default
2019-06-26 [email protected] Duplicate all src-side configs for chromium.chrome bots as chrome.
2019-06-26 [email protected] [code coverage] Move Java coverage files from --task-output-dir to --coverage-dir
2019-06-26 [email protected] android: add test filter for breakpad_unittests on ASAN.
2019-06-26 [email protected] Reland google#2: "Trichrome Proguard: Fix locale pak selection."
2019-06-26 [email protected] Android: Remove "jni_package" from JNI templates.
2019-06-26 [email protected] Move http_structured_header and SignedExchangeRequestMatcher to blink/common
2019-06-26 [email protected] [Cros SR] Add Finch flag to the field trial testing config.
2019-06-26 [email protected] Run tests for NavigationLoaderOnUI on mojo FYI bots
2019-06-25 [email protected] Add empty json config for openscreen bots
2019-06-25 [email protected] Removing references to deleted fuzzers.
2019-06-25 [email protected] fieldtrial testing OfflineContentOnDino -> AutoFetchOnNetErrorPage
2019-06-25 [email protected] Fix AppListClientImplBrowserTest.OpenSearchResult on branded builds
2019-06-25 [email protected] [Previews] Increases default slow page trigger max threshold to 3G
(...)
2019-05-07 [email protected] Quota: Update fieldtrial testing config with new suffix.
2019-05-07 [email protected] Reland Extensions Web UI: Use HTML Imports Polyfill
2019-05-07 [email protected] [fuchsia] Re-enable disabled content unittests
2019-05-07 [email protected] [NTP Suggestions] Clean up unused feature
2019-05-07 [email protected] Add content_shell_crash_test to Android
2019-05-07 [email protected] Enable OomIntervention v2 by default
2019-05-06 [email protected] Add fieldtrial configuration entry for NewAnswersLayoutAndroidOmniboxM74
2019-05-06 [email protected] [libFuzzer] Fix condition so that seed corpus is built if specified
2019-05-06 [email protected] Set default merge for isolated scripts
2019-05-06 [email protected] Revert "Remove chrome_elf_import_unittests and add delayloads_unittests"
2019-05-06 [email protected] [libFuzzer][LPM] Refer to libprotobuf-mutator as LPM
2019-05-06 [email protected] Remove chrome_elf_import_unittests and add delayloads_unittests
2019-05-06 [email protected] macOS Signing Scripts: Configure unittests to run on CI.
2019-05-06 [email protected] Add a Finch experiment V8HugeMaxOldGenerationSizefor V8 heap size increase
2019-05-06 [email protected] Blob: Add testing config for BlobReaderEagerCompletion feature.
2019-05-06 [email protected] [feature_engagement] Make it possible to check in configurations
2019-05-06 [email protected] Add FieldTrial testing config for WebRTC-BweAllocProbingOnlyInAlr.
2019-05-04 [email protected] Revert "Extensions Web UI: Use HTML Imports Polyfill"
2019-05-04 [email protected] Replace chrome_kevin_tast_tests with chrome_all_tast_tests.
2019-05-04 [email protected] Remove BackgroundSrcVideoTrackDisable Experiment
2019-05-04 [email protected] Extensions Web UI: Use HTML Imports Polyfill
2019-05-03 [email protected] Run resource_sizes on the luci android perf bots.
2019-05-03 [email protected] Revert "Make breakpad_unittests use Chrome's test runner instead of gtest's"
2019-05-03 [email protected] Add fuzzer coverage for the feature policy values parser.
2019-05-03 [email protected] Unwind Socket::kReadIfReadyExperiment.
2019-05-03 [email protected] [fuchsia] Re-enable disabled content_unittests
2019-05-03 [email protected] Make breakpad_unittests use Chrome's test runner instead of gtest's
2019-05-02 [email protected] Added missing dependency
2019-05-02 [email protected] Cleanup Viz Test Configs
2019-05-02 [email protected] Proguard flag files cleanup
2019-05-02 [email protected] Web UI HTML Imports: Add interactive_ui_tests suite
2019-05-02 [email protected] Added the representative perf tests to the test suites
2019-05-02 [email protected] Disable webgl_conformance_vulkan_passthrough_tests on Win10 NVIDIA GTX 1660
2019-05-02 [email protected] Print Preview: Use HTML Imports Polyfill
2019-05-02 [email protected] Delete testing/scripts/gyp_flag_compare.py
2019-05-01 [email protected] Set default merge script for gtests
2019-05-01 [email protected] Docs: Mention that libprotobuf-mutator is LPM
2019-05-01 [email protected] Tear down src configs for cronet buildbots.
2019-05-01 [email protected] Regression fix: don't add virtual files for drags starting in renderer
2019-05-01 [email protected] Revert "Reland "[Perf] Update Pixel2 FYI perf bot to MonoChrome6432.aab.""
2019-05-01 [email protected] [snappy] Get rid of //base dependency in snappy_compress_fuzzer.
2019-04-30 [email protected] [Fuchsia] Build and run the gfx_unittests suite.
2019-04-30 [email protected] Remove dawn_end2end_tests from GPU FYI bots
2019-04-30 [email protected] Rename NoCreditCardAbort field trial to match the finch experiment name.
2019-04-30 [email protected] Reland "[Perf] Update Pixel2 FYI perf bot to MonoChrome6432.aab."
2019-04-30 [email protected] Logic needed for representative performance tests.
2019-04-30 [email protected] Remove legacy sync codepath prior to pseudo-USS
2019-04-30 [email protected] Disables SingleProcessMash by default
2019-04-30 [email protected] [testing] Remove --output-trace-tag arg in Telemetry args
2019-04-30 [email protected] chromeos: Run all Tast tests via the host-side tast bin.

Roll ./third_party/Python-Markdown/ b08af21eb..36657c103 (1 commit)

https://chromium.googlesource.com/chromium/src/third_party/Python-Markdown/+log/b08af21eb795..36657c103ce5

$ git log b08af21eb..36657c103 --date=short --no-merges --format='%ad %ae %s'
2019-07-24 efoo OWNERS files updated with latest COMPONENT and TEAMS.

Roll ./third_party/fuchsia-sdk/ 8e8db13b5..5fd29151c (3 commits)

https://chromium.googlesource.com/chromium/src/third_party/fuchsia-sdk.git/+log/8e8db13b538e..5fd29151cf35

$ git log 8e8db13b5..5fd29151c --date=short --no-merges --format='%ad %ae %s'
2019-06-18 sergeyu [Fuchsia] Fix gen_build_defs.py to recognize device_profile sdk parts
2019-04-17 wez [Fuchsia] Switch from 'new_parts' to 'parts' when generating GN.
2019-04-11 kmarshall [Fuchsia] Use the "new_parts" section from the SDK manifest.

Roll ./third_party/googletest/ d5024103c..c721b68dd (1 commit)

https://chromium.googlesource.com/chromium/src/third_party/googletest/+log/d5024103c8a8..c721b68ddecc

$ git log d5024103c..c721b68dd --date=short --no-merges --format='%ad %ae %s'
2019-07-31 efoo OWNERS files updated with latest COMPONENT and TEAMS.

Roll ./third_party/jsoncpp/ fd0ac8ce6..48246a099 (5 commits)

https://chromium.googlesource.com/chromium/src/third_party/jsoncpp/+log/fd0ac8ce63a4..48246a099549

$ git log fd0ac8ce6..48246a099 --date=short --no-merges --format='%ad %ae %s'
2019-07-30 efoo OWNERS files updated with latest COMPONENT and TEAMS.
2019-07-16 mbonadei Do not pass -Wno-implicit-fallthrough to MSVC.
2019-07-15 mbonadei Do not use -Wno-deprecated-declarations on MSVC.
2019-07-12 jophba Update JsonCPP dependency + owners
2019-05-09 metzman [jsoncpp] Add fuzzer.

Roll ./third_party/jsoncpp/ f572e8e42e22..645250b66907 (799 commits)

https://chromium.googlesource.com/chromium/src/third_party/jsoncpp/+log/f572e8e42e22..645250b66907

$ git log f572e8e42e22..645250b66907 --date=short --no-merges --format='%ad %ae %s'

2019-07-10 [email protected] \#979 Fix parseFromStream definition
2019-07-11 [email protected] Add new JSON_USE_NULLREF flag
2019-07-09 [email protected] \#964 Delete JSONCPP_NORETURN for [[noreturn]]
2019-07-02 [email protected] pop the root node after readValue()
2019-07-02 [email protected] adjust some codes position
2019-07-01 [email protected] Update version.h.in header comments
2019-06-28 [email protected] Fix comments on Json Reader
2019-06-28 [email protected] Update minimum CMake version requirement
2019-06-28 [email protected] Issue #633: Fix issue with maxInt
2019-06-27 [email protected] Run clang-format on the repository
2019-06-26 [email protected] Add fuzz.cpp to jsoncpp_test
2019-06-26 [email protected] Update main.cpp
2019-06-26 [email protected] added fuzz.cpp to macro in main.cpp
2019-06-24 [email protected] Update jsontest.cpp
2019-06-24 [email protected] Update jsontest.cpp
2019-06-24 [email protected] Update jsontest.cpp
2019-06-24 [email protected] Update CMakeLists.txt
2019-06-24 [email protected] Update CMakeLists.txt
2019-06-24 [email protected] Update main.cpp
2019-06-24 [email protected] Update main.cpp
2019-06-24 [email protected] Update main.cpp
2019-06-24 [email protected] Added include fuzz.cpp
2019-06-24 [email protected] added llvm
2019-06-24 [email protected] fix llvm
2019-06-24 [email protected] Update fuzz.cpp
2019-06-24 [email protected] Update fuzz.h
2019-06-24 [email protected] Update fuzz.cpp
2019-06-24 [email protected] Update fuzz.h
2019-06-24 [email protected] Update fuzz.cpp
2019-06-24 [email protected] Update fuzz.h
2019-06-24 [email protected] Update fuzz.h
2019-06-24 [email protected] Update fuzz.cpp
2019-06-24 [email protected] Updated fuzz.h
2019-06-24 [email protected] Updated header and fixed the bug
2019-06-12 [email protected] Add a simple fuzz test for jsoncpp.
2019-06-03 [email protected] version.h : wrong file was deployed, added required include path and
2019-06-25 [email protected] extract variable
2019-06-21 [email protected] fix compile problem
2019-06-21 [email protected] use fpclassify to test a float number is zero or nan
2019-05-31 [email protected] repair a typo error
2019-06-24 [email protected] Issue 920: Fix android build with casting fix
2018-05-28 [email protected] Add WideString test for Issue #756
2019-06-25 [email protected] Update appveyor to use build images
2019-06-25 [email protected] Update travis scripts
2019-06-25 [email protected] Modernize Travis and Appveyor configs
2019-06-24 [email protected] Update issue templates
2019-06-24 [email protected] Update issue templates
2019-06-24 [email protected] Run clang format
2019-06-24 [email protected] Update CONTRIBUTING.md
2019-06-24 [email protected] Update README.md
2019-06-24 [email protected] Create CONTRIBUTING.md
(...)
2014-07-01 [email protected] Gave the amalgamated source section a makeover.
2014-07-01 [email protected] Gave the documentation section a makeover.
2014-07-01 [email protected] Gave the testing section a makeover.
2014-07-01 [email protected] Gave the scons section a makeover.
2014-07-01 [email protected] Gave the cmake section a makeover.
2014-07-01 [email protected] Gave the using section a makeover.
2014-07-01 [email protected] Gave the introduction section a makeover.
2014-07-01 [email protected] Began converting the README to Markdown.
2014-07-01 [email protected] Ran clang-format again.
2014-07-01 [email protected] Fixed some clang-format weirdness.
2014-07-01 [email protected] Ran clang-format over all .h and .cpp files.
2014-07-01 [email protected] Set BinPackParameters to false.
2014-07-01 [email protected] Added a clang-format config file, in preparation for formatting jsoncpp.
2014-06-30 [email protected] Fixed some cruft in the Travis CI config file.
2014-06-30 [email protected] Updated notification settings for Travis CI.
2014-05-13 [email protected] fix stdexcept
2014-04-23 [email protected] Fixed a test that causes a crash when exceptions are disabled.
2014-04-23 [email protected] Added structured error reporting to Reader.
2014-04-23 [email protected] Added features that allow the reader to accept common non-standard JSON.
2014-04-19 [email protected] vim modeline
2014-04-19 [email protected] Comment reading/write improvements
2014-04-19 [email protected] JSON_ASSERT -> JSON_ASSERT_MESSAGE
2014-01-29 [email protected] Added missing includes for std::istream.
2013-09-23 [email protected] Fixed broken build on VS 2012
2013-08-08 [email protected] Fixed some snprintf-related build breakages in Visual Studio.
2013-08-08 [email protected] Updated two calls to sprintf that I missed in r269.
2013-08-08 [email protected] Replaced the complex implementation of valueToString(double).
2013-08-08 [email protected] Added more floating point tests.
2013-08-08 [email protected] Added further floating point tests.
2013-08-06 [email protected] Switched away from sprintf, which is prone to buffer overflows.
2013-05-09 [email protected] - CMake: added option to turn fail compilation if warning occurs, and warning level 4 with MSVC. - Fixed some warnings
2013-05-09 [email protected] - disabled warning 4786 for VS6 caused by STL (identifier was truncated to '255' characters in the debug information) - added batchbuild config for XP VM
2013-05-09 [email protected] Added simple batch build script for CMake.
2013-05-09 [email protected] Added missing source file to CMakeLists.txt.
2013-05-09 [email protected]
2013-05-08 [email protected] Fixed continuous integration matrix for debug/release build. Made static debug build verbose.
2013-05-08 [email protected] Added continuous integration matrix for debug/release build. Made static debug build verbose.
2013-05-08 [email protected] Added continuous integration matrix for shared/static library (specified through environment variables).
2013-05-08 [email protected] Added continuous integration failure e-mail notification.
2013-05-08 [email protected] Added clang compiler for continuous integration.
2013-05-08 [email protected] Added basic Travis CI integration contributed by Igor Okulist.
2013-05-08 [email protected] Fixed CMake / Unix build instructions.
2013-05-08 [email protected] - New CMake based build system. Based in part on contribution from Igor Okulist and Damien Buhl (Patch google#14). Added support for running tests and building with DLL on Windows. - added missing JSON_API - Visual Studio DLL: suppressed warning "C4251: <data member>: <type> needs to have dll-interface to be used by..." via pragma push/pop in json-cpp headers. - New header json/version.h now contains version number macros (JSONCPP_VERSION_MAJOR, JSONCPP_VERSION_MINOR, JSONCPP_VERSION_PATCH and JSONCPP_VERSION_HEXA). While this header is generated by CMake, it is committed to ease build with alternate build system (CMake only update the file when it changes avoid issues with VCS).
2013-04-12 [email protected] - Patch #3393345: BOOST_FOREACH compatibility. Made Json::iterator more standard compliant, added missing iterator_category and value_type typedefs (contribued by Robert A. Iannucci). - Patch #3474563: added missing JSON_API on some classes causing link issues when building as a dynamic library on Windows (contributed by Francis Bolduc).
2013-04-12 [email protected] Patch #3600941: Missing field copy in Json::Value::iterator causing infinite loop when using experimental internal map (#define JSON_VALUE_USE_INTERNAL_MAP) (contributed by Ming-Lin Kao).
2013-04-12 [email protected] Patch #3539678: Copy constructor does not initialize allocated_ for stringValue (contributed by rmongia).
2013-02-18 [email protected] Fix gcc -Wall warnings (patch from Matt McCormick)
2012-12-20 [email protected] Fixed warning(error?) on #if testing value of _MSC_VER without checking that it was defined.
2012-07-27 [email protected] Added missing "include/json/assertions.h" header in amalgamate.py.
2012-03-12 [email protected] Made it possible to drop null placeholders from array output.


Roll ./third_party/yasm/ 86b605814..15439370a (1 commit)

https://chromium.googlesource.com/chromium/src/third_party/yasm/+log/86b6058141a4..15439370afd9

$ git log 86b605814..15439370a --date=short --no-merges --format='%ad %ae %s'
2019-03-14 thomasanderson More fixes necessary for Windows/libc++

Roll ./third_party/zlib/ f95aeb0fa..0f820c1d7 (24 commits)

https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/f95aeb0fa7f1..0f820c1d7165

$ git log f95aeb0fa..0f820c1d7 --date=short --no-merges --format='%ad %ae %s'
2019-08-08 adenilson.cavalcanti Allow disabling Castagnoli compression optimization
2019-08-05 adenilson.cavalcanti Increasing the expected compressed output size
2019-08-01 adenilson.cavalcanti Using the same hash function in compression on both x86 and ARM
2019-07-25 thakis Make chromeconf.h use opt-out instead of opt-in.
2019-07-19 darin Avoid 'internal_state' macro pollution from zlib.h.
2019-06-24 tsniatowski zlib: fix gn error when is_clang=false target_cpu="arm"
2019-06-11 scroggo Simplify sharing third_party/zlib with AOSP
2019-06-10 jose.dapena zlib: fix ARMv8 CRC32 compilation in GCC
2019-05-14 huangs [DOM Distiller] Compress resources to save 86 kB on Android.
2019-04-18 richard.townsend Tidy and further integrate Arm feature detection for Windows
2019-04-15 richard.townsend Correct zlib build logic for Windows on Arm
2019-04-15 noel [zlib] Add OS_FUCHSIA feature detection and enable zlib NEON crc32
2019-04-08 thomasanderson Make //third_party/zlib a component
2019-03-29 drubery Pass file_length to UpdateArchiveAnalyzer
2019-03-28 dcheng Update include paths for //base/hash/md5.h
2019-03-28 wnwen Android: Remove build/secondary
2019-02-15 noel [zlib] Add Android ARM aarch64 feature detection
2019-02-14 lizeb blink/bindings: Use PartitionAlloc for zlib's temporary data.
2019-02-13 noel [zlib_bench] improve program options handling
2019-01-31 adenilson.cavalcanti Enable decode input reads in 64 bit chunks
2019-01-11 lizeb blink/bindings: Use PartitionAlloc for compressing strings.
2019-01-08 avi Use base::size rather than arraysize in third_party/zlib/.
2019-01-02 avi Use base::size rather than arraysize in third_party/zlib/.
2018-12-20 msalama Avoid uncompressing if uncompressed size is too big.

Roll ./tools/md_browser/ e94626962..0bfd826f8 (2 commits)

https://chromium.googlesource.com/chromium/src/tools/md_browser/+log/e9462696241f..0bfd826f8566

$ git log e94626962..0bfd826f8 --date=short --no-merges --format='%ad %ae %s'
2019-06-18 ntfschr Docs: correctly slugify escaped chars
2019-06-01 ntfschr Better regex for md_browser.py

Created with:
  roll-dep ./build ./buildtools ./testing ./third_party/Python-Markdown ./third_party/fuchsia-sdk ./third_party/googletest ./third_party/jsoncpp ./third_party/jsoncpp/source ./third_party/yasm ./third_party/zlib ./tools/md_browser

Change-Id: Iac134649e58cf3b1d5ed13dc26e8c2bf3ebdba7b
Bug: angleproject:3792
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1744175
Reviewed-by: Jamie Madill <[email protected]>
Commit-Queue: Jamie Madill <[email protected]>
ChristopherHX pushed a commit to minecraft-linux/angle that referenced this pull request Aug 9, 2023
@i-nazarov-samsung
Add "angle_enable_context_mutex_recursion" build option
d61a50c 
Option is for Android Vulkan.

Fixes the recursion problem:
    #00 pc 000000000004d69c  /apex/com.android.runtime/lib64/bionic/libc.so (syscall+28) (BuildId: dda896312b8ac9c639f6aeb0175b8a0a)
    #1 pc 0000000000051e84  /apex/com.android.runtime/lib64/bionic/libc.so (__futex_wait_ex(void volatile*, bool, int, bool, timespec const*)+144) (BuildId: dda896312b8ac9c639f6aeb0175b8a0a)
    #2 pc 00000000000b41b4  /apex/com.android.runtime/lib64/bionic/libc.so (NonPI::MutexLockWithTimeout(pthread_mutex_internal_t*, bool, timespec const*)+236) (BuildId: dda896312b8ac9c639f6aeb0175b8a0a)
    #3 pc 00000000003d8274  /vendor/lib64/egl/libGLESv2_angle.so (std::__Cr::mutex::lock()+12) (BuildId: 203fee8f1cfe9c18)
    google#4 pc 0000000000336494  /vendor/lib64/egl/libGLESv2_angle.so (egl::SharedContextMutex<std::__Cr::mutex>::doLock()+132) (BuildId: 203fee8f1cfe9c18)
    google#5 pc 000000000033668c  /vendor/lib64/egl/libGLESv2_angle.so (egl::SharedContextMutex<std::__Cr::mutex>::lock()+124) (BuildId: 203fee8f1cfe9c18)
    google#6 pc 00000000001d6e08  /vendor/lib64/egl/libGLESv2_angle.so (EGL_ClientWaitSyncKHR+100) (BuildId: 203fee8f1cfe9c18)
    google#7 pc 00000000000674f0  /system/lib64/libEGL.so (android::eglClientWaitSyncKHRImpl(void*, void*, int, unsigned long)+112) (BuildId: c4698b8b366f6519dbd7bd3a5f6239f2)
    google#8 pc 0000000000086648  /system/lib64/libgui.so (android::BufferQueueProducer::dequeueBuffer(int*, android::sp<android::Fence>*, unsigned int, unsigned int, int, unsigned long, unsigned long*, android::FrameEventHistoryDelta*)+3240) (BuildId: ff35b91736084ee7c49efe908fb9f8f3)
    google#9 pc 00000000000e24fc  /system/lib64/libgui.so (android::Surface::dequeueBuffer(ANativeWindowBuffer**, int*)+392) (BuildId: ff35b91736084ee7c49efe908fb9f8f3)
    google#10 pc 0000000000755770  /system/lib64/libhwui.so (android::uirenderer::renderthread::ReliableSurface::hook_dequeueBuffer(ANativeWindow*, int (*)(ANativeWindow*, ANativeWindowBuffer**, int*), void*, ANativeWindowBuffer**, int*)+80) (BuildId: 0ab7d7584ac800860c4d180557441d1b)
    google#11 pc 00000000000e0b48  /system/lib64/libgui.so (android::Surface::hook_dequeueBuffer(ANativeWindow*, ANativeWindowBuffer**, int*)+92) (BuildId: ff35b91736084ee7c49efe908fb9f8f3)
    google#12 pc 000000000002cc8c  /system/lib64/libvulkan.so (vulkan::driver::AcquireNextImageKHR(VkDevice_T*, VkSwapchainKHR_T*, unsigned long, VkSemaphore_T*, VkFence_T*, unsigned int*)+280) (BuildId: 0c72f8685858f73fbb13fd68d401bba5)
    google#13 pc 0000000000266f08  /vendor/lib64/egl/libGLESv2_angle.so (rx::(anonymous namespace)::TryAcquireNextImageUnlocked(VkDevice_T*, VkSwapchainKHR_T*, rx::impl::ImageAcquireOperation*)+128) (BuildId: 203fee8f1cfe9c18)
    google#14 pc 000000000026495c  /vendor/lib64/egl/libGLESv2_angle.so (rx::WindowSurfaceVk::acquireNextSwapchainImage(rx::vk::Context*)+140) (BuildId: 203fee8f1cfe9c18)
    google#15 pc 0000000000265800  /vendor/lib64/egl/libGLESv2_angle.so (rx::WindowSurfaceVk::doDeferredAcquireNextImageWithUsableSwapchain(gl::Context const*)+148) (BuildId: 203fee8f1cfe9c18)
    google#16 pc 0000000000267bb4  /vendor/lib64/egl/libGLESv2_angle.so (rx::WindowSurfaceVk::getBufferAge(gl::Context const*, int*)+196) (BuildId: 203fee8f1cfe9c18)
    google#17 pc 000000000034143c  /vendor/lib64/egl/libGLESv2_angle.so (egl::Surface::getBufferAge(gl::Context const*, int*)+36) (BuildId: 203fee8f1cfe9c18)
    google#18 pc 000000000036c354  /vendor/lib64/egl/libGLESv2_angle.so (egl::QuerySurfaceAttrib(egl::Display const*, gl::Context const*, egl::Surface*, int, int*)+812) (BuildId: 203fee8f1cfe9c18)
    google#19 pc 00000000001d1674  /vendor/lib64/egl/libGLESv2_angle.so (egl::QuerySurface(egl::Thread*, egl::Display*, egl::SurfaceID, int, int*)+176) (BuildId: 203fee8f1cfe9c18)
    google#20 pc 00000000001d3658  /vendor/lib64/egl/libGLESv2_angle.so (EGL_QuerySurface+200) (BuildId: 203fee8f1cfe9c18)

Happens only on platforms that use "EGL_KHR_fence_sync" instead of
"EGL_ANDROID_native_fence_sync" for synchronization. Happens only on
specific Surface types, that using `EGLConsumer`/`GLConsumer`, such as
`SurfaceTexture`.

The Android's "testDrawingHardwareBitmapNotLeaking" test may be used for
testing the issue. Note: in order to reproduce, `SingleContextMutex`
must not be used by context. The "Fix ExternalImageTarget EGLImage race"
CL will achieve that.

To check what extension is used, call:
    adb shell "dumpsys SurfaceFlinger | grep 'Sync configuration'"
Possible results:
    Sync configuration: [using: EGL_KHR_fence_sync EGL_KHR_wait_sync]
    Sync configuration: [using: EGL_ANDROID_native_fence_sync EGL_KHR_wait_sync]

Bug: angleproject:4354
Change-Id: I915a2c026b59af0a2098ae6b3300f773b29cbfbb
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4733831
Commit-Queue: Igor Nazarov <[email protected]>
Reviewed-by: Shahbaz Youssefi <[email protected]>
annestrand pushed a commit to annestrand/angle that referenced this pull request Sep 25, 2023
@i-nazarov-samsung
Fix ASSERT and potential bug with UnlockedTailCall
73252f3 
ASSERT happened in the Instagram application.
- record REEL using camera;
- press "Next" button;
- return to the previous screen;
- ASSERT happens.

Crash details:
    pid: 31451, tid: 2938, name: mediacompositio  >>> com.instagram.android <<<
    signal 6 (SIGABRT), code -6 (SI_TKILL), fault addr --------
    Abort message: 'FATAL: entry_points_egl_autogen.cpp:437 (EGL_GetError):      ! Assert failed in EGL_GetError (../../src/libGLESv2/entry_points_egl_autogen.cpp:437):
    backtrace:
          ...
          google#7 pc 0000000000627740  /vendor/lib64/egl/libGLESv2_samsung.so (gl::LogMessage::~LogMessage()+140) (BuildId: acced3587e668343)
          google#8 pc 000000000027e79c  /vendor/lib64/egl/libGLESv2_samsung.so (EGL_GetError+360) (BuildId: acced3587e668343)
          google#9 pc 000000000007c14c  /system/lib64/libEGL.so (android::eglGetErrorImpl()+28) (BuildId: 5b32b014e5c062afdd3d1abd3ba13dd2)
          google#10 pc 0000000000079464  /system/lib64/libEGL.so (eglDestroyImageKHR+20) (BuildId: 5b32b014e5c062afdd3d1abd3ba13dd2)
          google#11 pc 000000000000e540  /system/lib64/libnativedisplay.so (android::EGLConsumer::EglImage::~EglImage()+44) (BuildId: 3b0b03d2c8ab7eb49d16eb7be29eb3fd)
          google#12 pc 000000000000e598  /system/lib64/libnativedisplay.so (android::EGLConsumer::EglImage::~EglImage()+16) (BuildId: 3b0b03d2c8ab7eb49d16eb7be29eb3fd)
          google#13 pc 000000000000e434  /system/lib64/libnativedisplay.so (android::EGLConsumer::onFreeBufferLocked(int)+156) (BuildId: 3b0b03d2c8ab7eb49d16eb7be29eb3fd)
          google#14 pc 000000000000bda0  /system/lib64/libnativedisplay.so (android::SurfaceTexture::freeBufferLocked(int)+48) (BuildId: 3b0b03d2c8ab7eb49d16eb7be29eb3fd)
          google#15 pc 00000000000bc294  /system/lib64/libgui.so (android::ConsumerBase::onBuffersReleased()+172) (BuildId: f219f4196018eeed01e28ec428c73c99)
          google#16 pc 000000000008d9d4  /system/lib64/libgui.so (android::BufferQueue::ProxyConsumerListener::onBuffersReleased()+92) (BuildId: f219f4196018eeed01e28ec428c73c99)
          google#17 pc 0000000000099608  /system/lib64/libgui.so (android::BufferQueueProducer::disconnect(int, android::IGraphicBufferProducer::DisconnectMode)+184) (BuildId: f219f4196018eeed01e28ec428c73c99)
          google#18 pc 00000000000eb3ec  /system/lib64/libgui.so (android::Surface::disconnect(int, android::IGraphicBufferProducer::DisconnectMode)+268) (BuildId: f219f4196018eeed01e28ec428c73c99)
          google#19 pc 00000000000eaf04  /system/lib64/libgui.so (android::Surface::hook_perform(ANativeWindow*, int, ...)+264) (BuildId: f219f4196018eeed01e28ec428c73c99)
          google#20 pc 0000000000031214  /system/lib64/libvulkan.so (vulkan::driver::DestroySurfaceKHR(VkInstance_T*, VkSurfaceKHR_T*, VkAllocationCallbacks const*)+56) (BuildId: 44c563855311012ead3ce5e7afdb9792)
          google#21 pc 000000000039bb40  /vendor/lib64/egl/libGLESv2_samsung.so (void std::__Cr::__function::__policy_invoker<void (void*)>::__call_impl<std::__Cr::__function::__default_alloc_func<rx::WindowSurfaceVk::destroy(egl::Display const*)::$_0, void (void*)> >(std::__Cr::__function::__policy_storage const*, void*)+140) (BuildId: acced3587e668343)
          google#22 pc 0000000000522114  /vendor/lib64/egl/libGLESv2_samsung.so (angle::UnlockedTailCall::runImpl(void*)+56) (BuildId: acced3587e668343)
          google#23 pc 000000000027dcec  /vendor/lib64/egl/libGLESv2_samsung.so (EGL_DestroySurface+260) (BuildId: acced3587e668343)

This CL will fix the ASSERT as well as remove possibility of calling
same callback twice.

Bug: angleproject:8127
Change-Id: I8e56981d0db2ef5723afedc22d5286421237444b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4874040
Reviewed-by: Shahbaz Youssefi <[email protected]>
Commit-Queue: Igor Nazarov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kant @vonture