You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I have searched for similar issues before opening a new one.
Description
Following the merge of #8550, there are now several mocha tests with fail with a considerable degree of reliability (about 100% reproducible on my local machine, and reliably enough in CI to cause test failures to prevent PRs from being merged:
I am planning to temporarily disable these, but we should fix them and then reenable them.
Reproduction steps
Run npm ci
Run npm test
Observe errors.
Stack trace
[16:02:36] Starting 'mocha'...
=======================================
== mocha
Starting webdriverio...
Loading URL: file:///Users/cpcallen/src/blockly/tests/mocha/index.html
============Blockly Mocha Test Failures================
"WorkspaceSvg cleanUp two blocks first at (10, 15) second at (0, 0) do not switch places" failed: block1 is below block2: expected Coordinate{ x: +0, y: 52 } to deeply equal Coordinate{ x: +0, y: 50 }
"WorkspaceSvg cleanUp two overlapping blocks are moved to origin and below" failed: block2 is below block1: expected Coordinate{ x: +0, y: 52 } to deeply equal Coordinate{ x: +0, y: 50 }
"WorkspaceSvg cleanUp two overlapping blocks are moved to origin and below including children" failed: block2 is below block1: expected Coordinate{ x: +0, y: 52 } to deeply equal Coordinate{ x: +0, y: 50 }
"WorkspaceSvg cleanUp two large overlapping blocks are moved to origin and below" failed: block2 is below block1: expected Coordinate{ x: +0, y: 149 } to deeply equal Coordinate{ x: +0, y: 144 }
============Blockly Mocha Test Summary=================
4 tests failed
============Blockly Mocha Test Summary=================
Mocha tests failed
FAILED: mocha
[16:02:54] Finished 'mocha' after 18 s
Screenshots
No response
Browsers
No response
The text was updated successfully, but these errors were encountered:
Did some analysis on this. Across >4500 runs on my local machine of WorkspaceSvg, I saw zero test failures. I suspect this is an environment-specific problem which might explain why it's a 100% repro for you @cpcallen, 0% for me, and flaky on CI.
Either way, despite the oddity of why the test behavior even differs across different systems, I think we can possibly improve the robustness of the tests by replacing some of the deep equals checks with relative checks.
Check for duplicates
Description
Following the merge of #8550, there are now several mocha tests with fail with a considerable degree of reliability (about 100% reproducible on my local machine, and reliably enough in CI to cause test failures to prevent PRs from being merged:
I am planning to temporarily disable these, but we should fix them and then reenable them.
Reproduction steps
npm ci
npm test
Stack trace
Screenshots
No response
Browsers
No response
The text was updated successfully, but these errors were encountered: