Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Disable failing tests #8677

Merged
merged 1 commit into from
Dec 4, 2024
Merged

Conversation

cpcallen
Copy link
Contributor

The basics

The details

Resolves

This is a temporary workaround for #8676.

Proposed Changes

Disable four tests added in #8550 that fail reliably enough to prevent PRs from being merged.

Reason for Changes

I'd like to be able to merge other PRs.

Test Coverage

Slightly reduced.

Additional Information

It is unclear to me how we have succeeded in merging so many PRs since #8550 was merged. It seems that these tests do no always fail in CI (e.g., one recent test run I had them succeed when run on node v18 and v20, but fail on v22, even though the node version should be irrelevant for Mocha tests beyond whether webdriver is able to successfully run the suite as a whole), but they do seem to always fail for me locally. Perhaps people have just been re-starting failed test jobs until all three build/test jobs succeed simultaneously?

@cpcallen cpcallen requested a review from a team as a code owner November 28, 2024 16:59
@cpcallen cpcallen requested a review from gonfunko November 28, 2024 16:59
@cpcallen cpcallen enabled auto-merge (squash) November 28, 2024 16:59
@cpcallen cpcallen requested a review from BenHenning November 28, 2024 17:00
@cpcallen cpcallen added component: tests PR: chore General chores (dependencies, typos, etc) labels Nov 28, 2024
@cpcallen
Copy link
Contributor Author

…aaand this PR has been itself been victim of another flaky test:

[17:00:23] Starting 'mocha'...
=======================================
== mocha

  Starting webdriverio...
  Loading URL: file:///home/runner/work/blockly/blockly/tests/mocha/index.html
  ============Blockly Mocha Test Failures================
  "Connection checker Dragging Checks Stacks Connect to bottom of unmovable stack" failed: Should connect below an unmovable stack block: expected false to be true
  Mocha tests failed
  ============Blockly Mocha Test Summary=================
  1 tests failed
  ============Blockly Mocha Test Summary=================
FAILED: mocha
[17:00:48] Finished 'mocha' after 26 s

☹️☹️☹️

@cpcallen cpcallen merged commit 4680b4b into google:develop Dec 4, 2024
12 checks passed
@cpcallen
Copy link
Contributor Author

cpcallen commented Dec 4, 2024

Closing this as Ben is actually fixing the tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: tests PR: chore General chores (dependencies, typos, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants