Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added an API to programmatically scroll the workspace #7532

Merged
merged 2 commits into from
Sep 23, 2023

Conversation

SophieNguyen113
Copy link
Contributor

@SophieNguyen113 SophieNguyen113 commented Sep 22, 2023

The basics

The details

Resolves

Fixes #7176

Proposed Changes

Added an API to programmatically scroll the workspace
Removed the @internal
All changes were in workspace_svg.ts file

Reason for Changes

Make it easier for users to use the ToolBox and WorkSpace

Test Coverage

Documentation

Additional Information

Feat: Added an API to programmatically scroll the workspace
Copy link
Contributor

@maribethb maribethb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @SophieNguyen113 , thank you for the pull request! It looks like we're almost there! Some formatting got changed, but we can probably fix it automatically: run npm run format to run the formatter and it should hopefully automatically fix the indentation! Then you can run npm run lint to ensure the lint warning goes away.

If you commit the changes and push them to the same branch, they'll automatically be added to this pull request. Let us know if you need any help with this process!

@SophieNguyen113
Copy link
Contributor Author

Hi @SophieNguyen113 , thank you for the pull request! It looks like we're almost there! Some formatting got changed, but we can probably fix it automatically: run npm run format to run the formatter and it should hopefully automatically fix the indentation! Then you can run npm run lint to ensure the lint warning goes away.

If you commit the changes and push them to the same branch, they'll automatically be added to this pull request. Let us know if you need any help with this process!

Hi, thank you for a helpful comment. I did address your comment. Please review and tell me if you need anything more from me :>
I was so excited to contribute to Blockly. Again, thank you so much for all the efforts and support.
Have a great day.

Copy link
Contributor

@maribethb maribethb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Thank you for the contribution!

@maribethb maribethb merged commit 31a323a into google:osd Sep 23, 2023
7 checks passed
@maribethb maribethb changed the title Feat: Added an API to programmatically scroll the workspace feat: Added an API to programmatically scroll the workspace Sep 26, 2023
@github-actions github-actions bot added the PR: feature Adds a feature label Sep 26, 2023
@BeksOmega BeksOmega linked an issue Sep 29, 2023 that may be closed by this pull request
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: feature Adds a feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add an API to programmatically scroll the workspace
2 participants