-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add a blocklyNumberField CSS class to number fields #8414
Conversation
Hello, can you rebase this so that the changes are against You can follow these steps:
Once you've done this, the PR should be on the correct branch. Let me know if you have any questions or run into any issues! |
@Apocalypse96 Are you still interested in working on this? |
ya sure |
In that case, could you follow the rebase instructions I posted above? |
@BeksOmega I've rebased can u review the pr |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great thank you for the fixes! Once this passes CI I'll get it merged =)
The basics
The details
Resolves
Fixes #8313
Proposed Changes
This PR adds a 'blocklyNumberField' CSS class to the FieldNumber element. Specifically:
initView
method in the FieldNumber classReason for Changes
This change allows for more specific styling of number fields in Blockly, as requested in issue #8313. It provides a way to target number fields specifically in CSS, enhancing the ability to customize the appearance of these fields.
Test Coverage
I manually tested these changes by:
Additional unit tests could be created to ensure the
initView
method is called and applies the class correctly.Documentation
No documentation updates are required for this change, as it doesn't affect the public API or usage of Blockly. However, it might be beneficial to add a note in the theming documentation about the availability of this new CSS class for styling number fields.
Additional Information
This change is backwards-compatible and should not affect existing Blockly implementations. It simply adds an additional CSS class that can be used for more specific styling if desired.