Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added blocklyImageField CSS class to image fields #8439

Merged
merged 1 commit into from
Jul 30, 2024

Conversation

vexora-0
Copy link

@vexora-0 vexora-0 commented Jul 28, 2024

Issue -> #8314

fixes #8314

Description :

This pull request introduces a change to the FieldImage class in Blockly to enhance the styling capabilities of image fields. By adding the blocklyImageField CSS class to the fieldGroup_ element, developers can now apply custom styles more easily to image fields within Blockly.

Changes Made :

  • Modified the initView method in core/field_image.ts to call dom.addClass with this.fieldGroup_ and 'blocklyImageField'.

Details:

The initView method has been updated to ensure that the blocklyImageField CSS class is applied to the fieldGroup_ element whenever an image field is initialized. This addition enhances the flexibility for developers to customize the appearance of image fields using CSS.

Branch :

  • This change has been made against the rc/v12.0.0 branch.

By adding the blocklyImageField class, developers can now easily apply CSS styles specific to image fields, enhancing the visual customization options available in Blockly.

@vexora-0 vexora-0 requested a review from a team as a code owner July 28, 2024 15:56
@vexora-0 vexora-0 requested a review from rachel-fenichel July 28, 2024 15:56
@vexora-0
Copy link
Author

hey @BeksOmega I have got all requirements please check my pr

@BeksOmega BeksOmega requested review from BeksOmega and removed request for rachel-fenichel July 30, 2024 02:22
Copy link
Collaborator

@BeksOmega BeksOmega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Thank you for the fix =) Once CI passses I"ll get this merged!

[Edit: oh nevermind, CI has already passed! Thank you again!]

@BeksOmega BeksOmega merged commit 4b95cb7 into google:rc/v12.0.0 Jul 30, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants