-
Notifications
You must be signed in to change notification settings - Fork 978
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Same filename for input and output doesn't work #20
Comments
ignore or delete that commit....sorry i am new to github |
I just started learning c++ so forgive my ignorance Check my attempt to solve the problem However i seems to get an issue in trying to get bazel to see my changes while compiling(sounds crazy and stupid) I tried the following Modified the error message ( |
I think we should allow optimization only with one image as argument, code will look like this: |
@Furniel I don't want to encourage people to use the same file for input and output, because it generally creates confusion that leads to someone running an image through Guetzli twice (or more). Passing an image multiple times through Guetzli is not equivalent to passing it once, and will generate visible artifacts. |
This will prevent us from failing when the output and input file are the same file. It will also prevent us from truncating the output file if e.g. parsing of the input file fails. This causes us to fail late if the output file is not writable, though. Fixes google#20.
This will prevent us from failing when the output and input file are the same file. It will also prevent us from truncating the output file if e.g. parsing of the input file fails. This causes us to fail late if the output file is not writable, though. Fixes google#20.
This will prevent us from failing when the output and input file are the same file. It will also prevent us from truncating the output file if e.g. parsing of the input file fails. This causes us to fail late if the output file is not writable, though. Fixes #20.
Split away form #19. We should probably open the output file for writing first and truncate it only after we have the output JPEG ready.
The text was updated successfully, but these errors were encountered: