Write output to a temp file and rename it afterwards. #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PTAL |
szabadka
reviewed
Jan 17, 2017
| @@ -196,12 +196,6 @@ int main(int argc, char** argv) { | |||
| return 1; | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
Done. Not here, because the file is used later.
This will prevent us from failing when the output and input file are the same file. It will also prevent us from truncating the output file if e.g. parsing of the input file fails. This causes us to fail late if the output file is not writable, though. Fixes google#20.
szabadka
approved these changes
Jan 17, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #20