Support for jakarta annotations #1490

hejcz · 2021-02-19T06:16:49Z

Do you have any time estimations for supporting jakarta.* annotations? We want to migrate to Jersey 3 but it's impossible because GuiceFilter implements javax.servlet.Filter. Another problem is #1383.

The text was updated successfully, but these errors were encountered:

kashike · 2021-02-19T06:38:07Z

#1383

hejcz · 2021-02-19T07:15:58Z

#1383 mentions only jakarta.inject so I don't know if it adresses the same scope of changes.

GedMarc · 2021-02-19T09:11:41Z

You can also use
https://search.maven.org/artifact/com.guicedee.services/guice

which is a compiled guice (from master branch/5) with all references on jakarta -

nsoft · 2021-07-27T14:30:37Z

I have a "quickfix" support for this which was done by the ugly but expedient strategy of copying a bunch of classes into new packages and editing them, not guaranteed to work for everything, and I'm not committing maintaining it, but my Shiro/Guice integrated application seems to be running fine with it on Tomcat 10. https://github.com/nsoft/guice/commits/jakarta-servlet. guicedee is probably great, but if you have things other than your own code that depend on guice in your stack, it's not really an option. (shiro 1.8 hacked to use my fork of guice is here: https://github.com/nsoft/shiro/tree/SHIRO-814_1_8)

Posting these mostly to encourage the Guice maintainers to do something about this.

According to google/guice#1490, we can use guicedee. We can use the persistence module directly as documented at https://guicedee.com/dbmodules.html. It looks like the only change for the major version upgrade is a name change from `javax.persistence` -> `jakarta.persistence`. This commit does the name change and creates its own version of the `SupportedLanguageJpaConverter` which can be later moved to pay-java-commons when we get all the other java apps using the org.eclipse.persistence library upgraded.

…ence According to google/guice#1490, we can use guicedee. We can use the persistence module directly as documented at https://guicedee.com/dbmodules.html. It looks like the only change for the major version upgrade is a name change from `javax.persistence` -> `jakarta.persistence`. This commit does the name change and creates its own version of the `SupportedLanguageJpaConverter` which can be later moved to pay-java-commons when we get all the other java apps using the org.eclipse.persistence library upgraded.

onacit · 2022-02-09T09:20:59Z

@GedMarc Check this out, yo.

docent · 2022-05-11T10:32:23Z

Bumping this for visibility. We have to recompile Guice in order to move to to the new jakarta.inject and jakarta.servlet packages. Not ideal...

krisso-rtb · 2022-08-31T16:55:57Z

Logback switched from javax.servlet-api to jakarta.servlet-api in version 1.4.0.
We have guice 5.1.0 which (still) doesn't have support for jakarta.servlet-api.
It basically means we're blocked with upgrading to the newer logback.

Could we somehow fix the World? 😄

froque · 2022-08-31T17:40:33Z

@krisso-rtb there is logback 1.3 to solve that problem https://logback.qos.ch/news.html

But your point remains, the lack of Jakarta support in Guice is a show stopper for us

ben-manes · 2022-09-28T21:01:45Z

@sameb could we get something simple and low effort to be forward compatible? Maybe a new extension, guice-jakarta-servlet, that forks the old one with the updated imports? I don't think the community is asking for much, just a little support so that we can update our http servlet engines (tomcat, jetty, etc).

sameb · 2022-09-28T21:39:36Z

I haven't followed the discussion... but I think you'll find that if we bundled a different servlet extension, it would suffer from a lack of maintenance. While basically ~every java server in Google depends on Guice (and thus we're careful to keep it stable and working well), nothing would depend on this new extension. Very few servers even depend on the existing servlet extension (as we primarily use a different technology internally). Other folks are in a better position to ensure a new servlet extension exists and is maintained. If you're just looking for a fork of the servlet extension, there shouldn't be anything special about the existing one that requires co-bundling/shipping privileges. OTOH, if you're looking for a fork of core Guice itself, that's unlikely to happen.

…

On Wed, Sep 28, 2022, 5:01 PM Ben Manes ***@***.***> wrote: @sameb <https://github.com/sameb> could we get something simple and low effort to be forward compatible? Maybe a new extension, guice-jakarta-servlet, that forks the old one with the updated imports? I don't think the community is asking for much, just a little support so that we can update our http servlet engines (tomcat, jetty, etc). — Reply to this email directly, view it on GitHub <#1490 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAQLWERF56N6JEPQRRE65P3WASW4LANCNFSM4X3Y6AIA> . You are receiving this because you were mentioned.Message ID: ***@***.***>

ben-manes · 2022-09-29T00:38:39Z

I don't think there is an ask for on going maintenance beyond what is done today. The existing extension is perfect. The problem is that Eclipse hard forked the namespace and forced the community to transition from javax to jakarta so that they did not have to participate in JEP / JCP (an IBM vs Oracle tantrum). In that transition all that is required is a find-and-replace of the import.

Since Guice is still broadly used but lacks an active community having something in core is useful for trust reasons. A random github user's non-discoverable, unmaintained dependency is not as attractive as a frozen Google dependency. Otherwise it's a forcing function to drop Guice externally to Google, so just a tiny bit of help would keep this excellent library alive for us otherwise very happy users (e.g. see #1630 where the work was done).

sameb · 2022-09-29T01:39:12Z

Ugh, what a horrible mess. Silly IBM.

The proposed pull request is both invasive (on the core guice side), and a huge pit of code duplication (on the servlet extension side).

For servlet, I honestly think the best outcome is for someone else to create and host it. I'd be happy to point to it from any "official" docs. But us bundling it seems like a bad idea. The existing servlet extension already has bugs, and we don't really maintain it except for keeping it compiling. Someone could probably fork it and make it much better already. I'm loathe to copy/paste and search/replace a large swathe of code, especially when it will have zero ongoing usages that we can validate.

As for the annotation/provider support... it adds a bunch of SPI classes and API methods. It's not all that appealing.

@mcculls -- what are y'all doing with Maven? Is this impacting you?

Let me talk to a few folks internally and see what the deal is. I imagine this impacts Dagger too?

What a gross situation.

techwhizbang · 2022-12-22T21:29:04Z

To echo what others have said our team recently went to upgrade from Jetty 9.x to Jetty 11.x. We realized that we were blocked because the newer Jetty depends on the new jakarta.servlet-api and Guice is using the older javax.servlet API.

A large swath of the most widely used libraries in the Java community have moved on and have adopted jakarta.servlet-api. Some well known projects that use the servlet APIs maintained two versions during the transition pointing at the old and new servlet API. Honestly though when you look at the adoption it becomes clearer there is no looking back.

As this continues to shake out can the Guice community get a version of Guice servlet extension with jakarta.servlet-api(one that isn't forked)?

What a lovely Christmas present this would be 🎄🎅 😄

ryru · 2023-03-06T17:18:37Z

We can't update to Tomcat 10 at the moment because Guice still has dependencies on javax.servlet.*. As others have pointed out, a Guice fork is not an option for us.

@sameb, any news from the internal team?

ben-manes · 2023-03-06T17:30:28Z

fwiw, for gradle users we can maybe use gradle-jakartaee-migration-plugin as a stop gap. I haven't tried it yet.

JKomoroski · 2023-04-17T20:55:07Z

There is also this option: #1383 (comment)

sameb · 2023-04-25T17:01:09Z

Duplicate of #1383

…rt for `toProvider(...)` to instances of `jakarta.inject.Provider` or classes/keys/typeLiterals of type `jakarta.inject.Provider`. See #1383 (comment) for details of the plans. The Guice 6.0 release will support `javax.inject` _and_ `jakarta.inject` (excluding `toProvider()` support for `jakarta.inject`), and the Guice 7.0+ release will remove the `javax.inject` references. Further background on these issues: * #1630 * #1679 * #1490 * #1383 PiperOrigin-RevId: 526763665

This does not add support for `toProvider(...)` to instances of `jakarta.inject.Provider` or classes/keys/typeLiterals of type `jakarta.inject.Provider`. See #1383 (comment) for details of the plans. The Guice 6.0 release will support `javax.inject` _and_ `jakarta.inject` (excluding `toProvider()` support for `jakarta.inject`), and the Guice 7.0+ release will remove the `javax.inject` references. Further background on these issues: * #1630 * #1679 * #1490 * #1383 PiperOrigin-RevId: 526763665

This does not add support for `toProvider(...)` to instances of `jakarta.inject.Provider` or classes/keys/typeLiterals of type `jakarta.inject.Provider`. See #1383 (comment) for details of the plans. The Guice 6.0 release will support `javax.inject` _and_ `jakarta.inject` (excluding `toProvider()` support for `jakarta.inject`), and the Guice 7.0+ release will remove the `javax.inject` references. Further background on these issues: * #1630 * #1679 * #1490 * #1383 PiperOrigin-RevId: 527349023

oswaldquek mentioned this issue Sep 28, 2021

Bump org.eclipse.persistence.jpa from 2.7.7 to 3.0.2 alphagov/pay-products#701

Closed

oswaldquek mentioned this issue Sep 29, 2021

Upgrade hibernate version to support JPA 3.0 #1541

Closed

froque mentioned this issue Jul 5, 2022

Move to jakarta packages premium-minds/billy#157

Open

DavidWhitlock mentioned this issue Nov 26, 2022

Upgrade to Jetty 11 JoyOfCodingPDX/JoyOfCoding#404

Closed

sameb marked this as a duplicate of #1383 Apr 25, 2023

sameb closed this as not planned Won't fix, can't repro, duplicate, stale Apr 25, 2023

copybara-service bot mentioned this issue Apr 26, 2023

Add support for jakarta.inject to core Guice. #1711

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support for jakarta annotations #1490

Support for jakarta annotations #1490

hejcz commented Feb 19, 2021

kashike commented Feb 19, 2021

hejcz commented Feb 19, 2021

GedMarc commented Feb 19, 2021

nsoft commented Jul 27, 2021

onacit commented Feb 9, 2022

docent commented May 11, 2022

krisso-rtb commented Aug 31, 2022

froque commented Aug 31, 2022

ben-manes commented Sep 28, 2022

sameb commented Sep 28, 2022 via email

ben-manes commented Sep 29, 2022 •

edited

Loading

sameb commented Sep 29, 2022

techwhizbang commented Dec 22, 2022

ryru commented Mar 6, 2023

ben-manes commented Mar 6, 2023

JKomoroski commented Apr 17, 2023

sameb commented Apr 25, 2023

Support for jakarta annotations #1490

Support for jakarta annotations #1490

Comments

hejcz commented Feb 19, 2021

kashike commented Feb 19, 2021

hejcz commented Feb 19, 2021

GedMarc commented Feb 19, 2021

nsoft commented Jul 27, 2021

onacit commented Feb 9, 2022

docent commented May 11, 2022

krisso-rtb commented Aug 31, 2022

froque commented Aug 31, 2022

ben-manes commented Sep 28, 2022

sameb commented Sep 28, 2022 via email

ben-manes commented Sep 29, 2022 • edited Loading

sameb commented Sep 29, 2022

techwhizbang commented Dec 22, 2022

ryru commented Mar 6, 2023

ben-manes commented Mar 6, 2023

JKomoroski commented Apr 17, 2023

sameb commented Apr 25, 2023

ben-manes commented Sep 29, 2022 •

edited

Loading