-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade hibernate version to support JPA 3.0 #1541
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@googlebot I signed it! |
@oswaldquek There is a Jakarta namespace for Guice already right now - It is under the guicedee.com maven group - and supports JPMS fully up the chain (For JLink builds) Guice - https://mvnrepository.com/artifact/com.guicedee.services/guice For HIbernate versions below 6 with Jakarta and Guice support you can also use the hibernate-x libraries under the same maven group - Ref https://hibernate.atlassian.net/browse/HHH-14837?jql=project%20%3D%20HHH%20AND%20text%20~%20Jakarta https://mvnrepository.com/artifact/com.guicedee.services/hibernate-core |
@GedMarc Thanks - I saw that on the other issues, however I'm not sure how official guicedee is. It also appears to have a different licence, and only 2 stars and 1 fork. |
@oswaldquek Yep, But I do know, or strongly under the impression, Guice for the time being is on the javax. namespace for the foreseeable future :) Still sorting out AOP on JDK's above version 9 with the new strict encapsulation rules. Hibernate itself also has a JRT issue which is being resolved as well - https://hibernate.atlassian.net/browse/HHH-14858?jql=order%20by%20created%20DESC / hibernate/hibernate-orm#4265 But someone had to do it yes? All of these things had to be found, and resolved, for us to continue development and build native runtimes - 2 stars and 1 fork or not xD Reliability of a project is determined by its maintenance factor no? @mcculls Do we know if there is any target to move Guice to Jakarta namespace, or is it currently just the AOP being worked on? |
@GedMarc Of course, reliability isn't determined by stars or fork. I did try using https://guicedee.com/dbmodules.html, and it worked 😄 Unfortunately however my organisation is more concerned with using official libraries and with the relevant licensing. |
@oswaldquek What licensing are you looking for? I think I've put it onto Apache 2.0 / tried to have the most open :) All the services are just fixed up shades of the official libraries, you can use all the services/libraries without touching the guiced-ee layer at all ;) Thanks for giving it a try though! Sorry it didn't work out, but I'll definitely cater and make it more open (Do you have a license model you prefer or are looking specifically for?) All the services are licensed GPL3 double checking, :) Oh, you can also inspect each individual packaging if you are concerned here - https://github.com/GedMarc/GuicedEE-Services/tree/master Let me know if there is anything I can do to improve your experience :) <3 |
Sort of related to "jakarta" naming issues in #1490 and #1383. Upgrading the hibernate library - which uses the
jakarta.persistence
namespace - in the persistence extension seems to work fine on its own.This PR might not be accepted as it leaves a mix of
jakarta.persistence
andjavax.*
in the guice library but thought I'd give it a try. At least it was pretty low effort to do!